Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <0bfd445a-81f7-f702-08b0-bd5a72095e49@amd.com>
Date:   Mon, 31 Jul 2023 11:02:40 -0500
User-Agent: Mozilla Thunderbird
Content-Language: en-US
From:   "Limonciello, Mario" <mario.limonciello@amd.com>
Subject: Error 'netif_napi_add_weight() called with weight 256'
To:     kuba@kernel.org, hayeswang@realtek.com, edumazet@google.com
Cc:     LKML <linux-kernel@vger.kernel.org>, netdev@vger.kernel.org,
        davem@davemloft.net, linux-usb@vger.kernel.org, pabeni@redhat.com,
        Paul Menzel <pmenzel@molgen.mpg.de>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?anRXR1JFOXA5QkdzeTVscGl6aGhYN0piZGxMMXl3dmZuVFZnVDZ5OExmbFdh?=
 =?utf-8?B?MmplRUpNSmpUcEpmTWZTengzYkQwSCtmUEhSVjZuaE0rWlp4ZnRXcXQyRGxS?=
 =?utf-8?B?VWRBL3hjYm9RYTFaK0ZWNG8zTXd0MGM1OWkvYWpBWDUrOU8xdHJYUjd5eGly?=
 =?utf-8?B?TjdKQjNTb0pvWU53ME5kbmRFTnhsQnJCdzNWTDZpc3h1KzloUW5ybDhkc2xs?=
 =?utf-8?B?alkvSThERytqMlExem9oOXNGSTZIa2xLRE9UcWhWQUhwNFZ3cmN6ZUxUR1Ny?=
 =?utf-8?B?aDY5ZmdoOWFpcXlvOGkxNUNSMWtkVUdSd2RjSEpPZUhCRWMyeHFXZzVOZWhl?=
 =?utf-8?B?S0t3MFBzOHVlZG1LVWZubUc2RU4wb2g3NTRzSXpOVFBMWkVBQmtaUm1Dbkc2?=
 =?utf-8?B?Ylo0djRId3JOSklNOTdUZFpkZ3R6TlBTc0hlQ2ViRGVRcCt3ZEtVa0VvZmsy?=
 =?utf-8?B?SFVoekVrK0h3TEJrSWl2TTVnOENXL2RLazIwalZxRWtHc1VDbFV5NXNoRFM3?=
 =?utf-8?B?T3J1a0EvbVd4c2IxRmo1TlpZYUZ2YUF0TEVDNkxlbUdWSFRSYUNSZUg5Q29Y?=
 =?utf-8?B?R0RsQjV0OXBYQ2Y0Ly9xLzdmNEZKUzdWc2U1NmFRakhUeXV4Tm52YzVKSHdS?=
 =?utf-8?B?ODJlM1pWOTJ4UGhJcURRblBmYUVRZ3JtN3Z6OWNFUGh3YzhLNm1NNFFQWG5u?=
 =?utf-8?B?S2JkVitlMmYxRE1TVnByYndXR2ErR2xqNCt3RUpiVi9wNE0zUmZpbDBHOHFK?=
 =?utf-8?B?RjEwVy9LU3lqMERoUGhZc01XdDQ2SFF4VllEL0pzcysrcU9XaTh4MkpsTkhS?=
 =?utf-8?B?a1UvdlRQY3NmWFdLYThPSzIxM1ZCdlVnQUtNb3I0Q2hUVXp5MkxocWZibnAr?=
 =?utf-8?B?anhSWmh6TzU3aXpjeUlRRGMwTy9KZmpzaE1TRFB5c1hYVndXb1JvVWJOdzRz?=
 =?utf-8?B?a1ZlWXZJMnA3Mnp6OTdNZWZ2UXNOdTY4Y1BoZXBibUlMUzhhV05OUlpmQUUw?=
 =?utf-8?B?NmZIMVBNTjNnVG41dXV3RWpwQVFoalpyemVqaGZGcmFNQ3F5aEJlaE9zYzZj?=
 =?utf-8?B?ZVBuK01ZUTZRVmdBTjFjYXZXZThKcTBVS0orOFcvdmo2eWlZdW9rTE9hZkYw?=
 =?utf-8?B?QWNRMjA3RzU4Nk95cldJMGprMWV5STg0T1dVUE0wbG0zK2d3UHZKR3Nnb05n?=
 =?utf-8?B?NUpYb0kyajdTdXp5ZlRzNVI4RW5MQ0I5WmduUUowaHdaM212V1Fvb2h2Uy8v?=
 =?utf-8?B?U0QwZEhBSWtBS0JoZE5XRVRNSVhMaWp0dEFGOHgvNGV5SFExTzNPTDV6V0U3?=
 =?utf-8?B?RVZJWXU5VnhaWHpRYkJjR2tMenpnaGk5U3g0QjVBRDVXNElmT0JqMG5zcllO?=
 =?utf-8?B?NHIzREFsZklJeElMWVk1dFBrbWhVOEZRbU9vUUdNWmZFNExWbERhTi9Gb29Y?=
 =?utf-8?B?SmxjWEo1ZGZ5b3VGRVlyY3NZQU5OMzJFa2FjTWtKT3pQUXM1M2h4b3ZmWkRu?=
 =?utf-8?B?QUp2WE4xYmhDeGRmbHdXeCtUVHhMSy9UUmUxNTdqd25hdXNVMnBjdzFnZE1M?=
 =?utf-8?B?aG1KaExibmZHanBmSUVQRG1EZGIvcGxKSU5RQnFBMHp5c21iN1AxNmRhb0RQ?=
 =?utf-8?B?NHdPV3U0Nnk3aXJpMGtwc0FVYnQ5ak1wc3NCZGE3WWVqZUxHc1JDSWZBWVVq?=
 =?utf-8?B?Q3NtcWo2UEwyMjh4SzNUem0wVFpIZXUwZE9BeTZaU2ZVODA4Z3NqSkFJTWx0?=
 =?utf-8?B?bmNrTVVPYVZUWndOWDBnN1VrSzk1Zzg5ZHNiL0c5NkRmbFIyc3cxR2p5cnZ2?=
 =?utf-8?B?ODR6VTlpbE5INnVIOTBWN3JwMlVOOEFobFlmeXgrUWhQNGgwTWw3dnJzMG1G?=
 =?utf-8?B?aU9UUVBMaGhrUTNteFRxajBMRVJuSWNXNXJibEcwZHk0Q3BTck54Y1JJVlBt?=
 =?utf-8?B?d2F6UTRQWko3WDNpWk5MK1F1eVlwZkE5aG5xamNKdUUvSllMQ3dSU0FmYU5p?=
 =?utf-8?B?L3Z2S1dBcXNsOHRqUEsvcWJzVmRPREo0T0VQM3BhSFlqLytJUHcrUGFLeFZV?=
 =?utf-8?B?UnBHK1ViTlJEdnV2cERaT2lTZWxVRDdJY1FGc2E2LzF5TitRdmN5RkFPYWxJ?=
 =?utf-8?Q?Z6/H23YBZi5FRJTqY54rvB14V?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: e70a3419-0ff1-461e-ed03-08db91df92ea
X-MS-Exchange-CrossTenant-AuthSource: MN0PR12MB6101.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 31 Jul 2023 16:02:43.3958
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: eRIetQ8/8M8sVPKA6UiUcXRQmpEbf9HWdYfTC3qjAEEH484bO+jeLWNbY4KMnHCg7Rsw1aGYnY14M4ROqDd1Ng==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR12MB8041
X-Spam-Status: No, score=0.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,
        RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE,
        T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi,

I noticed today with 6.5-rc4 and also on 6.1.42 that I'm getting an 
error from an r8152 based dongle (Framework ethernet expansion card).

netif_napi_add_weight() called with weight 256

It seems that this message is likely introduced by
8ded532cd1cbe ("r8152: switch to netif_napi_add_weight()")

which if the card has support_2500full set will program the value to 256:

	netif_napi_add_weight(netdev, &tp->napi, r8152_poll,
			      tp->support_2500full ? 256 : 64);

It's err level from
82dc3c63c692b ("net: introduce NAPI_POLL_WEIGHT")

Why is this considered an error but the driver uses the bigger value?
Should it be downgraded to a warning?

Thanks,