Received: by 2002:a05:6358:c692:b0:131:369:b2a3 with SMTP id fe18csp4694035rwb; Mon, 31 Jul 2023 10:38:18 -0700 (PDT) X-Google-Smtp-Source: APBJJlE6MpUqSEVP/hsR1esdUPVu3NtPgEHSzaoSaSxCqFpH16Ig39v5NKicStYbKcVuSdwivpDc X-Received: by 2002:a17:902:f686:b0:1b6:bced:1dc2 with SMTP id l6-20020a170902f68600b001b6bced1dc2mr10526978plg.0.1690825097526; Mon, 31 Jul 2023 10:38:17 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1690825097; cv=none; d=google.com; s=arc-20160816; b=MLFD724IwzVQZWpXHTkgIPsGcg8diQABsk73/zN9I5YC/t6N5bj8Hyhmq20S23Y5R7 JannMZeZKqX4/HwR3AmMBnyS/P2+lFgv8qtnFSMhNvpTyNGtWe9wjrMUXpzM1GCE7Uho X7fIDk5NCtYwusHBX5q2L7EcfdWcckodplhH7eUffwPbFUmIqho1QAfToyU5N6SWPuD5 hdhfyS8dAcvNSIw5V88SR1oumZnlsy0kACLSvsUPKNbzcqTzK4rp5q/ID6HohoeNxhNA qYMdswnyjSxl0DbfBlNjC2ptVGmOHfe44n+KEEA2Hjhkhp906lGFJ3/CBUx9Evc0JKpQ kI1A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=TpC3L7N0MTHCoTxBWnvm+Sgoc+CDe3ReMyRGSpxQF7k=; fh=cTvVK1+pOlNzA3K7LkXF+ZIADLR+Mf/XNmu7a4YH0YY=; b=bxFdRODr4w9yp9VFszWrQ+0gS3k8TljSoplB2gs1LWAUTDloB3nFOoPlcLEmEXLeEg THW9CbKMm07UCTbKFgQMxXLr7VDO9cNY8sSB8h3mteqaRATQ+W2PiV6iMadAH7xox18h dkic7oD4R/fDfkc1ps6zf8Lra3JfZfb7NzIP3j9ZykRWe9QlfgsIiGr7ntdArKcW913A WQY0ESYTrl/fZgLw2SU5b+4reyGEcHS4ybC4adFKlLqKyVrYTrIc9h7/va0ItI6n8igs 9b/1jcOWPNotGaXp5cOObpBkpkffvYLlDWGiL6wVn3ka4bHlOefXbfqkU1wXIuhOFVfl uFxg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=XMStE277; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id f1-20020a170902ce8100b001bc162f3318si1531359plg.640.2023.07.31.10.38.04; Mon, 31 Jul 2023 10:38:17 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=XMStE277; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233986AbjGaRWQ (ORCPT + 99 others); Mon, 31 Jul 2023 13:22:16 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47556 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233962AbjGaRVy (ORCPT ); Mon, 31 Jul 2023 13:21:54 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F0A3E1BD6 for ; Mon, 31 Jul 2023 10:21:48 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 833CF6124B for ; Mon, 31 Jul 2023 17:21:48 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id CBBBDC433C7; Mon, 31 Jul 2023 17:21:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1690824107; bh=kiXzpQqenKMMpnBqTOhAGdvH08lsx7pYXETUBIhe2Bs=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=XMStE277hRfTz2v7aKoGI8wVqwS9crflOd0yqEEyNHDkj9xfFqxIsaZcNrrgXcJgE keq55KuTw25asvxAJabz2TP1UOaKt4Hf/o4xhtfHKQEqtNjIXmcF2dIIZBMBah/0qi PNqryFw8cATRFrkBEzQybmHhqgaxRnwjaYLklyNhhpT/cO3TSYIW+5U9cDMAVt6/aT uqG19DfuBylTGbTYI6G6nNJTbKnh2mI3cFAPXNH/MqF9K18A9A6sfSwuZf3wk4OOfB U2GLtm6QBT4Wi3z0DWoHqgngu0ABekSKbtsbyV9rQWw6kXjsIJvOOiyzILRCZSTNos BZeAKEo9aSmJA== Date: Mon, 31 Jul 2023 18:21:40 +0100 From: Mark Brown To: Brent Lu Cc: alsa-devel@alsa-project.org, Cezary Rojewski , Pierre-Louis Bossart , Liam Girdwood , Peter Ujfalusi , Bard Liao , Ranjani Sridharan , Kai Vehmanen , Jaroslav Kysela , Takashi Iwai , linux-kernel@vger.kernel.org, Ajye Huang , Yong Zhi , Terry Cheong , Uday M Bhat , Mac Chiang , "Dharageswari . R" , Kuninori Morimoto , ye xingchen , Andy Shevchenko Subject: Re: [PATCH v4 0/1] Intel: sof_rt5682: remove quirk flag Message-ID: References: <20230731103419.2536036-1-brent.lu@intel.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="cNapWE7fzt2N3lOd" Content-Disposition: inline In-Reply-To: <20230731103419.2536036-1-brent.lu@intel.com> X-Cookie: Single tasking: Just Say No. X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF, RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --cNapWE7fzt2N3lOd Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Jul 31, 2023 at 06:34:18PM +0800, Brent Lu wrote: > We add a helper function to detect amplifier number according to device i= nstance > in ACPI table so the SOF_MAX98390_TWEETER_SPEAKER_PRESENT flag and a dmi = quirk > for 4-amplifier configuration could be safely removed. >=20 > Also refactor the max_98390_hw_params() function to use an array to handl= e the > TDM parameter. >=20 > Amplifier number detection and TDM parameter are tested on two Chromebook= s. One > with 2 MAX98390 and one with 4 MAX98390 amplifier. Please don't send cover letters for single patches, if there is anything that needs saying put it in the changelog of the patch or after the --- if it's administrative stuff. This reduces mail volume and ensures that=20 any important information is recorded in the changelog rather than being lost.=20 --cNapWE7fzt2N3lOd Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmTH7aMACgkQJNaLcl1U h9CUWgf/ateymIZbZ4zSCmCF40krOpEKI545+7ZSX9VWn3zhMUVGp6EPWNwpsAZR XSEv64pC2EPySh3510ktC5cxUAOf0k4LDzvkuUbwvbJU2EMWHST9pvuXw2ShamC3 gOL3Uqk8bERAa/UfHWrFa/rqGv29bJUMMG541LMoQgRhy473tZDoFtaMCdZutJqC Jqy0ZA4+dJQ43KQ0J8qbifjuSkG+jaIxaImOfU7aqeF7UXG7igKe9h88vQkfxWsD Ym8qlE97uZHoh68W0iL+bPZ1TVVOyftIq651quI2bzbQdeestx1/S+6YjlExHlyi T4Vej0V2yyG1UGZlTGgKUgC73KSDig== =5xmf -----END PGP SIGNATURE----- --cNapWE7fzt2N3lOd--