Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 31 Jul 2023 10:43:23 -0500
From:   Jeff LaBundy <jeff@labundy.com>
To:     Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc:     linux-input@vger.kernel.org, linux-kernel@vger.kernel.org,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Subject: Re: [PATCH 15/22] Input: iqs5xx - use device core to create
 driver-specific device attributes
Message-ID: <ZMfWm6H8IKiyTh0R@nixie71>
References: <20230729005133.1095051-1-dmitry.torokhov@gmail.com>
 <20230729005133.1095051-15-dmitry.torokhov@gmail.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230729005133.1095051-15-dmitry.torokhov@gmail.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?kxZeVdr1PBqhVPrTX6mxID4bDr6jUvBz/fxGd8qMYCNr235iBeLzQABtfhcL?=
 =?us-ascii?Q?fJ3U4PNBhl3jSjnUXideQ66LZ1nyy2Qg7pMlCINfnEcM+ge5Zkwun7S88SWL?=
 =?us-ascii?Q?rjXoUJhmVLQXdferXKN7YAyepCnIe3ITH2QV6hujTbwtOgj4yhb7chaapw6V?=
 =?us-ascii?Q?sSmYT9qJjKe2TBsPUy2gpla6MFxfvZ2Rr8hjVbxhXXpPsqd0QUC+tptyRFMs?=
 =?us-ascii?Q?Q1G8AiXs2O0IH3C6hsoOFVsubKNAipcZ3QLOcL9wjYV7qRhBPuEhwdwXWkXW?=
 =?us-ascii?Q?mVB4nbQOC2sdbqtAXS8nn/dg+nCSXWSFsyzffGJr+CWmYQHP2lvnhc6t+rT+?=
 =?us-ascii?Q?xiyMVmi9aQbVAI00yWRXk3OeA/2JfEl8lBjGYCULeJ/gn56TWjKktWvS2VqZ?=
 =?us-ascii?Q?aa94L45xZ7H4NXkNpMysSL/lh27i6FADh1NVIZw3UeoNsaWf/QHcQwIraHus?=
 =?us-ascii?Q?c44Csc9y15Il/+SvSTDfgYOT/OeeUonHRXFBMKNHAqv9EWr46nCjNqOcMDb7?=
 =?us-ascii?Q?sWIAYN9uh/8P9EHEpRvxpv0h8akipsxyAoHlBEtymwRa76oUlQxixNv2Qzec?=
 =?us-ascii?Q?nYodhn7dbIA3gTBhQf6K930L2h1zH8xIJQdLhsAznQTXgd6QC/L2yKoe6JKt?=
 =?us-ascii?Q?+6kLi4P8pnv1MB8qBj+BYMIDVM6m0rxJEcqnyZbvdV3QWtrRKuqcPDw6DD2r?=
 =?us-ascii?Q?LSQrFRUjfWlzDaB5xOocF7dVnzn6m6Esy8/LrUoFjXP5aChh15SFRrvQDdPA?=
 =?us-ascii?Q?FyI1o8dj33Qh7DgfJSqYOlgLhSfkulLmmsM2oXfKy75miFHVdg2Miwj+MZm6?=
 =?us-ascii?Q?ajIeZEEbonIFuQdu0PAG8dxBtuvrJ2u92vswhuZW2QRo96/UFuw/Y9tjOUG2?=
 =?us-ascii?Q?Yas5cDtXPbzTzmh9czVMYyaiRoZlXPpQ6C6CjXGv+7mzIlbOO8oAa0aY3QvB?=
 =?us-ascii?Q?BAkBeKgFfPTFsDMT+t/Xh1U8NyMl2DsD4vUGvXfTrV4F48rGQ1lyy51FIdvC?=
 =?us-ascii?Q?u2YUkSX2rFmJXXgD+Xp3YUgxX07/7Bgh+8TOUe5JQ5hTPnn/KgnjOKKacCxZ?=
 =?us-ascii?Q?A3fosm9GWGV00W5VamSi3IHN6ew9egp+XeM7TkG1yD1ldA6d4uSmqCT4I1UX?=
 =?us-ascii?Q?hse/1Ns2y75YWW73z1mhamM1ountDaLcyyLG3x3jEWtDZooUJbZvSfz/fd+t?=
 =?us-ascii?Q?aXer/9O1NRcZUBpo2qouzdi6766DI/LCWUc/H080fDj2W2qZRcr0o+ThMOfo?=
 =?us-ascii?Q?85cvTE/0e+S8/5RpJA+QkD47+gObfTaq83vkzxDEYjTwTsT5W7sjG4OCoRXC?=
 =?us-ascii?Q?Nj5AiEBBmdwVaMtGFuUMDP2VOxJMOT60Ns0fZS3JXKRCFpQTvBnaAHmbyb78?=
 =?us-ascii?Q?5uq6H/+z5R6Dk1dE0QlOSKrkEMzctUQub27+rajDjMP86l7aVE3PnEUOxTG3?=
 =?us-ascii?Q?J3JgqBXFxUnEW/KbRqOtb3Isi2CvGN4OoyjmV3EdsEwbQOq3AfkjdlLYBbaC?=
 =?us-ascii?Q?Uv2oXoFALUZPKzHrii+kOpBEe7DDvWbkwEOTh4IPXOYoyw9V/yI58guZIKn5?=
 =?us-ascii?Q?8ZTbwLit0V364aQA7OZtkL3YdXvhnx0NeA+iBBG7?=
X-OriginatorOrg: labundy.com
X-MS-Exchange-CrossTenant-Network-Message-Id: e5ed5e75-c6aa-4e24-ed6a-08db91dce11d
X-MS-Exchange-CrossTenant-AuthSource: SN4PR0801MB3774.namprd08.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 31 Jul 2023 15:43:26.0427
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 00b69d09-acab-4585-aca7-8fb7c6323e6f
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: +VU2md2LJgfvbr6AEjtu18iaPH+tIBg26eDgE2wCNTpj1Jrg3J0iTknQRQ3pX9bULBo+YjFIkUFeKt6Bt9hALg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH0PR08MB6843
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,RCVD_IN_DNSWL_BLOCKED,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,
        SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no
        version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, Jul 28, 2023 at 05:51:24PM -0700, Dmitry Torokhov wrote:
> Instead of creating driver-specific device attributes with
> devm_device_add_group() have device core do this by setting up dev_groups
> pointer in the driver structure.
> 
> Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>

Reviewed-by: Jeff LaBundy <jeff@labundy.com>

> ---
>  drivers/input/touchscreen/iqs5xx.c | 10 +++-------
>  1 file changed, 3 insertions(+), 7 deletions(-)
> 
> diff --git a/drivers/input/touchscreen/iqs5xx.c b/drivers/input/touchscreen/iqs5xx.c
> index b4768b66eb10..a3f4fb85bee5 100644
> --- a/drivers/input/touchscreen/iqs5xx.c
> +++ b/drivers/input/touchscreen/iqs5xx.c
> @@ -974,10 +974,11 @@ static umode_t iqs5xx_attr_is_visible(struct kobject *kobj,
>  	return attr->mode;
>  }
>  
> -static const struct attribute_group iqs5xx_attr_group = {
> +static const struct attribute_group iqs5xx_group = {
>  	.is_visible = iqs5xx_attr_is_visible,
>  	.attrs = iqs5xx_attrs,
>  };
> +__ATTRIBUTE_GROUPS(iqs5xx);
>  
>  static int iqs5xx_suspend(struct device *dev)
>  {
> @@ -1053,12 +1054,6 @@ static int iqs5xx_probe(struct i2c_client *client)
>  		return error;
>  	}
>  
> -	error = devm_device_add_group(&client->dev, &iqs5xx_attr_group);
> -	if (error) {
> -		dev_err(&client->dev, "Failed to add attributes: %d\n", error);
> -		return error;
> -	}
> -
>  	if (iqs5xx->input) {
>  		error = input_register_device(iqs5xx->input);
>  		if (error)
> @@ -1089,6 +1084,7 @@ MODULE_DEVICE_TABLE(of, iqs5xx_of_match);
>  static struct i2c_driver iqs5xx_i2c_driver = {
>  	.driver = {
>  		.name		= "iqs5xx",
> +		.dev_groups	= iqs5xx_groups,
>  		.of_match_table	= iqs5xx_of_match,
>  		.pm		= pm_sleep_ptr(&iqs5xx_pm),
>  	},
> -- 
> 2.41.0.487.g6d72f3e995-goog
>