Received: by 2002:a05:6358:c692:b0:131:369:b2a3 with SMTP id fe18csp4733486rwb; Mon, 31 Jul 2023 11:15:30 -0700 (PDT) X-Google-Smtp-Source: APBJJlGs+RkGAchRtuo1GQjz76E9JkjyH6il6mX8lEQVGOgSPWBETbE6MjOIV974jxEqkTqc5gfv X-Received: by 2002:a05:6a21:7885:b0:13d:1f99:42f6 with SMTP id bf5-20020a056a21788500b0013d1f9942f6mr8907314pzc.6.1690827330269; Mon, 31 Jul 2023 11:15:30 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1690827330; cv=none; d=google.com; s=arc-20160816; b=Nj3+OGosRTjeQVL5BaMWHV5er5nS3G3EaHDT8dDm7CEVOvt036W5k645ndJ7qURKm1 oqUirKHTTafdsg3vtFSE71f3b1v3wRxkn8W7cZXhRpG1EjmUubtPMLTwdxRB5reQLc/4 +/pHGUB27Htp3qUvbsyT0sjds8KKnnP8XUxYSiNmAeRKah+lGecw+NQCfiZFYxG187gB q7GBMhx+wjuLX4n2ij0nQhuuieVkaHEhdOmR/Y4Db6ywr+MsohipXbwGjsodbGCPuZcR 6UP1uRK6D4mPXck/7PalRBBWz2i9EHH65YYmIfKWOKjfZ2la6ByKSg11KiKA5mjoyMg/ khIA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:message-id:date:references :in-reply-to:subject:cc:to:dkim-signature:dkim-signature:from; bh=NVJcIMq+A16+IcB9b23/dJfzVwN2i3jSPnGuLESWXwU=; fh=xxHYUAYzGbxZHZHiTvUbuIcuHusI+eZA6qmV5uBhRJ0=; b=SqOiIMUvBKd0EtNBw6rLxCuNBRR2A/bF5KjVLQBFSibI1/H/xZkYtCK4ONSTsyWOig 4rMMFY6ETWxLsg0aHXwshUnNxEWpU5A7twniNE8gRror4ZX/Mtld1vVJSCeV9/4Dfu8O m5EXJeIgc7Iglm5K6SuvEdHyVcSrlNq2cD4bJaj9gzL5cDw+RWdrfXYsEoedA6sHHUbB Bh/CNVU29ebwD6p2oJdrba7MMTHrK6LCKdT0WyuEgk/85upFO8CJGEB9+WutDeUb5VNa SEdo+Um49fO3KuQw8pozDqteFxaf8QjcTCPTeXxI0xJhCL+F0BFRx9sYbYsqRMbzv1hD grmg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linutronix.de header.s=2020 header.b=Eo+GdN8K; dkim=neutral (no key) header.i=@linutronix.de header.s=2020e; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=linutronix.de Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id cb11-20020a056a00430b00b00682909b9671si56034pfb.75.2023.07.31.11.15.18; Mon, 31 Jul 2023 11:15:30 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linutronix.de header.s=2020 header.b=Eo+GdN8K; dkim=neutral (no key) header.i=@linutronix.de header.s=2020e; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=linutronix.de Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233083AbjGaRQD (ORCPT + 99 others); Mon, 31 Jul 2023 13:16:03 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41324 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232663AbjGaRPP (ORCPT ); Mon, 31 Jul 2023 13:15:15 -0400 Received: from galois.linutronix.de (Galois.linutronix.de [IPv6:2a0a:51c0:0:12e:550::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D5AF1185; Mon, 31 Jul 2023 10:12:48 -0700 (PDT) From: Thomas Gleixner DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1690823567; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=NVJcIMq+A16+IcB9b23/dJfzVwN2i3jSPnGuLESWXwU=; b=Eo+GdN8K0pBmO612+PieVaC3ckEtUeUWiNBdHnP9zA+76wue7l0DTxUuNENb6j0Y62dGmB zlROcFdnMNMoN5KF50nw9Zens+gzszFOYX2KrLa9AlpP6pagTvzj+kjJreWRZCd4S+4VFt W60Z1///m5n2Xm2EisbxjSr9+SANi9NNLZ11wGkaeyB0F+Gsjr61iISJysYk2U5Znbw2M/ qZ6ogZwhkx+rXUE5tOqiWJCgdy85NQsGUljrJPkGXDzlRqhdr4RnbH1Auycs6Bm0cFm1rY P7fyMrsSvnisqr5BGpEjx4pCOFdrF2Vml2PPeMlSbmuIVI5v28Izu9vGPHV/SQ== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1690823567; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=NVJcIMq+A16+IcB9b23/dJfzVwN2i3jSPnGuLESWXwU=; b=hziJ/HSUvoaES2uwBGC27GHIPrlflFgMtjtsRDlBaxjsKM4GLmXBM9mKhYBhkhOW3G1CRF 7A6QmLUgJhzZz5Cg== To: Peter Zijlstra , axboe@kernel.dk Cc: linux-kernel@vger.kernel.org, peterz@infradead.org, mingo@redhat.com, dvhart@infradead.org, dave@stgolabs.net, andrealmeid@igalia.com, Andrew Morton , urezki@gmail.com, hch@infradead.org, lstoakes@gmail.com, Arnd Bergmann , linux-api@vger.kernel.org, linux-mm@kvack.org, linux-arch@vger.kernel.org, malteskarupke@web.de Subject: Re: [PATCH v1 04/14] futex: Validate futex value against futex size In-Reply-To: <20230721105743.954526690@infradead.org> References: <20230721102237.268073801@infradead.org> <20230721105743.954526690@infradead.org> Date: Mon, 31 Jul 2023 19:12:46 +0200 Message-ID: <87y1iwm2cx.ffs@tglx> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_BLOCKED, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jul 21 2023 at 12:22, Peter Zijlstra wrote: > +static inline bool futex_validate_input(unsigned int flags, u64 val) > +{ > + int bits = 8 * futex_size(flags); > + if (bits < 64 && (val >> bits)) New line between declaration and code. > + return false; > + return true; > +} Other than that:: Reviewed-by: Thomas Gleixner