Received: by 2002:a05:6358:c692:b0:131:369:b2a3 with SMTP id fe18csp4766817rwb; Mon, 31 Jul 2023 11:51:45 -0700 (PDT) X-Google-Smtp-Source: APBJJlEsEZ1x4k1BJsyTCy74PNEj1EQCh+hXZd/AYFeBXAUHJZSkXw9QB5zJPNI66Mz0MNoa5SSM X-Received: by 2002:a05:6a20:4295:b0:13a:bed2:948b with SMTP id o21-20020a056a20429500b0013abed2948bmr11129887pzj.43.1690829504840; Mon, 31 Jul 2023 11:51:44 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1690829504; cv=none; d=google.com; s=arc-20160816; b=PpZHJkOcgTf+kjOUnoey9eZWVYfMb2J9zcEj5kfj4AViVybhH1F0Ud1t6/lPcg4Z8I 4EpIRwb5z5i8a+2nK9C/bxRQcamowmtv5LpvnTLKAzwV7yP1K11SPpF4qU/SVX0RAbAi 6zmyFgFAupavvqUWWnvAX2akYPiMG12OtswLHs8WMwQXTVvUEC4KGen8hRYwEGYYpyYo CumV7gZ/m/e2KDyThHp1K0OhI0HTs3Bq7BO09eDk4b+8wNgyKzWY3EuPjXqUaDKuerSI /1iMgIeja3XKAEn1n/JurfnNcYzY7vSybHog5JAb+Aoy1icHwrxr9FztWOp27frY4NP/ 0HFg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:message-id:date:references :in-reply-to:subject:cc:to:dkim-signature:dkim-signature:from; bh=3WycB7deeH4N77XCxYSpDoyHgigBfOsfA/l1DUt3Iq4=; fh=xxHYUAYzGbxZHZHiTvUbuIcuHusI+eZA6qmV5uBhRJ0=; b=qTexNU8BxL8LYQDNc1hUyBQyULq97qfJjFbJtYk50/Xbbw12DTzMF/D0EEeExAYPco mV7heVXA9+mKL/c6Q2HEgK7DJ3Qg/jrAsQKTWKt3VF9I5hwc3XeDR1x9TDoBkTqDXfIr LE+GMFKsRpy3KQXY2jvWxFyjiiDkm/6GDA1x9FKC9or6PWD3puqSyibFDTVMTJYg46CQ s1PpRT8hfcgoFubFtTwE1RnjUKuBQH5J3kgmRQd1GeabVyB/vtOsjRfu3GJsp3g9/c1A aQ+CKkOr+Khs9P7hgvzMhY59CA3SFAHE6SCgWu7AhiMUDwkHFdExGNTjNvzV/k8JbhTv na8Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linutronix.de header.s=2020 header.b=CbnDJQkP; dkim=neutral (no key) header.i=@linutronix.de; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=linutronix.de Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id w6-20020a63c106000000b005503f25aac2si375031pgf.241.2023.07.31.11.51.32; Mon, 31 Jul 2023 11:51:44 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linutronix.de header.s=2020 header.b=CbnDJQkP; dkim=neutral (no key) header.i=@linutronix.de; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=linutronix.de Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233752AbjGaRUl (ORCPT + 99 others); Mon, 31 Jul 2023 13:20:41 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44538 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233386AbjGaRU1 (ORCPT ); Mon, 31 Jul 2023 13:20:27 -0400 Received: from galois.linutronix.de (Galois.linutronix.de [193.142.43.55]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0C1C4188; Mon, 31 Jul 2023 10:19:19 -0700 (PDT) From: Thomas Gleixner DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1690823957; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=3WycB7deeH4N77XCxYSpDoyHgigBfOsfA/l1DUt3Iq4=; b=CbnDJQkP/pRhO94W3xehr4PIUumrBKh2h6k85o7yyZ5qis1q4WPoliddjQPJG5g8/N23Zr y6MSYqVeDkn8CB8FAlMKJUTzjaXBWYqhYsqodZDZ1bn7pZ5bzvfUbjsfUt4Iy6HUXcbG8/ CJx34EEd8ZpGhFg4wUmRhysaNTIK/4k+jzbmC99MPG7tdPZVWnoi0rIQph+XDhfkNODwLb rGuuHIQsV9/BiPLQbmjrHgecHwKXe05bD/Qfxg6qGVZk4g5x/6aiaisSfJim1PwIT8zXF8 MzS9KyZPGMfHmVODWj+WSagf4wuzhAXh2kZy8SZFMO/FcsPIdhDRRJWQBfvRjg== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1690823957; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=3WycB7deeH4N77XCxYSpDoyHgigBfOsfA/l1DUt3Iq4=; b=9I5o68k9/KxZ19MCx1ZzRCsGVutxiHRYG6O9NIimZJuwyP42OYwcF9OKIaljbBRwdxSFgy /pBIstsXYJxooQAw== To: Peter Zijlstra , axboe@kernel.dk Cc: linux-kernel@vger.kernel.org, peterz@infradead.org, mingo@redhat.com, dvhart@infradead.org, dave@stgolabs.net, andrealmeid@igalia.com, Andrew Morton , urezki@gmail.com, hch@infradead.org, lstoakes@gmail.com, Arnd Bergmann , linux-api@vger.kernel.org, linux-mm@kvack.org, linux-arch@vger.kernel.org, malteskarupke@web.de Subject: Re: [PATCH v1 09/14] futex: Add sys_futex_requeue() In-Reply-To: <20230721105744.298661259@infradead.org> References: <20230721102237.268073801@infradead.org> <20230721105744.298661259@infradead.org> Date: Mon, 31 Jul 2023 19:19:17 +0200 Message-ID: <87sf94m222.ffs@tglx> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jul 21 2023 at 12:22, Peter Zijlstra wrote: > +/* > + * sys_futex_requeue - Requeue a waiter from one futex to another > + * @waiters: array describing the source and destination futex > + * @flags: unused > + * @nr_wake: number of futexes to wake > + * @nr_requeue: number of futexes to requeue > + * > + * Identical to the traditional FUTEX_CMP_REQUEUE op, except it is part of the > + * futex2 family of calls. > + */ > + > +SYSCALL_DEFINE4(futex_requeue, > + struct futex_waitv __user *, waiters, > + unsigned int, flags, > + int, nr_wake, > + int, nr_requeue) > +{ > + struct futex_vector futexes[2]; > + u32 cmpval; So this is explictely u32. I'm completely confused vs. the 64 bit futex size variant enablement earlier in the series by now.