Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <e1aef4d4-b6fb-46ca-f11b-08b3e5eea27d@intel.com>
Date:   Mon, 31 Jul 2023 20:27:17 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.13.0
Subject: Re: ksys_sync_helper
To:     Christoph Hellwig <hch@infradead.org>
CC:     Christian Brauner <christian@brauner.io>,
        Andrey Grodzovsky <andrey.grodzovsky@amd.com>,
        <linux-kernel@vger.kernel.org>, <linux-fsdevel@vger.kernel.org>,
        Alex Deucher <alexander.deucher@amd.com>,
        Hawking Zhang <Hawking.Zhang@amd.com>,
        Harry Pan <harry.pan@intel.com>, <linux-pm@vger.kernel.org>
References: <ZMdgxYPPRYFipu1e@infradead.org>
Content-Language: en-US
From:   "Wysocki, Rafael J" <rafael.j.wysocki@intel.com>
In-Reply-To: <ZMdgxYPPRYFipu1e@infradead.org>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?QlVQQW1waTE5OFNOVlpHMldhTEh1dk01SndOVlY3R2Mva3RPZXpTVW9GcXM4?=
 =?utf-8?B?NzJCc0I1RHk0ZXlhT0ZKMVhSSGplQjdxeXVyQVducXhRK0pJeDEyT0o1a1RR?=
 =?utf-8?B?amU3blBrdkVKd2tkdkxTblhYRFhpa2tIeGI0YXVoTXBERmF1NXZtLzUwV29C?=
 =?utf-8?B?ZW9BVDFzRHBsaXJ5alRKbmk0ZTVRZXFRQU5naEZJUnVhMFZCNW1DSnJRWGRK?=
 =?utf-8?B?dTlJK3JYZWkvdDg3Ui91bDA4YUdXU1dkRFBwRUViNDJPSnlpK1k2NTdBd3BO?=
 =?utf-8?B?NUxRc09mMHJPZTYyZDB3QWNlMDNqelBlVDBBdEpoUC9nWDlsNUF2QzFKZEMw?=
 =?utf-8?B?eEJ5SHhmdm8vaGcwRmdiVWVLVXRSZ3lmZ0t4ZmM1M1ZRaktISmpoVm9pL2Yv?=
 =?utf-8?B?dHJJb1Y2eDBXb2FXdGNoNXJKaUVkbThiQ3dEZDNSU0ZGUGVVSXo1MzhTU1Mz?=
 =?utf-8?B?SlI4eENsU0Y0ZVlGU2wzeUZhZk5sQmNGdmhIdnVJSDFEbm5JcFdRbjVpWlc0?=
 =?utf-8?B?cTkvcWFqZ1VvL2NmS2lZQmh6SUZlWFFrdUpIeFhGaVBqTC9GemFacHhleHZp?=
 =?utf-8?B?R0ViNkROQ2RtcU9GTy8xeFBNRy9XSjQ3ZXlLVUtQdVB2ZDZMYXBtcnFvT3No?=
 =?utf-8?B?ejlxVVA1UFlTQmRCcjYreVZqNEdhdDJFTlRSdkZYZlhzVXd4dURVY3YwM0c1?=
 =?utf-8?B?Q3hhNW1KcUswUnpzVGNsb1RRZUlrUURnVmxtaUE4cTBOUStWNlcrbVI0b0hH?=
 =?utf-8?B?M2ZnODJtL05paDR2NFp4TE5rbHJURzEvVFZBaVI1cnlMakFwemNjdzZpUzNN?=
 =?utf-8?B?b0lFQlJhT3VxbHg3aUFSNjcvMUlNNXB5ZkxiOXlaYk5rOWs4Mkp4eXdENXFz?=
 =?utf-8?B?aUhQRm1TSlhRekpWdXRHWHJuejRPUkhsc1d4UFFzVDM5UnZuTUJKdFAxdVcz?=
 =?utf-8?B?VkZ4M0FXTWxSWHJaVGFGaCt1UUF1M0RvMjdZck5BRTVoSDQxbkdpMWwrWURl?=
 =?utf-8?B?ek1RVzUyOHlvb2cyYVNMN0VIcVo0Q0VEYkhKN0lObGVpL1dIMk1TWW1ySGcz?=
 =?utf-8?B?RGpJSFpTZm9EaU1pS1NlMUthQUUveXBoM2NaZml5eG90SjdLNndua0xhMlI5?=
 =?utf-8?B?UThqYWoyaFFsclFJVGNoL3JSdUt2dHNPd2RpVTlLTjFCTDJrL0dIbzIxQWhI?=
 =?utf-8?B?VUNkdWN0elAyeFBNWldIK1lqVkN4U01CMGREV2drRDdOTlhNdmhSTWM3ZmQy?=
 =?utf-8?B?T1pqNHo4OEt5ZEs0TWYxQkQ0bk5ybkl3K0dNMzBRWms1cmloajA4WHBJQW0r?=
 =?utf-8?B?NWZudVhscnUyMkdiR1RnQW9FUGpTR2lJcDR3TW5yU21uRnJUNytsODduOW1u?=
 =?utf-8?B?YUtTTkJseE9uYmlQdkJpbGpoWkVxQkxPWFVYaEt1L0crd2Fld0l5dzhPeHVu?=
 =?utf-8?B?eDZMSTArekxLVEt2WklORi9SNUwybEM5aWswY0VDN1lQWW1GVWxlNXlqbDNX?=
 =?utf-8?B?SVNtZytQWW1jRkk5UklYbzF2THBTZkpEVnFRVFRlVHhQUmxmRjlmdnluUHRx?=
 =?utf-8?B?WStVN1dXRmJyU2RFa0E5TXJIdEhBNGdiUGJKbXpSWno4V2xjblU1MFd4em4x?=
 =?utf-8?B?WWNhQko5TGZGS0RkMDU5UXh2NmJMYnNsdXcwVlNFYjR4RFZneDlheVNQTVZJ?=
 =?utf-8?B?UUlCaloyMW9vT2s5M00vK09UWGZ5Ym5PeGlWTVhzVGRjZXlsZUlLOVRHdWhD?=
 =?utf-8?B?cHBJWGs5aDFEOEtVLy9wS1RmMEZxeEhkdTEyMUdJZkNBbjcveE51OVNNWWFR?=
 =?utf-8?B?azJVd0RVS1VCdnZyeGp0NFd2aVZ4QVRFN2VkTnZQV1lwU2Y3ZVJ1aStvRjNz?=
 =?utf-8?B?aXJYemplT2hmMjBQL2FJMEpjaUoyWWFZZUJLWC9MN3UrOUxWWEZUT3p6YTlW?=
 =?utf-8?B?UTVPYVNQM1FZcm9mbUZ6NzFvTVliM2RsMkxvWTBOTWs4RWZjblZyZmRUMnY2?=
 =?utf-8?B?MGRxTk5ZL1BlMmpSaDZEWmJDREpsWGttY0ZnT3NhZHZuTW9iZmJkRlFqNE5V?=
 =?utf-8?B?NzhkY2t4cEZzK2NFMTJrcEc5M2J2d3E5OEw1SFdJSHVUQTVwR0VuRmFXTS9N?=
 =?utf-8?B?VkdBL0Q1dmNCZVJqdDhIWTBWVmMxeWl2ODJPYU9MazlsMTdxdkNYRjZ0bXp3?=
 =?utf-8?B?UGc9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 89ca3025-45ad-447d-acf8-08db91f3c955
X-MS-Exchange-CrossTenant-AuthSource: MW5PR11MB5810.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 31 Jul 2023 18:27:24.6833
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: TouV7YYJ+L6Tvb5pTrKOaKz5m9slp7m0ZSkukQYPQht0QqUUWCN1gspQQ2OtQuePijxqjdTtHsfmqL+wxeiiDQw6zEVS2V/JlypU/9GU3Xc=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN6PR11MB8146
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.5 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,
        RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 7/31/2023 9:20 AM, Christoph Hellwig wrote:
> Guys,
>
> why did b5dee3130bb4014 add a magic export for sync functionality
> that wrapps VFS code in a weird way, and then exports it (without
> even adding a user in that commit)?   This kind of functionality
> needs to be exported from the VFS, and only with ACKs?

OK, I'll remember about this.


> With this
> and commit d5ea093eebf022e now we end up with a random driver (amdgpu)
> syncing all file systems for absolutely no good reason.

Sorry about that.

The problematic commit should still revert more or less cleanly, so 
please do that if that's what you need.