Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <673bc252-2b34-6ef9-1765-9c7cac1e8658@amd.com>
Date:   Mon, 31 Jul 2023 13:23:47 -0500
User-Agent: Mozilla Thunderbird
Subject: Re: Error 'netif_napi_add_weight() called with weight 256'
Content-Language: en-US
To:     Jakub Kicinski <kuba@kernel.org>, hayeswang@realtek.com
Cc:     edumazet@google.com, LKML <linux-kernel@vger.kernel.org>,
        netdev@vger.kernel.org, davem@davemloft.net,
        linux-usb@vger.kernel.org, pabeni@redhat.com,
        Paul Menzel <pmenzel@molgen.mpg.de>
References: <0bfd445a-81f7-f702-08b0-bd5a72095e49@amd.com>
 <20230731111330.5211e637@kernel.org>
From:   "Limonciello, Mario" <mario.limonciello@amd.com>
In-Reply-To: <20230731111330.5211e637@kernel.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?akk0TGlzeVdyTE5LL0lsNWdJMjdxSUdFS2NUNUJNVytpNzYwSGJYVHRJRGVQ?=
 =?utf-8?B?RVFuQitkcmRIN3VQdE95VTVZRkxDRWlkcDZySkoyVXVFbDBQZHgxTmlvRG1x?=
 =?utf-8?B?RHpLeTcxSVFQZFlJYWM0SjNGT3ZIQUxidldudmtyWVRCbkpSTml3bi9GeUpT?=
 =?utf-8?B?bFlQamxFdzVaRStnWXRJSGJhVkYrQTlVUWpNSENVdzlvcUp1NFRScGd6b2Qr?=
 =?utf-8?B?YjZod0xmM25YT0dtanpDTE85MEg0UytxM05vaTU5Uzh5YmFNR2JGUk5lRnpp?=
 =?utf-8?B?Vyt5Y08xc2lMdGJGckc4ZUErTzlXeU9RWk1mWlZFSGwrOU93N0h1cE1XZ1pV?=
 =?utf-8?B?NHlLa3pmQXJYNzc0bHFLZC9YTU5pOUt1NDRhOEFXSVV4ckpVVVJLTVlaN05j?=
 =?utf-8?B?MGJpL0xOL3JaenZRTjJpYjFPYkxtVitSWnpCV2dPTVpSbmVtR1lpZDJQY284?=
 =?utf-8?B?elBnRG1Mc2VTWHNvQjRzMkVKMjNUemQ0RzRhMCtWRkhlVXN4T0owcTBLekMv?=
 =?utf-8?B?b2NLNmdXREw3dzNqdWlHVE9wbENtQUNKajB6bFFnQXIwemRDUnA1TlVkaFdZ?=
 =?utf-8?B?T1RzYjU5UTNDZy9MMWVJT2dPaGZTbkkvcGd3L1RQdy95Mmw1R29VeVJXMVE3?=
 =?utf-8?B?a2JUK01oUkVlZXgzUzhVZDd2RU1hSHZ3WUVnTWxJNjIwdURzeG1mZC96bDFI?=
 =?utf-8?B?bkRad1V2a0FDWlRYaGRyazhTZDA2STRNay9zaHA5SndKTjFUSHFvdmVrQU5J?=
 =?utf-8?B?MTZvbEVrcTVPTHZ5TDFpNzBVbmJvMmsySFdxQWxmbE5rNnZFZWxUUVZxck5w?=
 =?utf-8?B?dFBrMVN1TEpNY2Ntb2xQZmlxUTNzeUdMU2NJclI1WisyMTdpVmJEQ0tPMlBI?=
 =?utf-8?B?SEI2aVNtb0t4SC8rSXoyQkRhdGFpbnFDejJHT3JGRzlnTDNZRnU1SG0wbGtx?=
 =?utf-8?B?bGZuSUNtUXJGRDIva3ppNlZrTjdzWFA4eU1JSFhvWkNCTmpweStaZGs4Zkx6?=
 =?utf-8?B?eEZYWEtJZzcyT00yaWVMYWFqVmI5aGRFRmI3WEhyMXBhRkM2QVFrQXdqZmRy?=
 =?utf-8?B?NkRVdHd5S1hIa1BkN0RjdlZwRjFZSWxMWXhoZkJKZzVCOVZIRWlRMi94RDdp?=
 =?utf-8?B?SnFyNjlIZy9YOWpLbk41TDRYZGp4bURvTGFuMjdqSW5HZjE1ZmZpRjdQYWc3?=
 =?utf-8?B?SmYvMUl5L0tWSUhJWWtnbnFNODd5SXZLYVp2c3RGM1ZraHJIWGF2NFZUdjZi?=
 =?utf-8?B?YW1yalNJUlNxbEtyYURHUXVZZEYvckt5Q3ZuRmlhc0pPUUQ1cmIyeG9adEFy?=
 =?utf-8?B?MzdMZHRnKzNZNFQ4ZStXejNnSWlhdzJrTGpLZGJNUnJseHJrMDhjb0VwaFQ5?=
 =?utf-8?B?TjVOejNvRWJjMkFLREtZZ1d4Z1krUG1pZmJ3eitVNXErZGVXSXc1eEhkYThN?=
 =?utf-8?B?Q3ZHYjh2SHNKSGphRDdzRFVmeG9yVEZVNy9lUVB1OFl3My9jR3kyYjBwQUlX?=
 =?utf-8?B?QUdQQVM1eERaQTRrQVVBRHlrMjRhdVRzeGptMFFRTGFPcE81bllicjRlbjJy?=
 =?utf-8?B?cGxyS1ZLZ1lPTWlmblFTRi9XM2tXZVVkVUpINFR0UnE1cXo3UGNxcUlaanFY?=
 =?utf-8?B?Y0FyYm5RRlVUeXpER08yTk5jUTRxS2w0NWF4VmhXS0VHRVZET3ZZa1FDRkZI?=
 =?utf-8?B?RGpuTFNaOXVHK2cvMmkxazZXakd3UnhzRlpSWkhkSE54K2NGZ2lyd3VoeGM2?=
 =?utf-8?B?dmhxMVRjRndsU0hIUzQ0eUs5dUhqTUVIMXRqeDVFRzdxMFZyN2RsbEJuTFlK?=
 =?utf-8?B?Z0VCajhJS3htMmltTXRKbmZTSVhwOFpLYURCckdkc3R3cXNyNUxBbkFlamFK?=
 =?utf-8?B?VUlqMmtiLysraXdCVmJ3RWpEeVhzQlhHbmJmUjFPNFlMUkhiNm81K1dIRVln?=
 =?utf-8?B?U2t4N3hBdnBnVDZiK0RtajgySkdub0Y3ZmJJazY2VFIzc1J6Ry91RjN0dGlk?=
 =?utf-8?B?R2R4YjlmTFJLMjRZeVhPaUk2b29nMS9CQysyQWRLU3MzZU5pUS80RmRRUXYx?=
 =?utf-8?B?Rkp0cWF6MnlLaG12OGNGWkhtaks5WVVTdnM4M3kvTjVtRmd5TE9BNzlyU0Rh?=
 =?utf-8?Q?IVy6JzBLLMA+e4BJhFvBZUhij?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: efd69008-f867-410e-ac75-08db91f3498f
X-MS-Exchange-CrossTenant-AuthSource: MN0PR12MB6101.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 31 Jul 2023 18:23:50.1959
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: VzgzOg1l67PdX/HpNY5ovA6vqz/sP1YDJZ6RG6perJcN9lHRP+5qchoGDfbfJ341vAqVSK+HUgXpOj3I2YIiOA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN7PR12MB7936
X-Spam-Status: No, score=0.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,
        RCVD_IN_DNSWL_BLOCKED,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE,
        T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 7/31/2023 1:13 PM, Jakub Kicinski wrote:
> On Mon, 31 Jul 2023 11:02:40 -0500 Limonciello, Mario wrote:
>> Hi,
>>
>> I noticed today with 6.5-rc4 and also on 6.1.42 that I'm getting an
>> error from an r8152 based dongle (Framework ethernet expansion card).
>>
>> netif_napi_add_weight() called with weight 256
>>
>> It seems that this message is likely introduced by
>> 8ded532cd1cbe ("r8152: switch to netif_napi_add_weight()")
>>
>> which if the card has support_2500full set will program the value to 256:
>>
>> 	netif_napi_add_weight(netdev, &tp->napi, r8152_poll,
>> 			      tp->support_2500full ? 256 : 64);
>>
>> It's err level from
>> 82dc3c63c692b ("net: introduce NAPI_POLL_WEIGHT")
>>
>> Why is this considered an error but the driver uses the bigger value?
>> Should it be downgraded to a warning?
> 
> Could you double check that the warning wasn't there before? The code
> added by commit 195aae321c82 ("r8152: support new chips") in 5.13 looks
> very much equivalent.

Yeah; looking through the history I agree it was probably was there from 
the beginning of being introduced.

6.1 is the earliest kernel that is usable with this laptop (for other 
reasons).

> The custom weight is probably due to a misunderstanding. We have 200G
> adapters using the standard weight of 64, IDK why 2.5G adapter would
> need anything special.

Perhaps Hayes Wang can comment on this (as the author of 195aae321c82).