Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <1ff19823-beae-3e39-b3b8-2d8e7c94775f@intel.com>
Date:   Mon, 31 Jul 2023 10:24:32 -0700
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Firefox/102.0 Thunderbird/102.13.0
Subject: Re: [net-next PATCH V2 2/2] octeontx2-af: TC flower offload support
 for inner VLAN
Content-Language: en-US
To:     Suman Ghosh <sumang@marvell.com>, <sgoutham@marvell.com>,
        <gakula@marvell.com>, <sbhatta@marvell.com>, <hkelam@marvell.com>,
        <davem@davemloft.net>, <edumazet@google.com>, <kuba@kernel.org>,
        <pabeni@redhat.com>, <netdev@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>, <lcherian@marvell.com>,
        <jerinj@marvell.com>, <simon.horman@corigine.com>
References: <20230730143107.2845172-1-sumang@marvell.com>
 <20230730143107.2845172-3-sumang@marvell.com>
From:   Jesse Brandeburg <jesse.brandeburg@intel.com>
In-Reply-To: <20230730143107.2845172-3-sumang@marvell.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?TVpUM3pPRXpSamZBRUlFQk1zQ3JpZVdhazI0TUVJaVA0WXFIbEFJMHp5bGlu?=
 =?utf-8?B?a1M4dkdqMDlFNGNXNEpiSnlMTGNINFRPQlFUOE5TNjN6US94bjRKWFhVU2lj?=
 =?utf-8?B?aVZPdExacmhoYUxYeTZCUWZwQ0s2UmZ1UkxPMEtWMlFiS01iaUZYbkhHbjVD?=
 =?utf-8?B?THlkS3lUQS8vZlNOSlRVRTZoeDNHOHFHejVGcW5IRWhXb1BHM29vOG9iRFNh?=
 =?utf-8?B?QUs3VlNoMkdkbVhNRDZGbGsrU2ZqckRyVGhWc0lXYktOdWpOMmJiTmI4dVNB?=
 =?utf-8?B?Q2VNT3hBZy9Gd3YrQ0JhWkRjd2FUU05tS21FWm4zL05qeWtXbzZieDhQTysw?=
 =?utf-8?B?ZUp6T2lrREtVVmJ2TEFMU3pvRzFuaytWRUNOZEthUTlic0RYcE9kQUtxWXdy?=
 =?utf-8?B?K0FDM25RcmN4bnVURXJhb0NBYVpidFhIUkMrcktOZWJ5alhjdzJGOWNMUm5t?=
 =?utf-8?B?VnJVb1hLQlp3SHBTYitpT2FxUmJvbGtQRldBaG5SNE15MlA2VWV4NzNpbmtn?=
 =?utf-8?B?bWJ2ZU9FVE1uWG1Nakd1OStFUFowMjJyQktCR3pPTEFhenUyT0NzNEllN2w1?=
 =?utf-8?B?MFFEU2VUYi9LbGlnbzVPWmhpaGJ5bGxYak1YOHpoZkhQSDJwV0JZRi85R3do?=
 =?utf-8?B?RjR1ZXlleWMvdnc2UHVrb3drQk1TNkFpV0dwSUdEQ2pCVjd1Rk9RNVFqL0ZT?=
 =?utf-8?B?NUlMdFovTXZGQ2NGbGJRYlU5ekphVXZrakRXb0d1T0V2U3duM3ZTNk5GQ2ow?=
 =?utf-8?B?Z20vNEhVbm1oZnF2NTVlNGdjUWpYZmZHaDZUM0lnZ0VQYndDeVB4cjRlTlBl?=
 =?utf-8?B?Um5veFFCWDNJM3ZUVEx2Q2JFTkVqYW1aRFdtUlM2S2MrK2JHYi9LSVozaFk5?=
 =?utf-8?B?OEpDUEtuR3p0dTlXbE90ZVVoN1A2ZzZmanlYbjlTOW5HakdPOEw2dUJpV3U4?=
 =?utf-8?B?TForSk1nS3ZnNnI5a29DQmFxTUsyMUFiYlIvOUZuVWttYnVxd3MwendiSHcz?=
 =?utf-8?B?YW9iNGhZb0w1NXV3eG1PbjVRQVl1UTV3QW1IMWxLbEFvQWZBQjFFNDJRekFG?=
 =?utf-8?B?dmJya3hVcG9hc21FYkIraENqb1RtYUN2eUtmMVJwSldNQVFhMWYxZzNYRUkz?=
 =?utf-8?B?R0hrWUpIZHBRK28xRmpHVzRHSHRuRmZzaHBPMGN2Y3dXTGJyNVg0UXlsS2Ew?=
 =?utf-8?B?b3JyVVBGcXJ3TU13b0pvL2xtQmJoRFlLVTVRcEVQdGtIOHZHcndkS2FBL3Bh?=
 =?utf-8?B?OGVFTldxMU8vY1c3eEd2NjRSUFZnQWhsRnBFWE40WU1yRTV1QzlQY1RoMUZF?=
 =?utf-8?B?T0dUSnRzcmxMdXFnMnVqTHJkWmdMMmRZKzNoeWRGK1VMS29lYko2bFBWNmpZ?=
 =?utf-8?B?WlhQYnZyL2x3Zy8vLzIrTmQvWGFjdzMwMVBBY1ZGTXhrblFEWkhMNHJCOGxR?=
 =?utf-8?B?YlRxbENIVHVzRVd0eWl0ZjBhNm5jb0NQcFVvODlZZDVyTWxiaktnT2diS3Fz?=
 =?utf-8?B?akNmWldkQ0JaL09RcTNaWi9tWHpOSVdjd0tUNkFwQTVYWm01MXFPYVJsUkNC?=
 =?utf-8?B?WHNvVis0bE5GMTY2ZlpOYzQ1dnliYkpGbWVtcEtzTU01QStrRS9vN0pnVXRj?=
 =?utf-8?B?QTR2Ty9GWkVlV2FRdGdabnJzd2orYmFHWXlDMWZFTUJGQ2txS2V3OFlaWG9x?=
 =?utf-8?B?bEF5aE1hUmVkTnF6YVdWM3JyNUc1VE8zMWxETWRZWmk1dE0ydlZQR05FdCtK?=
 =?utf-8?B?VnhFS1VaYy82ZUlpdGhJNUNIbXJ0VVdMNC9LRzZiTXRONzlaOVhuandodGwx?=
 =?utf-8?B?bE56Z1B2QjRlSDZIZG1aYVAyaWNLeW9SU0V5M0UzZjB5cXhSNmpGMm9ZUWt3?=
 =?utf-8?B?YW9FMHlTU0JxTlVnS09SZ3hrejN6WDdnUnkvN0cvS1JJd0JpYjVFSFZUc0hH?=
 =?utf-8?B?Z2gwczFzZlpUd0RHTVdxd2JNNmVwczB4Q3FQMVA4VVRSNmtIUFZEN0dwU2dD?=
 =?utf-8?B?dUVJNDJXd0pwbmxxMFlBQTkrQWgzOHBOTEx4WkpnZFZSRjY3bnFqNWZvSWJU?=
 =?utf-8?B?N2xiaWh1c0VoK2FaZTltSmh6TS85b3ViU004b1pOb2JIWTFKWkVxK0ZlLzZi?=
 =?utf-8?B?RVNnVHZhRmdmUzBXZnpBZXNhakVqUzN1bWlhdmlHNGl3VEMvNnZNeUIwdldN?=
 =?utf-8?B?Wmc9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 791aed22-abef-4a80-8d0e-08db91eb0288
X-MS-Exchange-CrossTenant-AuthSource: CO1PR11MB4914.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 31 Jul 2023 17:24:35.0197
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 2/59/D78RyysjX9pI51W7JOZ/xRTTA2qS5i7GjMp95UPl0VQ3lvOnNhhL1oxadtNqC1TXvPoCw+7QHHwty48pWhlh18IfN+6v29b9HwsztA=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR11MB5615
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.5 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,
        RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 7/30/2023 7:31 AM, Suman Ghosh wrote:
> This patch extends current TC flower offload support to allow filters
> involving inner VLAN matching, to be offloaded to HW.
> 
> Signed-off-by: Suman Ghosh <sumang@marvell.com>

Use imperative mood please.

if you happened to change the patch for some other reason I might update
the above text to:

Extend the current TC flower offload support to enable filters matching
inner VLAN, and support offload of those filters to hardware.

Otherwise the code looks fine.

Reviewed-by: Jesse Brandeburg <jesse.brandeburg@intel.com>