Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   "Martin K. Petersen" <martin.petersen@oracle.com>
To:     njavali@marvell.com, mrangankar@marvell.com,
        GR-QLogic-Storage-Upstream@marvell.com, jejb@linux.ibm.com,
        linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org,
        Lin Ma <linma@zju.edu.cn>
Cc:     "Martin K . Petersen" <martin.petersen@oracle.com>
Subject: Re: [PATCH v1] scsi: qla4xxx: Add length check when paring nlattrs
Date:   Mon, 31 Jul 2023 15:45:05 -0400
Message-Id: <169083266403.2873709.2950258839122967870.b4-ty@oracle.com>
In-Reply-To: <20230723080053.3714534-1-linma@zju.edu.cn>
References: <20230723080053.3714534-1-linma@zju.edu.cn>
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit
Precedence: bulk

On Sun, 23 Jul 2023 16:00:53 +0800, Lin Ma wrote:

> There are three places that qla4xxx looply parses nlattrs
> * qla4xxx_set_chap_entry(...)
> * qla4xxx_iface_set_param(...)
> * qla4xxx_sysfs_ddb_set_param(...)
> and each of them directly converts the nlattr to specific pointer of
> structure without length checking. This could be dangerous as those
> attributes are not validated before and a malformed nlattr (e.g., length
> 0) could result in an OOB read that leaks heap dirty data.
> 
> [...]

Applied to 6.6/scsi-queue, thanks!

[1/1] scsi: qla4xxx: Add length check when paring nlattrs
      https://git.kernel.org/mkp/scsi/c/47cd3770e31d

-- 
Martin K. Petersen	Oracle Linux Engineering