Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-id: <40058d79-7363-9474-2af0-b8e02b7b01ab@augustwikerfors.se>
Date:   Mon, 31 Jul 2023 21:11:39 +0200
MIME-version: 1.0
Subject: Re: [PATCH] nvme: Don't fail to resume if NSIDs change
Content-language: en-US
To:     Mario Limonciello <mario.limonciello@amd.com>
Cc:     kbusch@kernel.org, axboe@fb.com, hch@lst.de, sagi@grimberg.me,
        linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org,
        nilskruse97@gmail.com, David.Chang@amd.com
References: <20230731185103.18436-1-mario.limonciello@amd.com>
From:   August Wikerfors <git@augustwikerfors.se>
In-reply-to: <20230731185103.18436-1-mario.limonciello@amd.com>
Content-type: text/plain; charset=UTF-8; format=flowed
Content-transfer-encoding: 7bit
Reporting-Meta: AAGxKd0J+EDPNkJxyVSwXV8t9u0oYmwvO47EmDb/N7KkuuHQNewGDNL7XqL4XvXk
 NwsfeuoNmYe+xIBGUiBvhWydppa6afCXI4kCdXEWhBhqrP54E4jELLLFsSOeVlhg
 jbNaWmDyFxUqVZ/Z2h52VOYFHsAcxfZONf2+M1Ya5vjprII928j7jiSF/BUCYXMk
 OuqAuAU4MNSKQ5TIUezYSmMG4fPiU0TLGz+Ee0Q1FgY1bNnWEuOgsfTtqhYxyieM
 nczzINySIbeK2ybS0uMIQDGGuJVq/P+Xk9unmJtr10xSyl79E7RZbiKWNk7pRg07
 iaXcL78DTQO1bhUrk4+FI/LS/NYVaL+I5aDMC2xnn2qp6UPFORDgSt1OAyBExywj
 HcbdG+jouggaBZuMw+BbMkgD6hS6YtGtCh/rt8GiN5P+Owvm0NgiPMp4rW0nkvuA tyXeIKs=
Precedence: bulk

On 2023-07-31 20:51, Mario Limonciello wrote:
> Samsung PM9B1 has problems after resume because NSID has changed.
> This has been reported in the past on OEM varities of PM9B1 parts
> and fixed by firmware updates on 'some' of those parts.
> 
> However this same issue also happens on 'retail' PM9B1 parts which
> Samsung has not released firmware updates for.
> 
> As the check has been relaxed at startup for multiple disks with
> duplicate NSIDs with commit ac522fc6c3165 ("nvme: don't reject
> probe due to duplicate IDs for single-ported PCIe devices") also
> relax the check that runs on resume for NSIDs and mark them bogus
> if this occurs on resume.
> 
> Fixes: 1d5df6af8c74 ("nvme: don't blindly overwrite identifiers on disk revalidate")
> Cc: stable@vger.kernel.org # 6.1+
> Cc: Nils Kruse <nilskruse97@gmail.com>
> Cc: August Wikerfors <git@augustwikerfors.se>
> Cc: David Chang <David.Chang@amd.com>
> Link: https://github.com/tomsom/yoga-linux/issues/9
> Link: https://lore.kernel.org/linux-nvme/b99a5149-c3d6-2a9b-1298-576a1b4b22c1@gmail.com/
> Link: https://lore.kernel.org/all/20221116171727.4083-1-git@augustwikerfors.se/t/
> Link: https://lore.kernel.org/all/d0ce0f3b-9407-9207-73a4-3536f0948653@augustwikerfors.se/
> Signed-off-by: Mario Limonciello <mario.limonciello@amd.com>
Tested-by: August Wikerfors <git@augustwikerfors.se>

Thanks!