Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 31 Jul 2023 23:01:51 +0200
From:   Sebastian Reichel <sre@kernel.org>
To:     Wang Ming <machel@vivo.com>
Cc:     Stephen Rothwell <sfr@canb.auug.org.au>,
        linux-kernel@vger.kernel.org, opensource.kernel@vivo.com
Subject: Re: [PATCH v2] hsi: controllers: Remove error checking for
 debugfs_create_dir()
Message-ID: <20230731210151.jc3yxdc5wddvqzld@mercury.elektranox.org>
References: <20230726123059.7196-1-machel@vivo.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="gi3v7s7lqozhel3u"
Content-Disposition: inline
In-Reply-To: <20230726123059.7196-1-machel@vivo.com>
Precedence: bulk


--gi3v7s7lqozhel3u
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Hi,

On Wed, Jul 26, 2023 at 08:30:46PM +0800, Wang Ming wrote:
> It is expected that most callers should _ignore_ the errors
> return by debugfs_create_dir() in bond_debug_reregister().

bond_debug_reregister()?

> Signed-off-by: Wang Ming <machel@vivo.com>
> ---
>  drivers/hsi/controllers/omap_ssi_core.c | 2 --
>  1 file changed, 2 deletions(-)
>=20
> diff --git a/drivers/hsi/controllers/omap_ssi_core.c b/drivers/hsi/contro=
llers/omap_ssi_core.c
> index 84ba8b875..57c63053f 100644
> --- a/drivers/hsi/controllers/omap_ssi_core.c
> +++ b/drivers/hsi/controllers/omap_ssi_core.c
> @@ -115,8 +115,6 @@ static int ssi_debug_add_ctrl(struct hsi_controller *=
ssi)

function can become void, if errors are ignored.

> =20
>  	/* SSI controller */
>  	omap_ssi->dir =3D debugfs_create_dir(dev_name(&ssi->device), NULL);
> -	if (!omap_ssi->dir)
> -		return -ENOMEM;

What about the second debugfs_create_dir() call in the same function?

> =20
>  	debugfs_create_file("regs", S_IRUGO, omap_ssi->dir, ssi,
>  								&ssi_regs_fops);

-- Sebastian

--gi3v7s7lqozhel3u
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEE72YNB0Y/i3JqeVQT2O7X88g7+poFAmTIITwACgkQ2O7X88g7
+pr4Bg/+KHZjmIdMwsIrXpHE5OAhX3SnikqJRQe5hagCdDbLu/BXE0TvlohwW5nb
NtvL0KX48L5wn/qctUve4xM0hbh0NEMg03k0szZr/xCgPsQ9sz6FAtFOfLdEVjbo
GpM/7N7h+P+3dk27hdwOiwwX84o0E5wIgfl9e8YEITsNNd93LwYaPFp67D8v5L6a
XPaoJWhg0ijXLrSPfNuOzyfIME7O0jTOVbckpXweSIfP2g0KtDAic/H+Qmh6hyTu
YHXQ48WDM/JO9fkZ6drgJaDWtAjbkgsq0RxlMv/3ygmFWPHMLf77V5Xo437o39dH
d2+spQaQIBKYXSw2Zcze5OWhoTs3y/eOWTYpq1DQrfZYyN6JzpHsPrGBxCcCGrm6
lrZphDhN7yeGeOEKaLuO7j5g3BEaH+VoOl1gQcIKf2y2b1xvL8QDtgU+M1pruWwn
OVgxCj9tATUz21QbGb+tKRjPVGPXRsA74jppQHXRi+iw2pG6ia7fijQ0T+7kaByM
/fjgi85FhN9xEx7N/JA2g/tdK/gDkgf+AK7rq+gpza5HfeTZ94M3WTSKVX7gLAg+
hhTelU9oK6MFC92+FM0Z5wLU4IidDCilQZYXb2YUIfYrj7DVaiMvH+gxiY1zLqJu
c2RASN5IiIhs4zR45BaUUFRX/aqOBXtL5cLdmoym4OQGCmWZbHE=
=kN2r
-----END PGP SIGNATURE-----

--gi3v7s7lqozhel3u--