Received: by 2002:a05:6358:c692:b0:131:369:b2a3 with SMTP id fe18csp4907582rwb; Mon, 31 Jul 2023 14:31:05 -0700 (PDT) X-Google-Smtp-Source: APBJJlEPFlLbRtTqxr4xUC3EosoCpZo2METCHyUmgXNIiD7KarOIwe5lIyzPDqvRFfdrYqK4hMxk X-Received: by 2002:a05:6402:12cd:b0:51d:d5f2:121c with SMTP id k13-20020a05640212cd00b0051dd5f2121cmr893328edx.5.1690839065755; Mon, 31 Jul 2023 14:31:05 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1690839065; cv=none; d=google.com; s=arc-20160816; b=O5xHnqrp/18iDtOghx920JfmLBWzTKothSNSXzQYYxskHXzS2aZci3mX40iaViNXeO WBsLZYk+v76nhKtP6NbpGIjq+jkn5zTTg3/HTEv1exrVySblKnEn30R/e2VxgwZSM5JO hK6CUUr+xoii6djCsub2DIyOiuDwSgyEwU7vUbrlWKTf0VKactuvS+/aDBaxexwYcxb+ TiSZwyS338H53tWOd83F2yw5IVDWXT86KjD3bTENfHeLqI51bgo/8LSjt4s1cmnpEkFJ J2cwAzV/H92biS+EbFynikG6UOpwL+kt1em9qMN/Uyvg8KFuioqVzG6ugttYYied2f6U NJLA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:organization:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date; bh=dgjr7nk9sjLyDk+VLIJ7SmcaUeQhQdAB9F6oUBTlaYg=; fh=i0OQUr5FdlBd/GpuZ3V+4jfIcnaTrEIj8xzaMULMjx4=; b=y4kUognR2wOuIdhYURMkwOagbdk9Gx6C2i8LCGWBSyoWVWrehCi9zZZ4Bk+CvjgBOq gzs//FVLRMGYAPVZK0iXLtTtnIrjstXiX/otdQIHhF7MbWr1Tfiw6afRauhGPb5RwDzX xNnK/X91MczAynbdJrV61Fss5AjzP26O+W/eGP2FdRawynlxBZibnKe25EBgS6/o2gjt VzS4N/73qMacGGujSIVCqMF1vZbTFCYnaTIK65NMdICRA+BI7j2FkuCy3ewzkF/JFdga kJ2Bx0CRJWmbqwtZOelE4/76vsVlj3VlD8lslWMV2oVZiwofnwml3zSJqufGJcYy2R30 cZRg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id v10-20020aa7d80a000000b005223a5a81d1si7343134edq.247.2023.07.31.14.30.40; Mon, 31 Jul 2023 14:31:05 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230101AbjGaUQr (ORCPT + 99 others); Mon, 31 Jul 2023 16:16:47 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46806 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229452AbjGaUQq (ORCPT ); Mon, 31 Jul 2023 16:16:46 -0400 Received: from mgamail.intel.com (unknown [134.134.136.24]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6414E10FB for ; Mon, 31 Jul 2023 13:16:45 -0700 (PDT) X-IronPort-AV: E=McAfee;i="6600,9927,10788"; a="371828127" X-IronPort-AV: E=Sophos;i="6.01,245,1684825200"; d="scan'208";a="371828127" Received: from orsmga007.jf.intel.com ([10.7.209.58]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 31 Jul 2023 13:16:44 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10788"; a="722210853" X-IronPort-AV: E=Sophos;i="6.01,245,1684825200"; d="scan'208";a="722210853" Received: from smile.fi.intel.com ([10.237.72.54]) by orsmga007.jf.intel.com with ESMTP; 31 Jul 2023 13:16:43 -0700 Received: from andy by smile.fi.intel.com with local (Exim 4.96) (envelope-from ) id 1qQZJp-004RKT-2N; Mon, 31 Jul 2023 23:16:41 +0300 Date: Mon, 31 Jul 2023 23:16:41 +0300 From: Andy Shevchenko To: Nikita Shubin Cc: Alexander Sverdlin , Linus Walleij , linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 07/42] soc: Add SoC driver for Cirrus ep93xx Message-ID: References: <20230605-ep93xx-v3-0-3d63a5f1103e@maquefel.me> <20230605-ep93xx-v3-7-3d63a5f1103e@maquefel.me> <79619e92b70fdb4b324758ddb34f84b3b8963256.camel@maquefel.me> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo X-Spam-Status: No, score=-0.7 required=5.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, FORGED_GMAIL_RCVD,FREEMAIL_FROM,MAY_BE_FORGED,NML_ADSP_CUSTOM_MED, RCVD_IN_DNSWL_MED,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE, SPF_SOFTFAIL,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jul 28, 2023 at 01:01:11PM +0300, Nikita Shubin wrote: > On Fri, 2023-07-28 at 12:46 +0300, Andy Shevchenko wrote: ... > I see your point now - citing docs: > > "Logic safeguards are included to condition the control signals for > power connection to the matrix to prevent part damage. In addition, a > software lock register is included that must be written with 0xAA > before each register write to change the values of the four switch > matrix control registers." > > So reading SHOULDN'T affect the lock. > > But as we checked reading also breaks the lock, that's why this looks > so odd, it was done for purpose - i'll check it once again anyway. This is very interesting information! Please, document this somewhere in the code. -- With Best Regards, Andy Shevchenko