Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <488c45ad-cab4-db19-4c0c-efaaaa3cfdca@intel.com>
Date:   Mon, 31 Jul 2023 13:01:30 -0700
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Firefox/102.0 Thunderbird/102.13.0
Subject: Re: [PATCH -next] net: hisilicon: fix the return value handle and
 remove redundant netdev_err() for platform_get_irq()
Content-Language: en-US
To:     Ruan Jinjie <ruanjinjie@huawei.com>, <yisen.zhuang@huawei.com>,
        <salil.mehta@huawei.com>, <davem@davemloft.net>,
        <edumazet@google.com>, <kuba@kernel.org>, <pabeni@redhat.com>,
        <netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>
References: <20230731073858.3633193-1-ruanjinjie@huawei.com>
From:   Jesse Brandeburg <jesse.brandeburg@intel.com>
In-Reply-To: <20230731073858.3633193-1-ruanjinjie@huawei.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?dVlSUHlSNTVqbVEvSytrYjFVbDAzUVlwUXVsTW9VbExTdWxQd2JTMEhsdEU1?=
 =?utf-8?B?TEVVNktGVEZlZDAzU01QdHVGNXlaRExJaU4zNFhsNTRhQ2JkK281SXJZckRK?=
 =?utf-8?B?d1hTZW9Ed1l4VXlxVDJHVWMvWERLYVR6UXViUW9oTnpwV3YrTjVscHZqcUdQ?=
 =?utf-8?B?UFpvUzVHeDlVNk1Cb08vYndtNnFTWU41M2phRTFZdWJXYjREREp2UGNZeXdG?=
 =?utf-8?B?NXhRUFU3N1BxeVRhNkJkSy9OVU1Ock15N09EZmJ4aG0xK2hTRUwvMGpucThQ?=
 =?utf-8?B?ZlFiT3dTblJvNExJOVRueE04T3FDbTBoZ3ZOR3FaMXZ3QzU2TTN2azRONGR4?=
 =?utf-8?B?K1Y0NytocWQ4bEhHaVJFRTNmeXhzejVDcVFreWUreEZNQnNyY09SV0dmQVpJ?=
 =?utf-8?B?czB3N01xRXg2dEZJU0pCZmFZSVMyZzVNQ1MyQWJYdnNldDk0ZXlmY3FNTjNY?=
 =?utf-8?B?dzBVbGdyUzhvdWtESy9jVTRXb2NyNlNQeE9iOGZ2ZEFMc1lTak12MGdpd0po?=
 =?utf-8?B?YStZR2sxaGxPbS9tQlBVd0dxWTB2SzFIdTQzVm1VT3Y0a0dST2ZESkxyUUw4?=
 =?utf-8?B?S2N1TVh0Z0dBNDFIMmpwam9kblhuRU15eTJON1hSckEvQUxPUWpJeFRXYnAz?=
 =?utf-8?B?WVNQcGZ6akRIM0pscHJJYVdtVmxPMytCM0x6cVRITkxzdmNwczBSdmlhd3NU?=
 =?utf-8?B?bHViUHZ0bmo2Y1RpcEZRdmp1WGpLajNaeVB3b2cvTjduZXB5WU5Oc3J3QnJv?=
 =?utf-8?B?N0V3SFc2SkZhSkpkYm5razlMQmJ6eVl6eVN5b3J2eUJTWGtITjU0N08vejBw?=
 =?utf-8?B?NXF6YTlEL0xEb3V5V0lCcU9GT2dIYUdzVWVMZVp5RVZpRWtwVWVOTWFEUmoy?=
 =?utf-8?B?V3Fyc2kzaHRaeFh4YTJKdFZrWXo2a21mTlllaWF5RkZhbHZndzRNMzdocEJz?=
 =?utf-8?B?UjhzQURJMldjZlIwaStUSkdEWm0wS1ZWdEp6QlhHWkVpZ2Q4U3V0c0FBM1ZY?=
 =?utf-8?B?c3dtZS84R3VnblBqSjM0VHNPejJlN3RBRGFOT252WnZiQzlRMU53ZGRnV0hD?=
 =?utf-8?B?NE1VRUR4dHBPWTZ3NzErZ0p4alZCSE5ZbkQrZFE2eEVnZ1I1dkhVSUZ4UnNn?=
 =?utf-8?B?VlQ4cVIycGMwTlpDUTlFNnNabjNuQ2VtYW16bVV1RkdRWFowK0hYcmVMMm9D?=
 =?utf-8?B?WDZmQXhoZXJLdjlkZmVtaGw2Wmx3STZ1OHI2SERqZjVZM3F2VnlBbTdMYmdC?=
 =?utf-8?B?UVdVdGN0eUpRUE9oZGk0K0t4YmFDU3hlaEVsdlpWcjU5MnR1anBZVitYemFO?=
 =?utf-8?B?WnFEVXkwYWhnRTFUZlU1WTRkWElzRTMvb0FxQ2pMOXVWMDMzWWtEa2hYQzBa?=
 =?utf-8?B?RnB0Vnl2b093eTA3dzZjNFpDdmNlQmVaNVM1MGtLTy8wQlc0Zjl5SnpFRkZW?=
 =?utf-8?B?MzFvRS80VHJSbEs4Tzl2Y0NEMzBDSzdxNnRKK09qaHFrUUd5LzR0RjIrQ3BS?=
 =?utf-8?B?M0hIN1lVNGZyeEhQZGRBb2FEcFBhWjdzQTdiN2FCZ0liZjBFcHlCZUttRGFR?=
 =?utf-8?B?U0NHZFFONXMyNDlacDJ5NDM0cHY5NEY1RGhmb1hMcmIxWU9pS2V0dzdKV1hk?=
 =?utf-8?B?bDFkYjVkaG5uczhzdjBqb0h3Z3hhZWtEWUdRU05YN3JPakxLY2t0MFdBemZE?=
 =?utf-8?B?b0JXNWZrREEydlJ1Ly8zUjZ1RnRMNFFLdUtBM2psWkJXUDZOREZ1dDVTOWtC?=
 =?utf-8?B?UmFzVStQZVEzNDlqc3hJdXRId1B2OSthSkRScDVTMElTdERSMHorNW8zaWZR?=
 =?utf-8?B?dkp3YnZJQzBEckhLRHJYQ244aGxtUWF3MXYyN0ZzclBpOTFNVFRqOCttWEY3?=
 =?utf-8?B?ZFpzUml2emUySTJPRlRNUTQ5WUxmRWFWYjhIeDY1c2orY25sNUlJWmx6ZWxN?=
 =?utf-8?B?UFdRcy9nM1U5MnQ2L2lOVXR3TmpLVkM2WGJ0djA5SHFkdDRMUnZ1Nit3elJ1?=
 =?utf-8?B?OEhMcm5QbU95SVBFSU9ncjU1SEZ0NDJZaENnTTRxVVhCM0d3eXlNWEMzcWhy?=
 =?utf-8?B?VHNJVU1PODRod3dVTE1BRlozQnR1M2h2SGhnNEkwc0RWbWRnVUhiYXZRZita?=
 =?utf-8?B?WWU3VDU4YmhaZTVSZlhMdGgwVWw3dWZrS2htMjFiTjJISCtERVZJd1M2V25h?=
 =?utf-8?B?b3c9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 49e78154-1c59-4dae-cfa9-08db9209a608
X-MS-Exchange-CrossTenant-AuthSource: CO1PR11MB4914.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 31 Jul 2023 21:03:54.2902
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: YNK35GPzuSSIwIJcu+XpBZDmBZvglHDcJZViAIYFIqe76/sbOjiZZKFDO8bYV7sOkXiIy0TK7NKhIK950asYoS9jtsfLrPSXh6KDqh94ark=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR11MB6694
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-2.2 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,
        RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 7/31/2023 12:38 AM, Ruan Jinjie wrote:
> There is no possible for platform_get_irq() to return 0
> and the return value of platform_get_irq() is more sensible
> to show the error reason.
> 
> And there is no need to call the netdev_err() function directly to print
> a custom message when handling an error from platform_get_irq() function as
> it is going to display an appropriate error message in case of a failure.
> 
> Signed-off-by: Ruan Jinjie <ruanjinjie@huawei.com>

Makes sense

Reviewed-by: Jesse Brandeburg <jesse.brandeburg@intel.com>