Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 31 Jul 2023 14:45:21 -0700
From:   Bjorn Andersson <andersson@kernel.org>
To:     Konrad Dybcio <konrad.dybcio@linaro.org>
Cc:     Luca Weiss <luca@z3ntu.xyz>, ~postmarketos/upstreaming@lists.sr.ht,
        phone-devel@vger.kernel.org, Andy Gross <agross@kernel.org>,
        Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Eduardo Valentin <edubezval@gmail.com>,
        Conor Dooley <conor+dt@kernel.org>,
        Rajendra Nayak <quic_rjendra@quicinc.com>,
        Rob Herring <robh@kernel.org>,
        Andy Gross <andy.gross@linaro.org>,
        linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org, Craig Tatlor <ctatlor97@gmail.com>
Subject: Re: [PATCH v2] ARM: dts: qcom: msm8974: correct qfprom node size
Message-ID: <ff6fwomoik6kz4jtbm5jac7jahrtcia5fb6dj5ykxg7xt574sn@ti42sevqj6pk>
References: <20230130-msm8974-qfprom-v2-1-3839cf41d9ee@z3ntu.xyz>
 <866f1f66-8845-2453-ab9c-d125e23ae758@linaro.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <866f1f66-8845-2453-ab9c-d125e23ae758@linaro.org>
Precedence: bulk

On Thu, Jun 15, 2023 at 08:20:41PM +0200, Konrad Dybcio wrote:
> On 15.06.2023 20:17, Luca Weiss wrote:
> > From: Craig Tatlor <ctatlor97@gmail.com>
> > 
> > The qfprom actually has size 0x3000, so adjust the reg.
> > 
> > Note that the non-ECC-corrected qfprom can be found at 0xfc4b8000
> > (-0x4000). The current reg points to the ECC-corrected qfprom block
> > which should have equivalent values at all offsets compared to the
> > non-corrected version.
> > 
> > [luca@z3ntu.xyz: extract to standalone patch and adjust for review
> > comments]
> > 
> > Fixes: c59ffb519357 ("arm: dts: msm8974: Add thermal zones, tsens and qfprom nodes")
> > Signed-off-by: Craig Tatlor <ctatlor97@gmail.com>
> > Signed-off-by: Luca Weiss <luca@z3ntu.xyz>
> > ---
> Not sure of the actual size of the region, maybe Bjorn can help..
> 
> Downstream 3.10 suggests 0x60F0, 0x20F0 after adjusting for the ECC offset
> 

There is indeed 0x3000 bytes until the next region, but afaict the
corrected ECC values only cover the first 0x800 bytes thereof.

Can you please let me know if this patch fixes a problem, or just
makes the numbers look better?

Regards,
Bjorn

> Konrad
> > Changes in v2:
> > - Keep base offset but expand reg from 0x1000 to 0x3000 (Konrad)
> > - Link to v1: https://lore.kernel.org/r/20230130-msm8974-qfprom-v1-1-975aa0e5e083@z3ntu.xyz
> > ---
> >  arch/arm/boot/dts/qcom-msm8974.dtsi | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/arch/arm/boot/dts/qcom-msm8974.dtsi b/arch/arm/boot/dts/qcom-msm8974.dtsi
> > index 7ed0d925a4e9..3156fe25967f 100644
> > --- a/arch/arm/boot/dts/qcom-msm8974.dtsi
> > +++ b/arch/arm/boot/dts/qcom-msm8974.dtsi
> > @@ -1194,7 +1194,7 @@ restart@fc4ab000 {
> >  
> >  		qfprom: qfprom@fc4bc000 {
> >  			compatible = "qcom,msm8974-qfprom", "qcom,qfprom";
> > -			reg = <0xfc4bc000 0x1000>;
> > +			reg = <0xfc4bc000 0x3000>;
> >  			#address-cells = <1>;
> >  			#size-cells = <1>;
> >  
> > 
> > ---
> > base-commit: 858fd168a95c5b9669aac8db6c14a9aeab446375
> > change-id: 20230130-msm8974-qfprom-619c0e8f26eb
> > 
> > Best regards,