Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <36319a0f-34a6-9353-bc52-4d4d0fac27a5@amd.com>
Date:   Mon, 31 Jul 2023 15:14:54 -0500
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH] nvme: Don't fail to resume if NSIDs change
Content-Language: en-US
To:     Christoph Hellwig <hch@lst.de>
Cc:     August Wikerfors <git@augustwikerfors.se>,
        Keith Busch <kbusch@kernel.org>, axboe@fb.com,
        sagi@grimberg.me, linux-nvme@lists.infradead.org,
        linux-kernel@vger.kernel.org, nilskruse97@gmail.com,
        David.Chang@amd.com
References: <20230731185103.18436-1-mario.limonciello@amd.com>
 <ZMgHE2wu4T4OfrTR@kbusch-mbp>
 <040c5788-1a7b-26ea-23cc-ba239c76efa9@augustwikerfors.se>
 <39697f68-9dc8-7692-7210-b75cce32c6ce@amd.com>
 <20230731201047.GA14034@lst.de>
From:   "Limonciello, Mario" <mario.limonciello@amd.com>
In-Reply-To: <20230731201047.GA14034@lst.de>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Y3lyTDZ3ZnQ0VkRqbHhhWUM2N0hpNmRlWEdZZnJLUzVYUmw2Zno0WkxEMHov?=
 =?utf-8?B?THJ3c2NtT2VJdVB3cXZ1WkNvK2h0L1Yrc2lqblFnRzk4VmRtSEdxWjRzdWhy?=
 =?utf-8?B?RnhSZlRDRVZyZEsySVNweC9HZXFRaDdnOWR2bDhhakpmL1VxT05SZ0l0THd3?=
 =?utf-8?B?YkxGZlFjejFPWUg0MXJmYWpZUDlrN2R2OU9NRG1MNXNWdFY4NlZvTzZSSy9D?=
 =?utf-8?B?RmVhbDZXT0p2dUlZcFhZNlVhNlBUNE4rcGF6WTloVytUdHNmRjk1R3hMSVBY?=
 =?utf-8?B?UEpJM2ZPY05VU1JGOVR3bzg0ZDhQOG1pek5HOS9jQ1B0NXdsaHRvMGplVDJN?=
 =?utf-8?B?WlowZFUra1k1WGhtVXM3TWxvdStDZEpsa1dCYXdwbC9yeUZESTZyRzk2K1BY?=
 =?utf-8?B?b1BNUFM5Qnh2b00vVm1ldXlSeG4wOFFrQ1JNdXZaZ2hPWFUzTGZvczV1U0ll?=
 =?utf-8?B?K0ZUMFljVE5Hdm9oanVwcEY5WlhRczdhdkhKTWV5Mzk1cFdEOVlTKzY5aU1H?=
 =?utf-8?B?eVdmakdNOFdJV1owVGExQzJ6YTJsZ0pSODY1c1VIK3FkNzJ4TjZEQVF6MjNT?=
 =?utf-8?B?MTlxeUs0a3FYS3FyZ3I3NE1kRnVqT2ZGMGZpTGRnZVZjY1Y2MlFwaTdHdTlV?=
 =?utf-8?B?dG5zWmFJc3hOSG53RnlHaDhmc2hQTnFGdm5tR2lyZ1U3WXlOWVpxRkF6d0t0?=
 =?utf-8?B?dGFLYk52SFJOUlJINjJMdzRjanF6eW8vZ3hKZ0M1ZmVvUWJhM1JienBGZnJs?=
 =?utf-8?B?T0wzL3Zrd216NFdQV0JxaXlSbThQVFpFS1lyVEM5Uzd5cUxKenBrZVY5RFRB?=
 =?utf-8?B?QU1pWmtncTl2Wk1CT0czM3owcDVtMERIWlljdDVIZFVnakxvaUpWaFZOeHVM?=
 =?utf-8?B?bENRK3g2am5XNGRUWWI0a29vcCtTUlFjN21oVEhmVEkzNXVQNWJ4QkxaNGNS?=
 =?utf-8?B?bnlLLzRrM2NyQWwyeHhxdG81TUVUTDJUck1KWFpvS0RCckk2cFk2eHg1SWYr?=
 =?utf-8?B?TGZ3SCs1ZUhOenN3d3dITDJ5ZFRoekRhOUx6UjJNVEM2RGhaOEpnTTh6aGF4?=
 =?utf-8?B?TVcwT0duM3ZHZUNVblB5SDhKSEV0VVNKb2NOdEpuSC92TVdXdm5raklQT2gw?=
 =?utf-8?B?LzJMZVhjL1RJRXhwd0VJVFBTRnRveG0wUzdTL2pML3VqMDNRSFlJZi9HcUds?=
 =?utf-8?B?ZHBwY3RKRUFNcVZ0aUg3M05KMVBtbEFjeG1oa1BUSkRjVEpEc1Qrc0Z1SHBx?=
 =?utf-8?B?Y2lzcmNnazA5bEwxNWZ3ZzNCS0szZG5KeUJnejdKV2lHamRObjRYbnZNTG5W?=
 =?utf-8?B?citQTURGRCsxM2txTGdINVgzc1Rsd1IxVVZRVDQybTlwNzYrQVdUVi9ZM1lv?=
 =?utf-8?B?Mk43MEhoVVR5VFJjTTJSdFZ1OWJkWDlDbjduNmMzcExaWmJQZFltV0NuaFZz?=
 =?utf-8?B?b2ZVR1dzSFZtY1JNRWlScXp4YXYrQWszYVpRSnhtZUxuR3dwZFJ1SklleXRT?=
 =?utf-8?B?dFFMdXZpQXA1UDBLMytjNVMwbEl2R1NaVlZlVEc5WkdLQXU4bUNMcTRtTWxU?=
 =?utf-8?B?TUxWZ2RnVWd2OHlXVC9WWEFnTk1OaU5KRVYxeWVzTzVEZUs1Z0laczdYM0ZJ?=
 =?utf-8?B?WHFqa2ttcWNBbXZSOVU1MkNNdmtrYllCTFlEdnNWTWZMTEQ0MjZlaEpCRmU3?=
 =?utf-8?B?ei9UejJzV0ZpMUI1aGZqdlo0dmFSWnRaR25YYVFzS05jVnVQdXNKUGNxKzNo?=
 =?utf-8?B?R2JFQ1lDVldUdmhhL1lqU3hzcWptbVQ5Mlp3WGNtYzJIcEMvQjh5UElOQW1t?=
 =?utf-8?B?a2h1UWRzeUdnSnhhTHB2Q0V1eUJaTCtYU2M1cm8vaTd2eEZ1bk15OGU0eWM4?=
 =?utf-8?B?dzhybHZoMmdpZ0FSTEt4N3duZEpacjVBMjU0MDN1UDhSVmVOUjJVK29iVDBK?=
 =?utf-8?B?YzB5SDM2YTBNZVhUVDA1YmpEcmRFTXpyY1VvbXJpNElmRHF5TVpXbytkQitP?=
 =?utf-8?B?U2JoNTNzZ0hPZjZOczRPYmZQWG05blczaEt5VXkzYm9JVGQ1SUZBQm84R0d2?=
 =?utf-8?B?ODJGOW9jOXI0ZTAra003eDZWaUtvK1JUdHQ2Nkw5RU1ZMUdtUjR6NWpkQzBj?=
 =?utf-8?Q?1KOP1/j4zDrYBRIzWriYSG4Bb?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 1c08401f-2257-40b0-0aec-08db9202cf90
X-MS-Exchange-CrossTenant-AuthSource: MN0PR12MB6101.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 31 Jul 2023 20:14:57.4292
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: tyR+M/9R91N7nrLkbaUcMY2HGmHAeThk/Sslsr70WdiGzuLOfILsd50obhPsdT3rHHYCCh74fzRge9eVLW7QOA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ2PR12MB8157
X-Spam-Status: No, score=0.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,
        RCVD_IN_DNSWL_BLOCKED,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE,
        T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 7/31/2023 3:10 PM, Christoph Hellwig wrote:
> On Mon, Jul 31, 2023 at 03:09:08PM -0500, Limonciello, Mario wrote:
>> So is it reasonable to just add a check for
>>
>> ctrl->oacs & NVME_CTRL_OACS_NS_MNGT_SUPP
>>
>> In the same error handling path as this patch?
> 
> No.  There are tons of NVMe devices that only support creating and
> deleting namespace out of band, especially in virtualized and cloud
> setups.

Even if it's only the error handling path only that it's checked?

If you don't want more changes or heuristics on the error handling path 
for this case, I think the best solution is probably to pick up

https://lore.kernel.org/all/20221116171727.4083-1-git@augustwikerfors.se/t/

instead then and hopefully we don't end up with more disks like this.