Received: by 2002:a05:6358:c692:b0:131:369:b2a3 with SMTP id fe18csp5021321rwb; Mon, 31 Jul 2023 16:58:03 -0700 (PDT) X-Google-Smtp-Source: APBJJlFxcWHSAK9/6s3GzZLjHDzN2pYsK2fKE7DqWyvBQwPdzZztsXsHxiuQ/y0rAudnHKvrQHKh X-Received: by 2002:a05:6a20:7f9c:b0:12d:10b6:98f9 with SMTP id d28-20020a056a207f9c00b0012d10b698f9mr13798271pzj.56.1690847883527; Mon, 31 Jul 2023 16:58:03 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1690847883; cv=none; d=google.com; s=arc-20160816; b=iM5hRoDiQooYaFtw34AoJ68DH8Nzpkcrm0mkDaxvd5fA2hocXNfp5WoLN64F7Bhzw6 lC41/BKfFSuOpQa72uHyVWiqh9G7eb3NZK/jXOe4xPsaYzm17wippKMFuj6grqsQH9go cv/wUcfWlaJSaluArTJj7HSRiQh5GCqqGO6UcPWxLkkedPGLNGaGQ9In17jwoUJp6b0K 2MNMDDShX1RbLrBr0CaNC/EyM7FdW0dwoCDXQhAI2E+grXaUvo/+ZfS8AaxrNcp4yN3U 5/RtpBVa5Y8j5EZaLD+0nUSuQiCsyP9fNZ6X2gxK+GiaASufl0+8uYJBThyFnoQAl4hs e2vQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to:from :references:cc:to:content-language:subject:user-agent:mime-version :date:message-id:dkim-signature; bh=aPb5lDChIqfPMvwsibTI6iiSscbrWxn/ZOI0E80W52g=; fh=j2XCbeLq0mrQTlGkuyRjYhQqj9upqZ2w3CI6yexHyEo=; b=H0ISo+gXDHXXAd0DMeScMg1fXziy6ih27UxfwigBSIdbGOhltqQ6j33H7pP0hMuQi7 61ll6DVqNeAHqCJpHGZwJzFYl0eVaYcwRxK5ZsftsE8yKtYtgsHa8+QUPqHXsv0GCTBM XoL19/BshAkiGNf4fL5m1KMOz/nADDis5J9Np1QyHhJJnmO9fRACtJOFL+pA8Bv8qpKX DIsswG9wa0gtUfr44oaCod0MMdZx4ecUrT3m5k8YLz/4aVhMoklRbN5iYO5bxgWXiKJy 4nZHasezWSNkGapbmgDcZrVWUrf3djUlnOve6MOgoYZQiWn9e4R8pTe/5f1MyTxQsTOx 9bsw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b=t3zStTyT; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id fh42-20020a056a00392a00b0068219eb27a9si8010323pfb.233.2023.07.31.16.57.51; Mon, 31 Jul 2023 16:58:03 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b=t3zStTyT; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231694AbjGaXJZ (ORCPT + 99 others); Mon, 31 Jul 2023 19:09:25 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34470 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229768AbjGaXJY (ORCPT ); Mon, 31 Jul 2023 19:09:24 -0400 Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8FB441BDB; Mon, 31 Jul 2023 16:09:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding: Content-Type:In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date: Message-ID:Sender:Reply-To:Content-ID:Content-Description; bh=aPb5lDChIqfPMvwsibTI6iiSscbrWxn/ZOI0E80W52g=; b=t3zStTyTjRAu54dTUV7IgHJULD whMKO8pdGNdJNVJKiiZuFAeR+XJUqtjwFS+1W5IKKFkVF0ZxHAPT4camP4YE4GoIyXxiCOZkVf66z YV89XyfSzJPKbVczfjOGvZNmHxsWlMztiN9iMqUIzK6NWI4vWbUbxaS6kAt2aqkjL8qoqPKmnLdgg C63HPaYGIJwDCYYKVTqVKv9HkVZmbpHt/jDhZH1/cQkWu2w+jzc+VgRgPjDUF5lfpNGpV1Un1639u hZ1lU957IFf3i0pHHOrSG+Oc+izDB8GWndZIqCtKfLQUU9fuovAQXxREmec197YUiLv3ce/LZ9ur1 UKG9m7Yg==; Received: from [2601:1c2:980:9ec0::2764] by bombadil.infradead.org with esmtpsa (Exim 4.96 #2 (Red Hat Linux)) id 1qQc0p-00HXu0-2W; Mon, 31 Jul 2023 23:09:15 +0000 Message-ID: Date: Mon, 31 Jul 2023 16:09:12 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [PATCH] usb: typec: mux: intel: Add dependency on USB_COMMON Content-Language: en-US To: Heikki Krogerus , Greg Kroah-Hartman Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, Rajat Khandelwal References: <20230731131210.43158-1-heikki.krogerus@linux.intel.com> From: Randy Dunlap In-Reply-To: <20230731131210.43158-1-heikki.krogerus@linux.intel.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-4.5 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 7/31/23 06:12, Heikki Krogerus wrote: > This fixes an undefined reference to `usb_debug_root' issue > when USB_COMMON is not enabled. > > Fixes: 0a453dc9f260 ("usb: typec: intel_pmc_mux: Expose IOM port status to debugfs") > Reported-by: Randy Dunlap > Closes: https://lore.kernel.org/lkml/c3bb8781-676d-2448-cfbb-62e29f1f570b@infradead.org/ > Cc: Rajat Khandelwal > Signed-off-by: Heikki Krogerus Tested-by: Randy Dunlap # build-tested Acked-by: Randy Dunlap Thanks. > --- > drivers/usb/typec/mux/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/usb/typec/mux/Kconfig b/drivers/usb/typec/mux/Kconfig > index 784b9d8107e9b..65da61150ba78 100644 > --- a/drivers/usb/typec/mux/Kconfig > +++ b/drivers/usb/typec/mux/Kconfig > @@ -29,6 +29,7 @@ config TYPEC_MUX_INTEL_PMC > tristate "Intel PMC mux control" > depends on ACPI > depends on INTEL_SCU_IPC > + select USB_COMMON > select USB_ROLE_SWITCH > help > Driver for USB muxes controlled by Intel PMC FW. Intel PMC FW can -- ~Randy