Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 31 Jul 2023 16:40:27 -0700
From:   Mike Kravetz <mike.kravetz@oracle.com>
To:     Kefeng Wang <wangkefeng.wang@huawei.com>
Cc:     Andrew Morton <akpm@linux-foundation.org>,
        Catalin Marinas <catalin.marinas@arm.com>,
        Will Deacon <will@kernel.org>,
        Muchun Song <muchun.song@linux.dev>,
        Mina Almasry <almasrymina@google.com>, kirill@shutemov.name,
        joel@joelfernandes.org, william.kucharski@oracle.com,
        kaleshsingh@google.com, linux-mm@kvack.org,
        linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/4] mm: hugetlb: use flush_hugetlb_tlb_range() in
 move_hugetlb_page_tables()
Message-ID: <20230731234027.GB39768@monkey>
References: <20230731074829.79309-1-wangkefeng.wang@huawei.com>
 <20230731074829.79309-2-wangkefeng.wang@huawei.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230731074829.79309-2-wangkefeng.wang@huawei.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?LYRSJWTCKxrLJ0KyAcvwyopKG9P0xSBRdeNbsy9RSbhZZYqUFPEx4SxDQhBB?=
 =?us-ascii?Q?RrbX8gMa4z/EkdcOxFWEE1FyME3UaVVbiR06VBbA3jBd1mYXDz/I7R/Wx69H?=
 =?us-ascii?Q?0xhROjQ4u1IrF1e7vmOqEmsJ8yb9r40X53qQVypc/T+dHw+tdiNJ9slxC7Qn?=
 =?us-ascii?Q?/37NXvBe3Itf5RfGwewBB2D0H0yh/AkSV4u3SrCGCcSIyfaeE83u9zyiJUc9?=
 =?us-ascii?Q?jJT5c5BWkxw4Rr+n7w8q2dIydfoiy3ZkCB4dBxgaIY+uIIaNdLYHbv7wxM8N?=
 =?us-ascii?Q?Vf9LXTYIb+swISsRlv2TUKDAlsHCut8o4vvMDh4MTHo/e+kWz90Af5W5Y6aD?=
 =?us-ascii?Q?rfRH4w3yefPZYf+98Y7VhdxK/l3oefZV89OPIXtrxEaLPuTxhuYT32xxL0rg?=
 =?us-ascii?Q?qtKuvJzyHVqNSVg3AaSlHw+JGNQEnJf1Wm31lvPNMGa1FXG+Hc4ZRGtXyoaR?=
 =?us-ascii?Q?heZS4ANGgCXoChWslI63I54kdwoHLseA1HuK//rDsRmvwPbzKu1yiBVdw/34?=
 =?us-ascii?Q?L5S4vGWYQn+oLYK2Yeu7npKKqV7bYJ01rSgrwwfqHSoWndkjJQ2NrKvrEADK?=
 =?us-ascii?Q?vJs28lvpW0knOZrR85C4xGC2DBMakeTpffeqRz38EE8oZWav3uG5g96ifzSz?=
 =?us-ascii?Q?Nt06dCyB3v33LpQYeHfzexkVkNGKflzoYa0Pmr1GYUprmdjPoXAkZVeTG6Zb?=
 =?us-ascii?Q?mrVAv/IjN/fNFq8ANb/k3nLVxfViEvoNRlcugYBLMDzhjlMN93JcLkbttnCz?=
 =?us-ascii?Q?+NOO2ghhN5fR8vxPLhcHzBBdxTcgTpgUs8g41JWbhhYzc1qJxhSwYelK1Qd3?=
 =?us-ascii?Q?nUjN7oFFvGwszHBE+lmer5FY2m5Fw8Feul86s+sL+KY2W67uPy/qtDVgQCES?=
 =?us-ascii?Q?GF6U+RLPwHEHC+6/OEgAXcGZd32rc8htBhFmcSV/ZSf3VYJ/XZzd3yrAUgFC?=
 =?us-ascii?Q?4L2dhO96QW1B2UahiDntgbM6zA51wzjKgxEzlqfHNVcTINl3IwcNHqNaFv2L?=
 =?us-ascii?Q?Ub9C+1bh2I9Pc4gsLSRDCa0FFMF97GsP/YZnif5QCwBFXV/g7+rjTbtO2nWt?=
 =?us-ascii?Q?NHzV/OwuJ5JlwI2vYP8OJkHT0khyc4q8PRhtb9+QrKFXZH3lEHdn0J5Ei8hO?=
 =?us-ascii?Q?zoZlyRHuPHoollIntor54WiEU3t4lu21opN/Uz1OYNz9zC9HxtRSO+7TYkt+?=
 =?us-ascii?Q?73Fzf0pZT++3tXKT93fbSHTAQklU2Du0lFkVwUIOCAvRBUv988HPNDhou5dX?=
 =?us-ascii?Q?Nrlr6TQjflJMfeR5FPBGiMoHUQez618obghP3lvEFxMKDp41Y2RAnxwZtgh0?=
 =?us-ascii?Q?WXo7OyA0E3cYWZ7bSM2yfM96CaTfUvesKmr78ziLE7cdHS3NExBTWhLodo6H?=
 =?us-ascii?Q?64GgbUTkQrcMca3k8dSFtP3gKIcp1hZa8emM/ogB7R1MuPitxVcq0qEtRt+U?=
 =?us-ascii?Q?iCbkwK88fCrj8ApZ5MGhLs4Pop3SCza4ix6IygSFvyfy8ODRepfrF4RD8V8x?=
 =?us-ascii?Q?AQ+zqdOjZ7ErJ2+U6UPJ55n/1WxJXKaxtOxv5fRDFwwf++G/n2bATRMFZUaK?=
 =?us-ascii?Q?R3TPHPipoNR+Vw2vAiyJ+3gaK1bScaZfdGziD+LZlaVKc0a+TPmPHk1muo60?=
 =?us-ascii?Q?MA=3D=3D?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: =?us-ascii?Q?GaW9+87hkWDum6NniDfHQrG3fnqJ/v4l9tdW8E6oZab1NQmO6WzVJ6L7nPxd?=
 =?us-ascii?Q?M5I7CaPtXeCewi1MPKc+46UDBuASErmjXIagAP6rvMrJxvUTBTV+JIvJBp6D?=
 =?us-ascii?Q?poriYibCXq6dW9qtIjy3Eq+r1OwRd0ZFEI+H6ykvH4A9crTJ0yatTCe7hfcW?=
 =?us-ascii?Q?/xif4gV25VTAwFgei0qTKSTg9XdjJP23Tu0OCzCK0hNskG8NXESWthDmlpUq?=
 =?us-ascii?Q?K6gdR2B45IN/R3hXXD5S6og3FatMUefivWSsqefhBPcSo0WEKGPHGQrvr9Ad?=
 =?us-ascii?Q?rDLZwuCqSby544YPqF/35Qd0MPMpV4ktxwxC0mHzkwA1KSAQIjqoNql+Wxgv?=
 =?us-ascii?Q?0khKKySHDLLFkLTHTJsUhu2MUtZeXF2e5RZNuBAu3bHx1cd+RZ1yM8/DnJSz?=
 =?us-ascii?Q?UYB4bfMPf5pW+CboBrXvoZ5x4s5aihCSezTt0ePd397vF2rFt7kRHJWTMuRv?=
 =?us-ascii?Q?GzcxR9l+BafMaHLPuOaE4ghS4cKMtW93dP6QS6g9HKIzV1X6X1/X0wokjfaw?=
 =?us-ascii?Q?q9b3R1E89DbpfNoz69zXrbGscKmo7qM+ge59KPmhrq7KQ7xRZggASdQO4Myt?=
 =?us-ascii?Q?EevmeCCHo8vae2IdyyXkrO9BgJNK6x49ZgmbEn0tToeO/Cq7a3mauWLEQaZ2?=
 =?us-ascii?Q?LOXB1DjYik+jbcMsBZ6ndmJ6ppay6Ew1TAy9M1teyLGlxh8EBSf52ksrBjva?=
 =?us-ascii?Q?egU6lg+7ixfzMBqObwGW/am8aCNQI4eCQSrxFZS8xVgBg4/xyX9y/Hm048FW?=
 =?us-ascii?Q?mAyYsFGQyNZOu/OFpEK5miwfWIUeTegPPcrm8Ul7dGDMQruovt9Twi5djas8?=
 =?us-ascii?Q?+ZikmV8DQS0dzwKz6syxhAnBouh0yrM1MUgyk3kWjyTT3AG7ULs0vOWOr12j?=
 =?us-ascii?Q?WWilB8w6KfoUifKLAinprHHirt7nL1XQzLdTIxmjDONGmpqfq/9gweBCuzum?=
 =?us-ascii?Q?Bj1moO49DkecUxcxqpz3GGxq2tH3lPS1bp3AKRovCIO15yspOS0l8OUp6Xxe?=
 =?us-ascii?Q?R3WMR6AVnhjjBUkoqcahFjsCUU/sRKhsFVNwmvV3T07Idzo4eBOyoK6St4iB?=
 =?us-ascii?Q?KLgOY+u8JHsYevUNn/xRng3pegqit+onCdF0dzlW6A7PI7WXo5O5XvbFKKuL?=
 =?us-ascii?Q?75Po2xPzt8TU?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 21c0c2fb-8854-4d11-62ad-08db921f86cb
X-MS-Exchange-CrossTenant-AuthSource: BY5PR10MB4196.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 31 Jul 2023 23:40:30.7703
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: bkG/Cxh5+h6+ZARXqoO1cFLAEc8tmND/YFjAaNI/ELfRKyUsIRiqVtTkUHG4rtFSlIGtP3L5HXbtRM9dZHUMlw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY8PR10MB6756
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.254,Aquarius:18.0.957,Hydra:6.0.591,FMLib:17.11.176.26
 definitions=2023-07-31_16,2023-07-31_02,2023-05-22_02
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 phishscore=0 bulkscore=0 spamscore=0
 mlxlogscore=999 malwarescore=0 adultscore=0 suspectscore=0 mlxscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2306200000
 definitions=main-2307310214
X-Proofpoint-ORIG-GUID: W-gJSwv1kAvgpmxZAGhbAG7J9RcZ6nvF
X-Proofpoint-GUID: W-gJSwv1kAvgpmxZAGhbAG7J9RcZ6nvF
X-Spam-Status: No, score=-3.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H5,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,
        T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 07/31/23 15:48, Kefeng Wang wrote:
> Archs may need to do special things when flushing hugepage tlb,
> so use the more applicable flush_hugetlb_tlb_range() instead of
> flush_tlb_range().
> 
> Fixes: 550a7d60bd5e ("mm, hugepages: add mremap() support for hugepage backed vma")
> Signed-off-by: Kefeng Wang <wangkefeng.wang@huawei.com>

Thanks!

Reviewed-by: Mike Kravetz <mike.kravetz@oracle.com>

Although, I missed this in 550a7d60bd5e :(

Looks like only powerpc provides an arch specific flush_hugetlb_tlb_range
today.
-- 
Mike Kravetz

> ---
>  mm/hugetlb.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/mm/hugetlb.c b/mm/hugetlb.c
> index 64a3239b6407..ac876bfba340 100644
> --- a/mm/hugetlb.c
> +++ b/mm/hugetlb.c
> @@ -5281,9 +5281,9 @@ int move_hugetlb_page_tables(struct vm_area_struct *vma,
>  	}
>  
>  	if (shared_pmd)
> -		flush_tlb_range(vma, range.start, range.end);
> +		flush_hugetlb_tlb_range(vma, range.start, range.end);
>  	else
> -		flush_tlb_range(vma, old_end - len, old_end);
> +		flush_hugetlb_tlb_range(vma, old_end - len, old_end);
>  	mmu_notifier_invalidate_range_end(&range);
>  	i_mmap_unlock_write(mapping);
>  	hugetlb_vma_unlock_write(vma);
> -- 
> 2.41.0
>