Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <71460c5f-2aac-67b0-3779-d748f9e512aa@quicinc.com>
Date:   Mon, 31 Jul 2023 16:46:48 -0700
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH 1/4] soc: qcom: aoss: Move length requirements from caller
Content-Language: en-US
To:     Bjorn Andersson <quic_bjorande@quicinc.com>
CC:     Bjorn Andersson <andersson@kernel.org>,
        Konrad Dybcio <konrad.dybcio@linaro.org>,
        Alex Elder <elder@kernel.org>,
        "David S. Miller" <davem@davemloft.net>,
        Jakub Kicinski <kuba@kernel.org>,
        Mathieu Poirier <mathieu.poirier@linaro.org>,
        <netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
        <linux-arm-msm@vger.kernel.org>, <linux-remoteproc@vger.kernel.org>
References: <20230731041013.2950307-1-quic_bjorande@quicinc.com>
 <20230731041013.2950307-2-quic_bjorande@quicinc.com>
 <e4592feb-3878-b0eb-61e4-fb6dfc358e1a@quicinc.com>
 <20230731231014.GI1428172@hu-bjorande-lv.qualcomm.com>
From:   Chris Lew <quic_clew@quicinc.com>
In-Reply-To: <20230731231014.GI1428172@hu-bjorande-lv.qualcomm.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 7/31/2023 4:10 PM, Bjorn Andersson wrote:
> On Mon, Jul 31, 2023 at 02:29:44PM -0700, Chris Lew wrote:
>>
>>
>> On 7/30/2023 9:10 PM, Bjorn Andersson wrote:
>>> diff --git a/drivers/soc/qcom/qcom_aoss.c b/drivers/soc/qcom/qcom_aoss.c
>>>    	/* The message RAM only implements 32-bit accesses */
>>>    	__iowrite32_copy(qmp->msgram + qmp->offset + sizeof(u32),
>>> -			 data, len / sizeof(u32));
>>> -	writel(len, qmp->msgram + qmp->offset);
>>> +			 buf, sizeof(buf) / sizeof(u32));
>>> +	writel(sizeof(buf), qmp->msgram + qmp->offset);
>>
>> Looks like we are telling the firmware the packet size will always be
>> QMP_MSG_LEN?
>>
>> This should be ok but might be a problem when debugging. The AOSS firmware
>> only logs size of the message instead of the full string because of memory
>> constraints.
>>
> 
> Until now ipa_power_retention() has been passing 36 here, everyone else
> 64, so it is ok.
> 
>> We would normally match the firmware and host logs based on size, but won't
>> be able to differentiate this way with a fixed size.
> 
> I don't mind us changing it to ALIGN(len, 4), but as that would change
> the current behavior I'd like to do so in a subsequent patch.
> 
> Speaking of behavior, is 64 the max message size? We inherited the 64
> from the initial downstream implementation, but qmp->size is quite a bit
> bigger.
> 

The max message size the firmware can handle is 0x64, so 100 bytes, but 
I haven't seen any messages go above 64 bytes.

> Regards,
> Bjorn