Received: by 2002:a05:6358:c692:b0:131:369:b2a3 with SMTP id fe18csp5060828rwb; Mon, 31 Jul 2023 17:44:23 -0700 (PDT) X-Google-Smtp-Source: APBJJlH+cdCXJhnJXgoob/KdeQTvS834CijQEPxS3l+Y3Z/PMdidbwPFNzFNbr8ncxkl5Lzv9/g8 X-Received: by 2002:a17:903:124c:b0:1bb:7927:c1ab with SMTP id u12-20020a170903124c00b001bb7927c1abmr11083923plh.48.1690850662829; Mon, 31 Jul 2023 17:44:22 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1690850662; cv=none; d=google.com; s=arc-20160816; b=U3PPfC9rBnMAKFDDQkmYJAV5VK6NNQ13SN9/jtBP2PXDmw1o551zRCkWeoa52P8pDn UrrWzGmQ+xXMDMIUsNbPuzmB31u13M62+uGiCavx/4YWTlHHOG15FvChQN+/T4fDDMHp HvAsERhPQF58QF1WHuy13RFFWKcIfursh9smtGnYVQTRJL0G3leUcCw71kEvxOrFbc1L wjxHIdYjicyx2XUmH8wtQz8OpZnzXq8gr8Zix5vqjGYamPaLI/liGD3wN5TyTzYk/BM9 JlfvtU/7WDWvntfR2igxJu09LLFIBGjFeEUu9y+z/5yrhZcb3fX0DtBVeBVCvTtb4EHH tAIQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:message-id:subject:cc:to:from:date :dkim-signature; bh=oMvFNBSH98YR96Y1UgC3tI4QIdqPVGbnRBQS4lVnmK8=; fh=Z9BmlOVgjcs1Tvx32nEN8E9UC9ly5kALgCf/3VADaE4=; b=T0+/XZdXl/HYPv2RemFifjf5mEZJfpxGeos80bNAHYDEpoIttb6QiP7yBS30rIA3O5 ovBJvYoe5nFGV4YclCKhwpfu/UWmYaSx1PFYmkPV4MzzygAzA3AcIaHzL7lsE86Vh5TK UwKrohURLPuzHYF6qxo4f662dooelk3zh3AfZ4NQRsXnthCkfQKiKWp+nFjNcVaQUVLH IHAOrjIvNohmx/leWC+gGo1cGZqHMneYswW+d0O8HvTwmgM8MdnVE+Q1IlXWQ+oFSbhX YmzGDmuab2gXN9lG/gUbU+sTVszCgbWJWOQDvcZdASNeyDbI6jJgRt70pZygrnBfINpK ic3w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@canb.auug.org.au header.s=201702 header.b=gooAluXN; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=canb.auug.org.au Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id u5-20020a17090282c500b001bb3499d8besi4578880plz.478.2023.07.31.17.44.10; Mon, 31 Jul 2023 17:44:22 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@canb.auug.org.au header.s=201702 header.b=gooAluXN; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=canb.auug.org.au Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230440AbjHAARP (ORCPT + 99 others); Mon, 31 Jul 2023 20:17:15 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35430 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229661AbjHAARO (ORCPT ); Mon, 31 Jul 2023 20:17:14 -0400 Received: from gandalf.ozlabs.org (gandalf.ozlabs.org [150.107.74.76]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E7087173D; Mon, 31 Jul 2023 17:17:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=canb.auug.org.au; s=201702; t=1690849030; bh=oMvFNBSH98YR96Y1UgC3tI4QIdqPVGbnRBQS4lVnmK8=; h=Date:From:To:Cc:Subject:From; b=gooAluXNE0NE4d1IrtCFx4onVZdMVkan3zpCN8kPtCq1etsbOUKYAVWlWKVzgaSlS fHbit6ZBAVIgloW/9N5P/CqAeoEbWt5fHe5OddJ0q9/a+6VH8CJgQKq/g8u/Pe/PFy iAEweQRYTpXm9avv5jC6WAC1aVTo6MszsOEkkQqT2qI6npP5qZSZ+ED2Mr9jmtbPrz DXv4kj/NV/ID5EVEjvybVliSjJjrOpy1GxecNiza3IPpN82Z87/Kt2Xa5uqW3VPhP8 g5NqK+9igU6Mkimv6asMqVjrXB9Vp0hojboqx8F7vB/PzKJyvlmkLZHi5seBjY+e8c w2XstjARXNI5A== Received: from authenticated.ozlabs.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (prime256v1) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mail.ozlabs.org (Postfix) with ESMTPSA id 4RFFzT6nYXz4wy5; Tue, 1 Aug 2023 10:17:09 +1000 (AEST) Date: Tue, 1 Aug 2023 10:17:08 +1000 From: Stephen Rothwell To: David Miller , Jakub Kicinski , Paolo Abeni , Networking Cc: Linux Kernel Mailing List , Linux Next Mailing List Subject: linux-next: manual merge of the net-next tree with the net tree Message-ID: <20230801101708.1dc7faac@canb.auug.org.au> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="Sig_/+G_pMPqYCr2nKoaTLK9Q1F7"; protocol="application/pgp-signature"; micalg=pgp-sha256 X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,RCVD_IN_DNSWL_BLOCKED,SPF_HELO_PASS,SPF_PASS, T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --Sig_/+G_pMPqYCr2nKoaTLK9Q1F7 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable Hi all, Today's linux-next merge of the net-next tree got a conflict in: drivers/net/ethernet/broadcom/bnxt/bnxt.c between commit: 37b61cda9c16 ("bnxt: don't handle XDP in netpoll") from the net tree and commit: 2b56b3d99241 ("eth: bnxt: handle invalid Tx completions more gracefully") from the net-next tree. I fixed it up (see below) and can carry the fix as necessary. This is now fixed as far as linux-next is concerned, but any non trivial conflicts should be mentioned to your upstream maintainer when your tree is submitted for merging. You may also want to consider cooperating with the maintainer of the conflicting tree to minimise any particularly complex conflicts. --=20 Cheers, Stephen Rothwell idiff --cc drivers/net/ethernet/broadcom/bnxt/bnxt.c index 06b238bef9dd,a3bbd13c070f..000000000000 --- a/drivers/net/ethernet/broadcom/bnxt/bnxt.c +++ b/drivers/net/ethernet/broadcom/bnxt/bnxt.c @@@ -686,10 -744,9 +745,10 @@@ static void bnxt_tx_int(struct bnxt *bp next_tx_int: cons =3D NEXT_TX(cons); =20 - dev_kfree_skb_any(skb); + dev_consume_skb_any(skb); } =20 + bnapi->tx_pkts =3D 0; WRITE_ONCE(txr->tx_cons, cons); =20 __netif_txq_completed_wake(txq, nr_pkts, tx_bytes, @@@ -2571,11 -2595,12 +2597,11 @@@ static int __bnxt_poll_work(struct bnx return rx_pkts; } =20 -static void __bnxt_poll_work_done(struct bnxt *bp, struct bnxt_napi *bnap= i) +static void __bnxt_poll_work_done(struct bnxt *bp, struct bnxt_napi *bnap= i, + int budget) { - if (bnapi->tx_pkts) - if (bnapi->tx_pkts && !bnapi->tx_fault) { - bnapi->tx_int(bp, bnapi, bnapi->tx_pkts); - bnapi->tx_pkts =3D 0; - } ++ if (bnapi->tx_pkts && !bnapi->tx_fault) + bnapi->tx_int(bp, bnapi, budget); =20 if ((bnapi->events & BNXT_RX_EVENT) && !(bnapi->in_reset)) { struct bnxt_rx_ring_info *rxr =3D bnapi->rx_ring; --Sig_/+G_pMPqYCr2nKoaTLK9Q1F7 Content-Type: application/pgp-signature Content-Description: OpenPGP digital signature -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEENIC96giZ81tWdLgKAVBC80lX0GwFAmTITwQACgkQAVBC80lX 0GwP/wgAhR+JXLjo1+DQCJkzFHBJVeJtPEQiJ94Kn92FzNJ9wwPNhNTsySwaKcZp SjcSq6q+MHyv4f2dZ6vLXKw1PByLC1+Qmv3veJ+wPiHXvOQQEWNdtSUOaPslxGpK FcdmWSm+SmH55BbdNzrHb4bobfkU5HHTceJcgokYj7Zwb+R1mKUqBMyJSPU8KlB5 1BMSU5n2hvLiyCJ0w3xnx/V7mREnqxtG/QgBbqH6Av6vO8aj9Dzuk+cdIp3fAiTk xinou48ZkPiZmIHTcdb6/tlQCpjzwqtK4UIqhTGV0w5conBHuTNH+cmN3JS91jw8 GHGzV9vMC8DceBVyMFyoxJtbGj0+mA== =2RXl -----END PGP SIGNATURE----- --Sig_/+G_pMPqYCr2nKoaTLK9Q1F7--