Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <45d450dc-356b-e984-eff5-9f4c698e7ffe@infradead.org>
Date:   Mon, 31 Jul 2023 18:52:41 -0700
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.13.0
Subject: =?UTF-8?Q?Re=3a_=5bPATCH=5d_user=5fnamespace=3a_Remove_unnecessary_?=
 =?UTF-8?B?4oCYTlVMTOKAmSB2YWx1ZXMgZnJvbSBtYXBfd3JpdGU=?=
Content-Language: en-US
To:     Li zeming <zeming@nfschina.com>, paul@paul-moore.com,
        brauner@kernel.org, fred@cloudflare.com, kpsingh@kernel.org
Cc:     linux-kernel@vger.kernel.org
References: <20230801184512.2892-1-zeming@nfschina.com>
From:   Randy Dunlap <rdunlap@infradead.org>
In-Reply-To: <20230801184512.2892-1-zeming@nfschina.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 8/1/23 11:45, Li zeming wrote:

^^^^^^^^^^^^^^^

Please fix your system's date/time.

> kbuf is assigned first, so it does not need to initialize the
> assignment.
> 
> Signed-off-by: Li zeming <zeming@nfschina.com>

Reviewed-by: Randy Dunlap <rdunlap@infradead.org>

Thanks.

> ---
>  kernel/user_namespace.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/kernel/user_namespace.c b/kernel/user_namespace.c
> index 1d8e47bed3f1..6fabf388bb8a 100644
> --- a/kernel/user_namespace.c
> +++ b/kernel/user_namespace.c
> @@ -928,7 +928,7 @@ static ssize_t map_write(struct file *file, const char __user *buf,
>  	struct uid_gid_map new_map;
>  	unsigned idx;
>  	struct uid_gid_extent extent;
> -	char *kbuf = NULL, *pos, *next_line;
> +	char *kbuf, *pos, *next_line;
>  	ssize_t ret;
>  
>  	/* Only allow < page size writes at the beginning of the file */

-- 
~Randy