Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Sherry Sun <sherry.sun@nxp.com>
To:     gregkh@linuxfoundation.org, jirislaby@kernel.org,
        atsushi.nemoto@sord.co.jp, tomonori.sakita@sord.co.jp
Cc:     linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org,
        linux-imx@nxp.com
Subject: [PATCH V2] tty: serial: fsl_lpuart: Clear the error flags by writing 1 for lpuart32 platforms
Date:   Tue,  1 Aug 2023 10:23:04 +0800
Message-Id: <20230801022304.24251-1-sherry.sun@nxp.com>
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?c9n5qS4gV7rWc5QC21lesxHPQsdMlay1kXDwmzakD4RmoXpk4UtOYovDVpD+?=
 =?us-ascii?Q?IeNjyOJjIZGdmECPk+zFwqSUv9nk8LaTH8pdWuJKx/od73ODnyV1t/SAhrOJ?=
 =?us-ascii?Q?UTygE0bwidh7plHdAX7w/1teFpzoHh/gHljrD3jkFzuPflX8+qO4PUqf4uiv?=
 =?us-ascii?Q?CcEASzcTkjplnmCPi75MJ9DgshGSL9EXsKZn/c5OSCbHcndCMqrMzwTg/m9+?=
 =?us-ascii?Q?zloMm+Tkc1Op+QA1WXErxNNE8/0M6q4KxgOw+eVhY3Kzglpmn4QBOIKvUIOA?=
 =?us-ascii?Q?DWgtBx4ZzQ1ZUWN5Rin7EB9b8DqY5JNJA4CHDSFlYGIMtgmuM+fzJK0mKXwE?=
 =?us-ascii?Q?OPjwl/PzPt12s46nFbyYh1I7zqDUlUZ66ZkUCSOPxauR2Z5SAMxBb7NuhM7u?=
 =?us-ascii?Q?5CjqVJOCMuHNmklv3WdzfVwLEhtKbQlaRqMbR1HMTKjiMMctw2JJLWysiC7E?=
 =?us-ascii?Q?UbcKqqQPOYZSgzmer4sZshvYCDCDBzAEboN9ypYXMZA9aMRQtDF9mKcXEDct?=
 =?us-ascii?Q?48KpW6EmtOQbsTunFU/NgEZKUOPgdv6rPjaSgFfpF8f+ZgQN6dKuW7RLziaw?=
 =?us-ascii?Q?lx6rJBysLiEslOMFZsxZ3XtCgvmtRZu9r8zBXTIYUNNX1xPq/u1/fUMq/b/r?=
 =?us-ascii?Q?H1XFWnwLmqu7nn9zKS+GFJyKQlCg2vD0T+4jKl5I1cN4S6NRBy3rD7qmX1V4?=
 =?us-ascii?Q?jaVoBI4MP8ec7BDUFYwQGBUFk+zYIOyAnudePVB1E8sNYKmYLDMbLe7qodvl?=
 =?us-ascii?Q?YS0wM9DVHmUGPdwXT7cRGdcLVP5Yas4BYz/ZsRDESiIHy2ve3LlDU8sYPLKw?=
 =?us-ascii?Q?tgST3FtTOsr28qotgmOz7X1ULwDjzUf4aeCFJW2zLOfcNupDoJGOXsrDDR9M?=
 =?us-ascii?Q?jXCbNLk4vgixIjItueC3jR5Z8jzeifRpWdqal53L9Sbw4Ki5W3Rtmm/QDJ95?=
 =?us-ascii?Q?djwCYWpXpRX3Ur4spH5iw21HfQorp8MgCpyUjDePCY9dvQ+6TgEoY5VEsfPE?=
 =?us-ascii?Q?6lIbmoPdW1uZpiVWp2DtaBG6xg1jZIfBf/nTqQsosEm6pInQk7NYvJg/8Z5W?=
 =?us-ascii?Q?/1bQmF0sS+eTiyfhWxQRcm9LiBavkxADAO3LvI9hvcwERqQ1V86SorzN00MZ?=
 =?us-ascii?Q?hRsZ7aQdHCUd/uJZVx2X8nF836z2TEie/ixcnk9hlEmlWy0Y0wV0HbLFVldN?=
 =?us-ascii?Q?wGQVSmr7wE8TQ4c5/XpgnAg+b1z/JSySe92txUnjPW2sb8joVWDHSpYx2FHN?=
 =?us-ascii?Q?+cM4byrKoch1+ZQQVpjxXeBFiaCp7dIYWdzfi1sPAKQthRAxmSH1fX6EYVfT?=
 =?us-ascii?Q?9hkLkRS2KrUSIze2lY4iAzpfgfmER2SdysT8eg9GxdbfztcWWX4KMFTzRCDM?=
 =?us-ascii?Q?GhhG8HTBvgCcFxJ7KkOpGLk1q7OIBsc2YiY/hwsYZa/SvybP8CjMCNnAKqIK?=
 =?us-ascii?Q?pmsBugrKp+XJmeqDo5fhvpx5PJHclxlkjIpGK0gZvDrTe2j4IMWNaInbQU+W?=
 =?us-ascii?Q?GrFJjkweBDPSkPn2atQhYDDK8PYAp0sLFnDOCsgHf1Q/Vwrqe4iH1NPN7yZI?=
 =?us-ascii?Q?bUh4AtcXPD0j5zGtusYUDIw3tIkL0IWGxqCcafiT?=
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 0467ceb1-d5e3-4bea-cca8-08db923676d7
X-MS-Exchange-CrossTenant-AuthSource: AS8PR04MB8404.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Aug 2023 02:24:42.5922
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: MsyAlycon3DAhZO9PzJYxZBQiCLFNMR+jZfn8JkLo+15+BZ7uHkRP5JG4MMIaBZFzB4ycI9wmhnwqJ5Yu9QJig==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU2PR04MB8856
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_BLOCKED,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE,
        URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Do not read the data register to clear the error flags for lpuart32
platforms, the additional read may cause the receive FIFO underflow
since the DMA has already read the data register.
Actually all lpuart32 platforms support write 1 to clear those error
bits, let's use this method to better clear the error flags.

Fixes: 42b68768e51b ("serial: fsl_lpuart: DMA support for 32-bit variant")
Signed-off-by: Sherry Sun <sherry.sun@nxp.com>
---
Changes in V2:
1. Improve commit message to avoid confusion as commented by Jiri.
---
 drivers/tty/serial/fsl_lpuart.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/tty/serial/fsl_lpuart.c b/drivers/tty/serial/fsl_lpuart.c
index f6644c5989d3..f72e1340b47d 100644
--- a/drivers/tty/serial/fsl_lpuart.c
+++ b/drivers/tty/serial/fsl_lpuart.c
@@ -1120,8 +1120,8 @@ static void lpuart_copy_rx_to_tty(struct lpuart_port *sport)
 		unsigned long sr = lpuart32_read(&sport->port, UARTSTAT);
 
 		if (sr & (UARTSTAT_PE | UARTSTAT_FE)) {
-			/* Read DR to clear the error flags */
-			lpuart32_read(&sport->port, UARTDATA);
+			/* Clear the error flags */
+			lpuart32_write(&sport->port, sr, UARTSTAT);
 
 			if (sr & UARTSTAT_PE)
 				sport->port.icount.parity++;
-- 
2.17.1