Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <e8d9652f-3b81-319a-7ca6-9b656eac6f40@quicinc.com>
Date:   Mon, 31 Jul 2023 18:33:04 -0700
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.9.1
Subject: Re: [PATCH V2] usb: dwc3: gadget: Let pm runtime get/put paired
Content-Language: en-US
To:     Surong Pang <surong.pang@unisoc.com>, <Thinh.Nguyen@synopsys.com>,
        <gregkh@linuxfoundation.org>, <felipe.balbi@linux.intel.com>,
        <linux-usb@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
        <rogerq@kernel.org>
CC:     <Orson.Zhai@unisoc.com>, <Chunyan.Zhang@unisoc.com>,
        <Zhiyong.liu@unisoc.com>, <Surong.Pang@gmail.com>
References: <20230801011548.30232-1-surong.pang@unisoc.com>
From:   Elson Serrao <quic_eserrao@quicinc.com>
In-Reply-To: <20230801011548.30232-1-surong.pang@unisoc.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 7/31/2023 6:15 PM, Surong Pang wrote:
> Pm_runtime_get is called when setting pending_events to true.
> Pm_runtime_put is needed for pairing with pm_runtime_get.
> 
> Fixes: fc8bb91bc83e ("usb: dwc3: implement runtime PM")
> Signed-off-by: Surong Pang <surong.pang@unisoc.com>
> 
> ---
> V2: add Fixes tag, fix Fixes tag
> ---
>   drivers/usb/dwc3/gadget.c | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/usb/dwc3/gadget.c b/drivers/usb/dwc3/gadget.c
> index 5fd067151fbf..9c835c5f9928 100644
> --- a/drivers/usb/dwc3/gadget.c
> +++ b/drivers/usb/dwc3/gadget.c
> @@ -4720,5 +4720,6 @@ void dwc3_gadget_process_pending_events(struct dwc3 *dwc)
>   		dwc3_interrupt(dwc->irq_gadget, dwc->ev_buf);
>   		dwc->pending_events = false;
>   		enable_irq(dwc->irq_gadget);
> +		pm_runtime_put(dwc->dev);
>   	}
>   }

I am already handling this change as part of below series. Will be 
uploading a separate patch based on the feedback from Roger.

https://lore.kernel.org/all/be57511d-2005-a1f5-d5a5-809e71029aec@quicinc.com/

Thanks
Elson