Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <5b92239a-4255-346d-1dfe-c7953535083d@amd.com>
Date:   Mon, 31 Jul 2023 20:10:14 -0500
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.12.0
Subject: Re: [PATCH] Modify the function to et the highest_perf value
Content-Language: en-US
To:     Meng Li <li.meng@amd.com>,
        "Rafael J . Wysocki" <rafael.j.wysocki@intel.com>,
        Huang Rui <ray.huang@amd.com>, linux-pm@vger.kernel.org
Cc:     Shuah Khan <skhan@linuxfoundation.org>,
        linux-kselftest@vger.kernel.org,
        Nathan Fontenot <nathan.fontenot@amd.com>,
        Deepak Sharma <deepak.sharma@amd.com>,
        Alex Deucher <alexander.deucher@amd.com>,
        Shimmer Huang <shimmer.huang@amd.com>,
        Perry Yuan <Perry.Yuan@amd.com>,
        Xiaojian Du <Xiaojian.Du@amd.com>,
        Viresh Kumar <viresh.kumar@linaro.org>,
        Borislav Petkov <bp@alien8.de>, linux-kernel@vger.kernel.org
References: <20230801004719.1298415-1-li.meng@amd.com>
From:   Mario Limonciello <mario.limonciello@amd.com>
In-Reply-To: <20230801004719.1298415-1-li.meng@amd.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?OUFVUitVTklJYTJSK2Y2Y0Y0elFuMTBNL1dCRjF3L1RlSGdlTzcrZ2ZQaEUz?=
 =?utf-8?B?Vm0zOWlUamEzMnhUYXV3MVpFWWdHYjRLZEF0VjlXMVlBVVdyVXJHZitReUhq?=
 =?utf-8?B?VVVlbisyaWZTUUl0VXdBRkpQVzA3bFE1d3JYTXNvQmNHcXo5T1UyL2FrTkw2?=
 =?utf-8?B?S1YxWko4VEQ1R1dZN0NtNDNLVGdEYXIvVkhJN0pVd2ZselpXblJySlZkaitq?=
 =?utf-8?B?VnJ5UjNsaGJkVVVKbzhKbjUrYVJFVFJGRjB3ck9iQ0hOMEhhUEtpWTVvYVl1?=
 =?utf-8?B?SXdSUzJNSytGYkN6eTFFSTNadno0RzE5cTdyMitJWHg4K2c5Sm5FZFM3bTN0?=
 =?utf-8?B?TGdlRUsyOHRYdEhFbDVPWmdadUVmTEo2eEMyWWZGWCsxelZYNVhyUzNOczZC?=
 =?utf-8?B?cC9QU0Z3eHBJeXg2bno3aS9wektQaWFEQUQ5WXUxeHJ0eGFlNGZGdDdCSlR4?=
 =?utf-8?B?dmlBbFNWVW1QcjUvTVgzcUNxbjhiQVpDR092OVU5N0libEJwTlRTeXNYY3pU?=
 =?utf-8?B?dDd3YXB3NnlYT1ozK2hoOWp3bEdUL1pRdnNNYkdYQmNtQ2hQcHlyN2t3Tm1C?=
 =?utf-8?B?RWRPNWpEeTZXbzlLVzMwVWVMaXdCZitQODBmcFVxTHVlYUg0MzNGa2pGY1kx?=
 =?utf-8?B?Skduc0xpSEUzUW0wL3o3WGZ0bERqUFk1WlN1K3cza285c04rQk51TjJxaC9i?=
 =?utf-8?B?QUxHdUEwMll1d2NzcEhpSkZjU240d3czWnphaHFUYlRzNjgxeGE1WDNVbFFN?=
 =?utf-8?B?RVJhTW5VZmUyMUg3Q1lTNFNnK2QyMG1LZ1k1dTFETDZ4c3Y0Tm9JTURmTGpH?=
 =?utf-8?B?NElnSVFJKytZRy9YVytuZXV4OSt4VFBndGZFeW9MdTJlRzViTWFRL01INnVl?=
 =?utf-8?B?SE1rQTZpUktKbUd1cEZsSHBNakJlOVBnNnJVWUZNMXhuRlR3YWhKTFhRYVB1?=
 =?utf-8?B?Q29UOXVQc2xlWTlJY1NNekYyU2FCWU82NmphTSt3SnY5OUhySzFOZGhiTFVZ?=
 =?utf-8?B?RUFqeDBqUzAwT3BuZ0pZRUJ2d2loL2s5WjlwZjdBUXpyWHNqeTBNQUxweDEw?=
 =?utf-8?B?dk5IZzNzUFpTR0ZlQzFKYWZ1MXRndUNBT1ExR1VpY1VRejJFV1QvZWZuN3ZI?=
 =?utf-8?B?aUNEZHk1NzVxL2JWd3JKS2Q5WXhYNjBsL3BVc0JDOE5ISGRlYkU3T2J3YmJi?=
 =?utf-8?B?UUI3SnNsenM1R09XNFVIWUN0RVpXV0xEcG9hZktSUGNVRGVmY1lOQ1ViejZq?=
 =?utf-8?B?TTVVV3ZvazFnb3JHR01MTXR5K2QxdEwyUEhIU1NJc2tGZGZDbnJuVS9xZm15?=
 =?utf-8?B?N1I3ckMxWFBhNXhHVTFKZGdNQ2pGaHU1cDRQUWlIK1lDa2liVGFpV3BuNEZE?=
 =?utf-8?B?S3U5VkUzUGoxakNJaklkZTVRRnV6YUQ3cXhXVm5hQjg2U0d0ZGJmejF3VVhV?=
 =?utf-8?B?MHM5bkZWemE1Nk1xckNNbG5nZmhBSlBtV01oUnRlRm9FOEtmMDJqby9vSXZu?=
 =?utf-8?B?V3BsRjNPdDJGUFRNU1pZdlRCNXFqTzhaOFdpZzA5NjFjdStKVGs0WVRNUTdw?=
 =?utf-8?B?TFlYaVlFZlhSTTE4TUpiSCtPVTRra09GaGNielFlUEVKNlE0R0JyUnBnRnQz?=
 =?utf-8?B?TzdReWlhN0Nja0Q0c09maEJ0YjZzdUUwcUtnditCT1ZiMEYvekREWE80SHBu?=
 =?utf-8?B?azk5Q3RTQ29FRDh1OWo3dG5EWmVycU1iN3pQRmRxd3RpUVlER0wyd2ZJeDRs?=
 =?utf-8?B?cmpMdENYTUpSMTRTeUt1azN3T1F6QjhPS0lkWW5XbkpXZGNHSkxPSTZ0alIz?=
 =?utf-8?B?TDkwUDl1NlVBVDh2eVA4QWlUY1AvaVRXOTM4Mi9Bc1FaSmNKRzFzK04wc2Fn?=
 =?utf-8?B?RTBjM0ZRVEJVOHoyNlV2d01wTVpGYWl4VThvaEh6M0RPS2ZlRkswMDBnOFpl?=
 =?utf-8?B?UTlVMlJubVVXQmdCc2tnZHR0OVZSMm9Idnh5RUR1SytaY1RlZSsrV3k2VDM5?=
 =?utf-8?B?ak9uN0FOSXlTSm85L3pIcnZ5aTlncmlpeThoc2dUVk9XVGxiOFZPSzlWb0py?=
 =?utf-8?B?bm1KTHNiMXlCNlo4RFJtS2poOGVVMGtZSEZhd3EzN2RzYnBxOTdvNFBrQU1L?=
 =?utf-8?B?R1NBemc5QmJFUmpaTUxJUk9MVisvSHZMUWpSZW84MnFIMTZiQVFsZmNVbGJD?=
 =?utf-8?B?bEE9PQ==?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: fad749ea-3935-4a16-692d-08db922c119a
X-MS-Exchange-CrossTenant-AuthSource: MN0PR12MB6101.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Aug 2023 01:10:17.7054
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: lBTNFV+nx8e3BZxWm/hhgtvoc1MvaSmqUVyDNHGlo2JFe5K7hPjkMRUSOocoYyVKPWb5y0lXR+2FhvI99No2UQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW4PR12MB7029
X-Spam-Status: No, score=-0.0 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,NICE_REPLY_A,
        RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE,
        T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=no autolearn_force=no
        version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 7/31/23 19:47, Meng Li wrote:
> The previous function will be deprecated.
> 
> Signed-off-by: Meng Li <li.meng@amd.com>
> ---

This actually has functional impact; doesn't it?  Can you better 
describe the reasoning and expected impact in the commit message?

>   drivers/cpufreq/amd-pstate-ut.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/cpufreq/amd-pstate-ut.c b/drivers/cpufreq/amd-pstate-ut.c
> index 7f3fe2048981..9c889a4a0177 100644
> --- a/drivers/cpufreq/amd-pstate-ut.c
> +++ b/drivers/cpufreq/amd-pstate-ut.c
> @@ -145,8 +145,6 @@ static void amd_pstate_ut_check_perf(u32 index)
>   	struct cpufreq_policy *policy = NULL;
>   	struct amd_cpudata *cpudata = NULL;
>   
> -	highest_perf = amd_get_highest_perf();
> -
>   	for_each_possible_cpu(cpu) {
>   		policy = cpufreq_cpu_get(cpu);
>   		if (!policy)
> @@ -161,6 +159,7 @@ static void amd_pstate_ut_check_perf(u32 index)
>   				return;
>   			}
>   
> +			highest_perf = cppc_perf.highest_perf;
>   			nominal_perf = cppc_perf.nominal_perf;
>   			lowest_nonlinear_perf = cppc_perf.lowest_nonlinear_perf;
>   			lowest_perf = cppc_perf.lowest_perf;
> @@ -172,6 +171,7 @@ static void amd_pstate_ut_check_perf(u32 index)
>   				return;
>   			}
>   
> +			highest_perf = AMD_CPPC_HIGHEST_PERF(cap1);
>   			nominal_perf = AMD_CPPC_NOMINAL_PERF(cap1);
>   			lowest_nonlinear_perf = AMD_CPPC_LOWNONLIN_PERF(cap1);
>   			lowest_perf = AMD_CPPC_LOWEST_PERF(cap1);