Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 1 Aug 2023 09:47:17 +0800
From:   Yan Zhao <yan.y.zhao@intel.com>
To:     Sean Christopherson <seanjc@google.com>
CC:     Paolo Bonzini <pbonzini@redhat.com>,
        Zhenyu Wang <zhenyuw@linux.intel.com>,
        Zhi Wang <zhi.a.wang@intel.com>, <kvm@vger.kernel.org>,
        <intel-gvt-dev@lists.freedesktop.org>,
        <intel-gfx@lists.freedesktop.org>, <linux-kernel@vger.kernel.org>,
        Yongwei Ma <yongwei.ma@intel.com>,
        Ben Gardon <bgardon@google.com>
Subject: Re: [PATCH v4 03/29] drm/i915/gvt: Verify hugepages are contiguous
 in physical address space
Message-ID: <ZMhkJa2/9/aboPju@yzhao56-desk.sh.intel.com>
Reply-To: Yan Zhao <yan.y.zhao@intel.com>
References: <20230729013535.1070024-1-seanjc@google.com>
 <20230729013535.1070024-4-seanjc@google.com>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <20230729013535.1070024-4-seanjc@google.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?23b/OrVYJ/Mins+wsQ7Wzwt9YJgGvGpdcVN6UJv7dsxAakt1sZbybBLJuLDj?=
 =?us-ascii?Q?BUHtI+60vb4+/HOdzsy9OGr7xrcV2S3gBME8lrPkVvMjmbMLnlcbxQCfmSjM?=
 =?us-ascii?Q?EzjO0pl4mNKSxlHE8Pi0jr9TEi7/H5UvH0Z2vgJSRzlQbQUManIGhR7YxoiV?=
 =?us-ascii?Q?EeHaQAgUuG2bySWm8iYLNfFQAtt9THgwNaVmptH0hOVLJYjM4h8qleE1k3Ai?=
 =?us-ascii?Q?R7cOiErxcpju1RdgOlKTtwYc/uAp0vRglZzkA6OfIJindDRMugr7+IIYkCHH?=
 =?us-ascii?Q?ZEi4rPVTWI7It8PMfGU8spWQep5Ukw5FKqArXOxKHLQSWc5LNIaHl1mT5ZO3?=
 =?us-ascii?Q?T/S7UmQjm8dJG3RYK6XEyvN5OwL1GpiU+vP8fQwgIbLyO7nvwhghg/7cwws9?=
 =?us-ascii?Q?xZwQhCWcfDKbdZb5KNRl9qOlWTsXDwYFigec0uwwo3bu2hdSxj7eT+vpUpUl?=
 =?us-ascii?Q?u3ykdc4UtOzKiLlEUud5blpvfWy/MUr2S6Y+KhNVK4imCwwJC+Lc1+jFUM9w?=
 =?us-ascii?Q?PpW2MrbLfcrd0nGcELtFIi5Gj/Uiz7gYw3keGdfL+UFiiMH8HJjOoQyO7ulw?=
 =?us-ascii?Q?wiJ8mOppuZHtEAIO+pSN90BkAJfu8uzxmylzDnklcIGRwA20mTxbYZ22NAul?=
 =?us-ascii?Q?pWKOM1koyGbRnZjaJKNVFm+4hfL2cmVdK5E5arpSQkwfXgK9Z18siRt1wA16?=
 =?us-ascii?Q?9teZzm6AT5vPunfC6GNMV5BMd19fok7kv6YCXeRoxKBAd/VAuJJwYHSlxURK?=
 =?us-ascii?Q?UBJ6KZTggf+34UES+PbWsbcc5LuDN3TWpKxMtFNVTb39wccGM/vmE6cfHMxM?=
 =?us-ascii?Q?YYEimhZypgpla85qSgjzTdfx1VJwAxRa9hypgVbSuQADEij9oG8/6ssHHPNh?=
 =?us-ascii?Q?kDmsVTzoB3AbLl3bltSbTAzNjqN51S/hzzFUh5/3i+yUWFWw+vBg+b0Y3QhF?=
 =?us-ascii?Q?EaRUKxLMDALEiJpFrPFHczV3b1zBM2rEthp3kmDyGaL2JfxpKt2mBTtE8El/?=
 =?us-ascii?Q?oRKuCNraJbxk7le/bPLxtXWoqudz8Bu25aXQzTab0U67ZkdXU4wSZMSxLO1P?=
 =?us-ascii?Q?KX5n7U7WhUMZdTeBQ11BjjxmTj8d4edYFVqEKJY3rQDZ3xjV7aGMRFf6ukvy?=
 =?us-ascii?Q?RcfBcjhwQwqGz6Kx/P1fkluDEH1m68Szw8K34YvMZIuDm7n1yBHEN5UTcGD3?=
 =?us-ascii?Q?f0a+jHpSqNDLtfP1KpQtu03lMJEoXncRV5cz10jHNDC1Agsyo/CdKt77YxRd?=
 =?us-ascii?Q?7gxQdTpVFozhZZ5/McKJn/FmwNnaRden4HFc6Xf2Yh5BAFJG0Bp1v19XTTGm?=
 =?us-ascii?Q?+HkW68IRhosJ2q4CbY0kqtGIC4Twc58hThfzJ+CadGhl641qpVdtk8oghPix?=
 =?us-ascii?Q?6xiwxF/yvBtIUhN7oKEVuyS8lzy+T93aYrL84iUHcwH4WUcBd1d8It8quX27?=
 =?us-ascii?Q?qfOKdvicRoRTHgRaTdj0KYHtSY4irNbf+RUqJ54Q113SnrqT5EhKgdFWLgY3?=
 =?us-ascii?Q?SNCIvRVQBm28bGisQ725DhjOIuALiBB6W0n3rWmOJ1hkMj4fq+1YKhXcDLo0?=
 =?us-ascii?Q?tCOnnitwJ6rvspiywGSzO5UNIeMdMakDY0wJ6xdY?=
X-MS-Exchange-CrossTenant-Network-Message-Id: db333ebf-a3d2-470b-dd87-08db9234fd40
X-MS-Exchange-CrossTenant-AuthSource: DS7PR11MB5966.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Aug 2023 02:14:09.1287
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 4H9Iwdh+QmSGjKzpwvT7xVBTVrFEDZ5qvNwn88XUbuEY3iRJV8QtbRfcuTVu3Z08Kul2ndw/MEXfZZdzr4gVPA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR11MB4536
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,
        RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE,
        URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Reviewed-by: Yan Zhao <yan.y.zhao@intel.com>

On Fri, Jul 28, 2023 at 06:35:09PM -0700, Sean Christopherson wrote:
> When shadowing a GTT entry with a 2M page, verify that the pfns are
> contiguous, not just that the struct page pointers are contiguous.  The
> memory map is virtual contiguous if "CONFIG_FLATMEM=y ||
> CONFIG_SPARSEMEM_VMEMMAP=y", but not for "CONFIG_SPARSEMEM=y &&
> CONFIG_SPARSEMEM_VMEMMAP=n", so theoretically KVMGT could encounter struct
> pages that are virtually contiguous, but not physically contiguous.
> 
> In practice, this flaw is likely a non-issue as it would cause functional
> problems iff a section isn't 2M aligned _and_ is directly adjacent to
> another section with discontiguous pfns.
> 
> Tested-by: Yongwei Ma <yongwei.ma@intel.com>
> Signed-off-by: Sean Christopherson <seanjc@google.com>
> ---
>  drivers/gpu/drm/i915/gvt/kvmgt.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/i915/gvt/kvmgt.c b/drivers/gpu/drm/i915/gvt/kvmgt.c
> index de675d799c7d..429f0f993a13 100644
> --- a/drivers/gpu/drm/i915/gvt/kvmgt.c
> +++ b/drivers/gpu/drm/i915/gvt/kvmgt.c
> @@ -161,7 +161,7 @@ static int gvt_pin_guest_page(struct intel_vgpu *vgpu, unsigned long gfn,
>  
>  		if (npage == 0)
>  			base_page = cur_page;
> -		else if (base_page + npage != cur_page) {
> +		else if (page_to_pfn(base_page) + npage != page_to_pfn(cur_page)) {
>  			gvt_vgpu_err("The pages are not continuous\n");
>  			ret = -EINVAL;
>  			npage++;
> -- 
> 2.41.0.487.g6d72f3e995-goog
>