Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 31 Jul 2023 19:52:58 -0700
From:   Jakub Kicinski <kuba@kernel.org>
To:     Breno Leitao <leitao@debian.org>
Cc:     rdunlap@infradead.org, benjamin.poirier@gmail.com,
        "David S. Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Paolo Abeni <pabeni@redhat.com>, leit@meta.com,
        netdev@vger.kernel.org (open list:NETWORKING DRIVERS),
        linux-kernel@vger.kernel.org (open list)
Subject: Re: [PATCH net-next v2] netconsole: Enable compile time
 configuration
Message-ID: <20230731195258.16b3a53d@kernel.org>
In-Reply-To: <20230731083542.3665886-1-leitao@debian.org>
References: <20230731083542.3665886-1-leitao@debian.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Precedence: bulk

On Mon, 31 Jul 2023 01:35:41 -0700 Breno Leitao wrote:
> +config NETCONSOLE_EXTENDED_LOG
> +	bool "Set kernel extended message as default"
> +	depends on NETCONSOLE
> +	default n
> +	help
> +	  Set extended log support for netconsole message. If this option is
> +	  set, log messages are transmitted with extended metadata header in a
> +	  format similar to /dev/kmsg.  See
> +	  <file:Documentation/networking/netconsole.rst> for details.
> +
> +config NETCONSOLE_PREPEND_RELEASE
> +	bool "Prepend kernel release version in the message"

... by default

> +	depends on NETCONSOLE_EXTENDED_LOG
> +	default n
> +	help
> +	  Set kernel release to be prepended to each netconsole message by
> +	  default. If this option is set, the kernel release is prepended into
> +	  the first field of every netconsole message, so, the netconsole
> +	  server/peer can easily identify what kernel release is logging each
> +	  message.  See <file:Documentation/networking/netconsole.rst> for
> +	  details.

I had to look at the code to see what this does, exactly.

I think you either need to make similar changes to
make_netconsole_target() so that instances created via sysfs
have the same default.

Or rewrite the help message to talk about forcing kernel
command line arguments, rather than setting defaults.
-- 
pw-bot: cr