Received: by 2002:a05:6358:c692:b0:131:369:b2a3 with SMTP id fe18csp5273897rwb; Mon, 31 Jul 2023 22:58:11 -0700 (PDT) X-Google-Smtp-Source: APBJJlEJGjSYj+t40VT1L/B0BkRqzbwm57znYL4ah0krcTq1OzJvi0DQNerwC11vhBibyjZhNAk6 X-Received: by 2002:a05:6a20:644:b0:138:60e:9c4 with SMTP id 4-20020a056a20064400b00138060e09c4mr8101548pzm.23.1690869490635; Mon, 31 Jul 2023 22:58:10 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1690869490; cv=none; d=google.com; s=arc-20160816; b=V8t2YKI9qKsja1LUxdmvCa8NOLLSpoVNflDzuofRvs6FUC1or4oI24fen3MSBxR5XE GcqpoqvsTKUbsX86Yy37ZqHXX/oiF5/vMwHhsiQPuzD3myu+gJvxUdV/HBVWef9F2PBF gbNgwaA3Z6NOloNH9Y5ov/Qov6XGhzxbhEp2tTu2SoKt0zqIGZh5ZcPwefalGLBTyOSA i5yXa6XmKMsH975oVzEN2ljT0yFGiSTRItPZ7NK4MPYIGqKYj7ffkKMFtG9xhJpCcKeQ zKGO3vfmu6YI3OIJHRa+67lXYHSgfnytQcMO2wQcJG3vvKtPz7Vcz1l6S0sFXCyjRd03 8e9g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=A/a/Scufb1Ec+0bCLPm7GEiozsocJOjZ+Xam+rANYgE=; fh=kvYlzIj4XQnwqUd+A3Md2NntKSSF6h3YzC6YE3gG9Iw=; b=AjLWs1AWeI4pt3IlGJF4Q771RGmhGDhzcyx4+hv4seGUZK3Xe1D34+L7bHprW/WyGg WvajqizZAvXCO8PWhO3V2lTk0SubH5Exfh4WrYV3TS86QizFPvcPKIgBktRxHYqAlSFF +ymgv9IlAeM+c9xh/qnzJw3X0iFSMlNdAuvucsqnnB9lgMZs2podr9cwnOg1Bwwtl27O aahAvmIEdH/yGDUESp75pmaiH7oTC/t8s5kE0ThHTaGtuT/9aR2gXtHaMl4raqdF4NxK WpT4HFUn3SPYMAGUCXL3iTCjIEGvApYIFfdu5TdtKG9l7Xlx0tDrJeQAKcsaz3BFRW6F RbTg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=PKAlOzy4; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id m23-20020a638c17000000b005644a9be958si2856584pgd.181.2023.07.31.22.57.58; Mon, 31 Jul 2023 22:58:10 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=PKAlOzy4; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229675AbjHAExf (ORCPT + 99 others); Tue, 1 Aug 2023 00:53:35 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38952 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229459AbjHAExe (ORCPT ); Tue, 1 Aug 2023 00:53:34 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0CCAA10F0; Mon, 31 Jul 2023 21:53:34 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 8891561382; Tue, 1 Aug 2023 04:53:33 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 6A3EEC433C8; Tue, 1 Aug 2023 04:53:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1690865613; bh=2ydpwuL/JD2cVB8xEE9az4qgOh2kfdZ9oeuFCmF97zY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=PKAlOzy426j5pUqqLZl6QH0/dLaSxitrnYm9TDL1lcwPfp/xta5+34yb2BI1bhJRA dPlwjTnnsGbTDGWuGk4U5zbver9RN+q8MoUcFqhdopHT0TDQRGqkbGJPqabzEumZwR 9AZifmS1u7/w+Ymu3zG5jkBNd+9UERK849sb17fQ= Date: Tue, 1 Aug 2023 06:53:30 +0200 From: Greg Kroah-Hartman To: Thadeu Lima de Souza Cascardo Cc: linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org, Jiri Slaby Subject: Re: [PATCH] tty: n_gsm: require CAP_NET_ADMIN to attach N_GSM0710 ldisc Message-ID: <2023080111-lucid-stiffness-ccfa@gregkh> References: <20230731185942.279611-1-cascardo@canonical.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230731185942.279611-1-cascardo@canonical.com> X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF, RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jul 31, 2023 at 03:59:42PM -0300, Thadeu Lima de Souza Cascardo wrote: > Any unprivileged user can attach N_GSM0710 ldisc, but it requires > CAP_NET_ADMIN to create a GSM network anyway. > > Require initial namespace CAP_NET_ADMIN to do that. > > Signed-off-by: Thadeu Lima de Souza Cascardo What commit id does this fix? Or has this always been a problem? thanks, greg k-h