Received: by 2002:a05:6358:c692:b0:131:369:b2a3 with SMTP id fe18csp5372168rwb; Tue, 1 Aug 2023 01:07:11 -0700 (PDT) X-Google-Smtp-Source: APBJJlHGQgEc3IAwUC4O4QLjS9BsA6kybOx6k73wXecDQikENvwXf+Jp/sgODDE3eUVIp6UtzSNp X-Received: by 2002:a17:902:dac2:b0:1b6:69dc:44d2 with SMTP id q2-20020a170902dac200b001b669dc44d2mr15317844plx.51.1690877230718; Tue, 01 Aug 2023 01:07:10 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1690877230; cv=none; d=google.com; s=arc-20160816; b=hB4fh0KFuxyw0EMKktbtb4CylWrrxcQzUylXcp81X1bNmHMk+BKhuR7qRWHy35Jun2 IndDdtROsumXk4jPqQgwS5BUv7J+HVIKYBHiG8HNdFANnUamQVpDabNtq48gD4sBi5s9 cgUhruNUYPU1qN3UYZk93hiEYuf+sNCOSlv2aEF/+w3qTEK5TxKieO4HyvhgzHZ6AFBP 9tT+Hr2OeBNWNN0G0ZEeOSx4t76uE1FOu9OVl4vy5ssPUwa3Ea6Pr8gUj1dC+EAkgKYM w11QqOV2DXb8IvpTqaFeNcO/t1CfAeQO9LAjKvEm0D5Us63PTiPiVRb+/vhlejnnpoTt XXBQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:content-language :in-reply-to:mime-version:user-agent:date:message-id:from:references :cc:to:subject; bh=/zOURbKuaJFSN8+WNnzbMSMvR1p3l5gAyv6rCCxbRUc=; fh=Xm3Nqi4hpOUCkc0rsP9Z01lPKLJmWiVI6suFSDW6mzA=; b=JHznZfs1G9O5oMgl8D/lybfbecq+tK9a+cBns4+JQ7CrBOdWri02PsGBj9BtPHpy5X 4uXLZ2i94ecO+T2cMvMzrtYOx9mYuT929FzkdsHWEZckdNneWHyctsYqXMzs5Q6JREUl 5MD9Teb1UZKG234hp+cwyZQXkwmm41iQsbkvQG5pSushnPICAPHi/fqDtvCCa+E50fYq gIpkUGutubB2IDraxu6CfNPoXYMYY3XT3pmKOhcHQwKc3M98PLGFS+pcFZ4y8vi7XMeA 3Fb/7mRueeVnnsZqexiIlzXzofsckGPCfiAQS/h5zmhsH+r7bc909oBmx/lbrSG5QNI/ wLyQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=huawei.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id ix22-20020a170902f81600b001ab1d1a6802si4775290plb.1.2023.08.01.01.06.58; Tue, 01 Aug 2023 01:07:10 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=huawei.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230400AbjHAHsP (ORCPT + 99 others); Tue, 1 Aug 2023 03:48:15 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53374 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229505AbjHAHsO (ORCPT ); Tue, 1 Aug 2023 03:48:14 -0400 Received: from szxga02-in.huawei.com (szxga02-in.huawei.com [45.249.212.188]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2A033E48; Tue, 1 Aug 2023 00:48:13 -0700 (PDT) Received: from canpemm500002.china.huawei.com (unknown [172.30.72.55]) by szxga02-in.huawei.com (SkyGuard) with ESMTP id 4RFRvw6VZWzNmP2; Tue, 1 Aug 2023 15:44:44 +0800 (CST) Received: from [10.174.151.185] (10.174.151.185) by canpemm500002.china.huawei.com (7.192.104.244) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27; Tue, 1 Aug 2023 15:48:09 +0800 Subject: Re: [PATCH] cgroup: minor cleanup for cgroup_local_stat_show() To: Tejun Heo CC: , , , References: <20230723031932.3152951-1-linmiaohe@huawei.com> <719a19c4-3be5-2260-7349-b3f1bb774f4f@huawei.com> From: Miaohe Lin Message-ID: <3ec1f5d9-4887-4583-a973-92298a9bc924@huawei.com> Date: Tue, 1 Aug 2023 15:48:09 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.6.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.174.151.185] X-ClientProxiedBy: dggems701-chm.china.huawei.com (10.3.19.178) To canpemm500002.china.huawei.com (7.192.104.244) X-CFilter-Loop: Reflected X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,NICE_REPLY_A, RCVD_IN_DNSWL_BLOCKED,RCVD_IN_MSPIKE_H5,RCVD_IN_MSPIKE_WL, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2023/8/1 7:47, Tejun Heo wrote: > On Thu, Jul 27, 2023 at 07:50:11PM +0800, Miaohe Lin wrote: >> On 2023/7/26 9:06, Miaohe Lin wrote: >>> On 2023/7/26 5:53, Tejun Heo wrote: >>>> On Sun, Jul 23, 2023 at 11:19:32AM +0800, Miaohe Lin wrote: >>>>> Make it under CONFIG_CGROUP_SCHED to rid of __maybe_unused annotation. >>>>> Also put cgroup_tryget_css() inside CONFIG_CGROUP_SCHED as it's only >>>>> called when CONFIG_CGROUP_SCHED. No functional change intended. >>>>> >>>>> Signed-off-by: Miaohe Lin >>>> >>>> Patch doesn't apply to cgroup/for-6.6. Can you please respin? >>> >>> Sure. Will resend the patch based on cgroup/for-6.6. >> >> The commit "sched: add throttled time stat for throttled children" is still in the linux-next tree. So I think I have >> to wait for it to be merged into cgroup tree first. > > You can just send the patch against cgroup/for-6.6 branch. We can sort out > the merge conflicts later. Do you mean send the patch against cgroup/for-6.6 branch assuming commit "sched: add throttled time stat for throttled children" has been merged into cgroup/for-6.6 branch? It seems the current code in that branch is fine itself. Thanks for your advice.