Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20230306025308.248987-1-dzm91@hust.edu.cn>
In-Reply-To: <20230306025308.248987-1-dzm91@hust.edu.cn>
From:   Huacai Chen <chenhuacai@kernel.org>
Date:   Tue, 1 Aug 2023 16:15:36 +0800
Message-ID: <CAAhV-H4Nka2SN4LbbAYySWwJD=HULH7vjRaORqV4twkREfgwgA@mail.gmail.com>
Subject: Re: [PATCH v2] drivers: loongson: fix memory leak in loongson2_guts_probe
To:     Dongliang Mu <dzm91@hust.edu.cn>
Cc:     Yinbo Zhu <zhuyinbo@loongson.cn>, loongarch@lists.linux.dev,
        linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

Hi, Dongliang,

Reviewed-by: Huacai Chen <chenhuacai@loongson.cn>
And please resend this patch with title "soc: loongson: fix memory
leak in loongson2_guts_probe()", cc Arnd and soc@kernel.org, because
that is the most appropriate list for this patch.

Huacai

On Mon, Mar 6, 2023 at 10:55=E2=80=AFAM Dongliang Mu <dzm91@hust.edu.cn> wr=
ote:
>
> drivers/soc/loongson/loongson2_guts.c:150 loongson2_guts_probe()
> warn: 'guts->regs' from ioremap() not released on lines: 131,135,139,143.
>
> Fix this by modifying ioremap to devm_ioremap.
>
> Note that, this patch is not tested due to the loongson architecture.
>
> Signed-off-by: Dongliang Mu <dzm91@hust.edu.cn>
> ---
> v1->v2: instead of modifying error handling code, directly change
> ioremap to devm_ioremap.
>  drivers/soc/loongson/loongson2_guts.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/soc/loongson/loongson2_guts.c b/drivers/soc/loongson=
/loongson2_guts.c
> index bace4bc8e03b..a053e3fdae09 100644
> --- a/drivers/soc/loongson/loongson2_guts.c
> +++ b/drivers/soc/loongson/loongson2_guts.c
> @@ -107,7 +107,7 @@ static int loongson2_guts_probe(struct platform_devic=
e *pdev)
>         guts->little_endian =3D of_property_read_bool(np, "little-endian"=
);
>
>         res =3D platform_get_resource(pdev, IORESOURCE_MEM, 0);
> -       guts->regs =3D ioremap(res->start, res->end - res->start + 1);
> +       guts->regs =3D devm_ioremap(dev, res->start, res->end - res->star=
t + 1);
>         if (IS_ERR(guts->regs))
>                 return PTR_ERR(guts->regs);
>
> --
> 2.39.2
>
>