Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
Date:   Tue, 01 Aug 2023 09:14:07 +0200
From:   Michael Walle <michael@walle.cc>
To:     Wadim Mueller <wafgo01@gmail.com>
Cc:     Wadim Mueller <wafgo01@gmail.com>,
        Tudor Ambarus <tudor.ambarus@linaro.org>,
        Pratyush Yadav <pratyush@kernel.org>,
        Miquel Raynal <miquel.raynal@bootlin.com>,
        Richard Weinberger <richard@nod.at>,
        Vignesh Raghavendra <vigneshr@ti.com>,
        linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] SPI-NOR: Add support for Micron mt35x01g
In-Reply-To: <20230728150810.205656-1-wadim.mueller@continental-corporation.com>
References: <20230728150810.205656-1-wadim.mueller@continental-corporation.com>
Message-ID: <7ac5ad977aae9ba124d81588a8521cbc@walle.cc>
Content-Type: text/plain; charset=US-ASCII;
 format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

Hi,

Am 2023-07-28 17:08, schrieb Wadim Mueller:
> From: Wadim Mueller <wafgo01@gmail.com>
> 
> Currently only the mt35xu512aba and mt35xu02g are supported,
> support for the 1G version is missing. This patch adds
> the corresponding entry in the micron_parts structure.
> 
> Verification and tests were done on a custom NXP S32G2 board with the
> mt35xu01g qspi nor populated
> 
> Signed-off-by: Wadim Mueller <wafgo01@gmail.com>
> ---
>  drivers/mtd/spi-nor/micron-st.c | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/drivers/mtd/spi-nor/micron-st.c 
> b/drivers/mtd/spi-nor/micron-st.c
> index 4b919756a205..fe97583547fe 100644
> --- a/drivers/mtd/spi-nor/micron-st.c
> +++ b/drivers/mtd/spi-nor/micron-st.c
> @@ -166,6 +166,11 @@ static const struct flash_info micron_nor_parts[] 
> = {
>  		MFR_FLAGS(USE_FSR)
>  		.fixups = &mt35xu512aba_fixups
>  	},
> +	{ "mt35xu01g", INFO(0x2c5b1b, 0, 128 * 1024, 1024)
> +		NO_SFDP_FLAGS(SECT_4K | SPI_NOR_OCTAL_READ)
> +		FIXUP_FLAGS(SPI_NOR_4B_OPCODES)
> +		MFR_FLAGS(USE_FSR)
> +	},

I guess this flash have SFDP tables. Please dump them according to [1].
If so, please have a look wether this flash works with the generic
driver [2]. No NO_SFDP_FLAGS() with new drivers. also the 4B_OPCODES
should *hopefully* be superfluous due to the 4bait SFDP table.

-michael

[1] https://lore.kernel.org/r/4304e19f3399a0a6e856119d01ccabe0@walle.cc/
[2] 
https://elixir.bootlin.com/linux/v6.4-rc6/source/drivers/mtd/spi-nor/core.c#L2019


>  	{ "mt35xu02g", INFO(0x2c5b1c, 0, 128 * 1024, 2048)
>  		NO_SFDP_FLAGS(SECT_4K | SPI_NOR_OCTAL_READ)
>  		FIXUP_FLAGS(SPI_NOR_4B_OPCODES)