Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Thomas Gleixner <tglx@linutronix.de>
To:     Juergen Gross <jgross@suse.com>,
        LKML <linux-kernel@vger.kernel.org>
Cc:     x86@kernel.org, Andrew Cooper <andrew.cooper3@citrix.com>,
        Tom Lendacky <thomas.lendacky@amd.com>,
        Paolo Bonzini <pbonzini@redhat.com>,
        Wei Liu <wei.liu@kernel.org>,
        Arjan van de Ven <arjan@linux.intel.com>,
        Michael Kelley <mikelley@microsoft.com>,
        Peter Keresztes Schmidt <peter@keresztesschmidt.de>,
        "Peter Zijlstra (Intel)" <peterz@infradead.org>
Subject: Re: [patch V2 50/58] x86/apic: Provide common init infrastructure
In-Reply-To: <3af74b7a-be7f-3fdb-396e-e76b8ca1efaf@suse.com>
References: <20230724131206.500814398@linutronix.de>
 <20230724132047.554355840@linutronix.de>
 <abfa4548-4367-d8fa-f23f-b2ca4a912258@suse.com> <87v8e0nskd.ffs@tglx>
 <b4f0e874-1e35-e523-8e5a-710bc54af52d@suse.com> <87pm48nktc.ffs@tglx>
 <87v8dzl0wm.ffs@tglx> <807ac0ad-b2c4-4a10-a82c-6d95649ae4dc@suse.com>
 <f0d5b71b-4344-2f35-03ee-3af6ebd038b2@suse.com> <87o7jrkyjf.ffs@tglx>
 <3af74b7a-be7f-3fdb-396e-e76b8ca1efaf@suse.com>
Date:   Tue, 01 Aug 2023 10:23:14 +0200
Message-ID: <87il9zkw7h.ffs@tglx>
MIME-Version: 1.0
Content-Type: text/plain
Precedence: bulk

On Tue, Aug 01 2023 at 09:37, Juergen Gross wrote:
> On 01.08.23 09:32, Thomas Gleixner wrote:
>> On Tue, Aug 01 2023 at 09:08, Juergen Gross wrote:
>>> On 01.08.23 08:49, Juergen Gross wrote:
>>>    void __init xen_init_apic(void)
>>>    {
>>>           x86_apic_ops.io_apic_read = xen_io_apic_read;
>>> -       /* On PV guests the APIC CPUID bit is disabled so none of the
>>> -        * routines end up executing. */
>>> -       if (!xen_initial_domain())
>>> -               apic_install_driver(&xen_pv_apic);
>>> -
>>>           x86_platform.apic_post_init = xen_apic_check;
>> 
>> I don't think this one is needed.
>
> Indeed.

Can you send a real patch please which I can add to that pile at the
right place?

Thanks,

        tglx