Date: Tue, 30 Oct 2007 10:05:42 +0000
From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: Robert Hancock <hancockr@shaw.ca>
Cc: linux-kernel <linux-kernel@vger.kernel.org>,
       ide <linux-ide@vger.kernel.org>
Subject: Re: sata_nv and dynamically changing DMA mask?
Message-ID: <20071030100542.3efe01ee@the-village.bc.nu>
In-Reply-To: <4726B064.3000906@shaw.ca>
References: <4726B064.3000906@shaw.ca>
Organization: Red Hat UK Cyf., Amberley Place, 107-111 Peascod Street,
 Windsor, Berkshire, SL4 1TE, Y Deyrnas Gyfunol. Cofrestrwyd yng Nghymru a
 Lloegr o'r rhif cofrestru 3798903
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1221
Lines: 26

On Mon, 29 Oct 2007 22:17:40 -0600
Robert Hancock <hancockr@shaw.ca> wrote:

> In the sata_nv driver, when running in ADMA mode, we can do 64-bit DMA. 
> However, when an ATAPI device like a DVD drive is connected, we can't 
> use ADMA mode, and so we have to abide by the restrictions of a normal 
> SFF ATA controller and can only do 32-bit DMA. We detect this and try to 
> set the blk_queue_bounce_limit, blk_queue_segment_boundary and 
> blk_queue_max_hw_segments to the values corresponding to a normal SFF 
> controller.

What about the DMA padding buffer from nv_adma_port_start and internal
buffers for commands like request sense that don't come via the request
queue directly.

Also it seems nv_adma_use_reg_mode() can decide to send other commands
via the non ADMA interface even for ATA devices. Are we 100% certain it
never decides to let through a command with DMA via the register
interface in this case - what do you see if you instrument the function ?

Alan
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/