Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Jani Nikula <jani.nikula@linux.intel.com>
To:     Ran Sun <sunran001@208suo.com>, alexander.deucher@amd.com,
        airlied@gmail.com, daniel@ffwll.ch
Cc:     Ran Sun <sunran001@208suo.com>, dri-devel@lists.freedesktop.org,
        amd-gfx@lists.freedesktop.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] drm/amd: Clean up errors in processpptables.c
In-Reply-To: <20230801091425.7181-1-sunran001@208suo.com>
Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo
References: <20230801091425.7181-1-sunran001@208suo.com>
Date:   Tue, 01 Aug 2023 12:36:47 +0300
Message-ID: <87leevw1cg.fsf@intel.com>
MIME-Version: 1.0
Content-Type: text/plain
Precedence: bulk

On Tue, 01 Aug 2023, Ran Sun <sunran001@208suo.com> wrote:
> Fix the following errors reported by checkpatch:
>
> ERROR: open brace '{' following function definitions go on the next line
> ERROR: code indent should use tabs where possible
> ERROR: space required before the open parenthesis '('

The commit message does not match the patch.

>
> Signed-off-by: Ran Sun <sunran001@208suo.com>
> ---
>  drivers/gpu/drm/amd/pm/powerplay/hwmgr/processpptables.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/pm/powerplay/hwmgr/processpptables.c b/drivers/gpu/drm/amd/pm/powerplay/hwmgr/processpptables.c
> index 1866fe20f9e2..f05f011c78be 100644
> --- a/drivers/gpu/drm/amd/pm/powerplay/hwmgr/processpptables.c
> +++ b/drivers/gpu/drm/amd/pm/powerplay/hwmgr/processpptables.c
> @@ -676,7 +676,7 @@ static PP_StateClassificationFlags make_classification_flags(
>  static int init_non_clock_fields(struct pp_hwmgr *hwmgr,
>  						struct pp_power_state *ps,
>  							    uint8_t version,
> -			 const ATOM_PPLIB_NONCLOCK_INFO *pnon_clock_info) 
> +			 const ATOM_PPLIB_NONCLOCK_INFO *pnon_clock_info)

How about fixing *all* the style problems in the above in one go?

How about sending these fixes in a threaded series instead of filling
everyone's inboxes with individual patches? It's 30+ patches just today
already.


BR,
Jani.

>  {
>  	unsigned long rrr_index;
>  	unsigned long tmp;

-- 
Jani Nikula, Intel Open Source Graphics Center