Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <9912df2897bed863ad541807354d49db95970668.camel@redhat.com>
Subject: Re: [PATCH v3 1/2] net: phy: at803x: fix the wol setting functions
From:   Paolo Abeni <pabeni@redhat.com>
To:     Leo Li <leoyang.li@nxp.com>, Andrew Lunn <andrew@lunn.ch>,
        Luo Jie <quic_luoj@quicinc.com>
Cc:     Heiner Kallweit <hkallweit1@gmail.com>,
        Russell King <linux@armlinux.org.uk>,
        "David S . Miller" <davem@davemloft.net>,
        Jakub Kicinski <kuba@kernel.org>,
        David Bauer <mail@david-bauer.net>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Viorel Suman <viorel.suman@nxp.com>,
        Wei Fang <wei.fang@nxp.com>
Date:   Tue, 01 Aug 2023 11:16:24 +0200
In-Reply-To: <AM0PR04MB6289323F6F93E197103A225D8F05A@AM0PR04MB6289.eurprd04.prod.outlook.com>
References: <20230728215320.31801-1-leoyang.li@nxp.com>
         <20230728215320.31801-2-leoyang.li@nxp.com>
         <8071d8c5-1da3-47a0-9da2-a64ee80db6e5@lunn.ch>
         <AM0PR04MB6289323F6F93E197103A225D8F05A@AM0PR04MB6289.eurprd04.prod.outlook.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.46.4 (3.46.4-1.fc37) 
MIME-Version: 1.0
Precedence: bulk

On Mon, 2023-07-31 at 14:58 +0000, Leo Li wrote:
> > -----Original Message-----
> > From: Andrew Lunn <andrew@lunn.ch>
> > Sent: Saturday, July 29, 2023 3:14 AM
> > To: Leo Li <leoyang.li@nxp.com>
> > Cc: Heiner Kallweit <hkallweit1@gmail.com>; Russell King
> > <linux@armlinux.org.uk>; David S . Miller <davem@davemloft.net>; Jakub
> > Kicinski <kuba@kernel.org>; David Bauer <mail@david-bauer.net>;
> > netdev@vger.kernel.org; linux-kernel@vger.kernel.org; Viorel Suman
> > <viorel.suman@nxp.com>; Wei Fang <wei.fang@nxp.com>
> > Subject: Re: [PATCH v3 1/2] net: phy: at803x: fix the wol setting funct=
ions
> >=20
> > On Fri, Jul 28, 2023 at 04:53:19PM -0500, Li Yang wrote:
> > > In commit 7beecaf7d507 ("net: phy: at803x: improve the WOL feature"),
> > > it seems not correct to use a wol_en bit in a 1588 Control Register
> > > which is only available on AR8031/AR8033(share the same phy_id) to
> > > determine if WoL is enabled.  Change it back to use
> > > AT803X_INTR_ENABLE_WOL for determining the WoL status which is
> > > applicable on all chips supporting wol. Also update the
> > > at803x_set_wol() function to only update the 1588 register on chips h=
aving
> > it.
> >=20
> > Do chips which do not have the 1588 register not have WoL? Or WoL
> > hardware is always enabled, but you still need to enable the interrupt.
>=20
> Some of them do and some don't, which is removed in the other patch
> from the series.  Since I don't find the register to enable it, I
> guess it always enabled.
>=20
> >=20
> > Have you tested on a range of PHY? It might be better to split this pat=
ch up a
> > bit. If it causes regressions, having smaller patches can make it easie=
r to find
> > which change broken it.
>=20
> No, I only have AR8035 to test with.  Changes for other chips are
> according to the datasheet.  It would be good if others having the
> hardware can test it too.

Adding Luo Jie for awareness.

@Luo Jie: do you have access to other chips handled by this driver
other then AR8035? could you please test this series:

https://patchwork.kernel.org/project/netdevbpf/list/?series=3D770734

?

Thanks!

Paolo