Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Mime-Version: 1.0
Subject: Re: [PATCH] scsi: ufs: ufs-pci: Add support for QEMU
Reply-To: jeuk20.kim@samsung.com
Sender: Jeuk Kim <jeuk20.kim@samsung.com>
From:   Jeuk Kim <jeuk20.kim@samsung.com>
To:     Adrian Hunter <adrian.hunter@intel.com>
CC:     "jejb@linux.ibm.com" <jejb@linux.ibm.com>,
        "martin.petersen@oracle.com" <martin.petersen@oracle.com>,
        "bvanassche@acm.org" <bvanassche@acm.org>,
        "avri.altman@wdc.com" <avri.altman@wdc.com>,
        "dlunev@chromium.org" <dlunev@chromium.org>,
        "linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
In-Reply-To: <48f05875-5255-70d2-0737-36fa95470037@intel.com>
Message-ID: <20230801092000epcms2p44c99d2c15bc6169e38693cb64cf946db@epcms2p4>
Date:   Tue, 01 Aug 2023 18:20:00 +0900
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset="utf-8"
CMS-TYPE: 102P
DLP-Filter: Pass
References: <48f05875-5255-70d2-0737-36fa95470037@intel.com>
        <20230801073750epcms2p121c08e452aaafdda301c5562f4ccff5b@epcms2p1>
        <CGME20230801073750epcms2p121c08e452aaafdda301c5562f4ccff5b@epcms2p4>
Precedence: bulk

On 1/08/23, Adrian Hunter wrote:
> On 1/08/23 10:37, Jeuk Kim wrote:
> > Add PCI ID to support QEMU ufs.
> >=20
> > The new qemu ufs device can be found at
> > https://lore.kernel.org/qemu-devel/20230727155239.GA979354=40fedora
>=20
> Please say something about why a UFS device is being virtualized
> and what features it is expected to support.

Hi Adrian=21

UFS device emulation feature has been newly added to QEMU recently.
Currently, QEMU UFS supports basic io and query request features,
and plans to add more features in the future.

With the addition of the QEMU ufs device emulation feature,=20
QEMU UFS decided to use the pci device id of 0x0013 in the REDHAT vendor id=
 (0x1b36).

However, this information is not registered in the linux ufs driver,=20
so the current linux kernel does not recognize the QEMU UFS device.=20
Therefore, I want to register the QEMU ufs pci id through this patch.

Do I need to add the above content to the commit message?

Thanks,
Jeuk

> >=20
> > Signed-off-by: Jeuk Kim <jeuk20.kim=40samsung.com>
> > ---
> >=C2=A0=20drivers/ufs/host/ufshcd-pci.c=20=7C=201=20+=0D=0A>=20>=C2=A0=20=
1=20file=20changed,=201=20insertion(+)=0D=0A>=20>=20=0D=0A>=20>=20diff=20--=
git=20a/drivers/ufs/host/ufshcd-pci.c=20b/drivers/ufs/host/ufshcd-pci.c=0D=
=0A>=20>=20index=20cf3987773051..29d322931427=20100644=0D=0A>=20>=20---=20a=
/drivers/ufs/host/ufshcd-pci.c=0D=0A>=20>=20+++=20b/drivers/ufs/host/ufshcd=
-pci.c=0D=0A>=20>=20=40=40=20-590,6=20+590,7=20=40=40=20static=20const=20st=
ruct=20dev_pm_ops=20ufshcd_pci_pm_ops=20=3D=20=7B=0D=0A>=20>=C2=A0=20=7D;=
=0D=0A>=20>=C2=A0=20=0D=0A>=20>=C2=A0=20static=20const=20struct=20pci_devic=
e_id=20ufshcd_pci_tbl=5B=5D=20=3D=20=7B=0D=0A>=20>=20+=20=C2=A0=20=C2=A0=20=
=C2=A0=20=C2=A0=7B=20PCI_VENDOR_ID_REDHAT,=200x0013,=20PCI_ANY_ID,=20PCI_AN=
Y_ID,=200,=200,=200=20=7D,=0D=0A>=20>=C2=A0=20=20=C2=A0=20=C2=A0=20=C2=A0=
=20=C2=A0=7B=20PCI_VENDOR_ID_SAMSUNG,=200xC00C,=20PCI_ANY_ID,=20PCI_ANY_ID,=
=200,=200,=200=20=7D,=0D=0A>=20>=C2=A0=20=20=C2=A0=20=C2=A0=20=C2=A0=20=C2=
=A0=7B=20PCI_VDEVICE(INTEL,=200x9DFA),=20(kernel_ulong_t)&ufs_intel_cnl_hba=
_vops=20=7D,=0D=0A>=20>=C2=A0=20=20=C2=A0=20=C2=A0=20=C2=A0=20=C2=A0=7B=20P=
CI_VDEVICE(INTEL,=200x4B41),=20(kernel_ulong_t)&ufs_intel_ehl_hba_vops=20=
=7D,