Received: by 2002:a05:6358:c692:b0:131:369:b2a3 with SMTP id fe18csp5475938rwb; Tue, 1 Aug 2023 03:18:12 -0700 (PDT) X-Google-Smtp-Source: APBJJlFVEEGRlCLIFN0TDIyjoyIMPP2MhpYLulBKjH3c0eo7Y0dLlTYnyfW4y+aF044nFJRaJDmB X-Received: by 2002:a17:90b:3b89:b0:267:f157:e830 with SMTP id pc9-20020a17090b3b8900b00267f157e830mr10845430pjb.3.1690885091762; Tue, 01 Aug 2023 03:18:11 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1690885091; cv=none; d=google.com; s=arc-20160816; b=vEeh6aT92Fn54PG9zPNdD80SHUND7QPDs2Me7KdOW2AhKrfoCKMGSKgRQx+FlVFLQC lD/85wn0Idp3e6SiTErq2aGQCcyGnfFu0rfAjppqVRmude3pDVM0nZ1aAvUkrPLDhkET +RBBVYuXapHcutPP6D02SbV55BLgYo1DBsCW30/x8R9ks5vitYEP9NIGWSj3SfWgBw3e Nc8+g0nhQ59Opq82W0/d2U6hsxIbMnXlAwSk3GAq47w6bKzbjJonTATnA+13/ujPrAsy VuRoshA7iD9LqG8+dK0moO2PbOyNp6nrJPZ3MVgoDAjKQo9bGmc1/AHizSDiH902E+Fl NTOg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=4mbju1g6RNmlbP/1/oylEMdzcfQdrO1pUJukrXW1CBI=; fh=u5USNaHO4dqQSGHgaAwRuPmXzitTZs97zzxHNuywu58=; b=RKeg1LsTeS2J4usWOKpr0b0lEJ9Ox4N8tgOlSaNwlTmg7JGhbbojBiWodM5HhUCYiU UHtKrP+6HEtJEbNX9kVQQfHTNsgwK9QAlWVL2WgKFPYaP5pbLDaBmUW9alOCCY2J2MO3 jBh4R5KzJcdhXRvvy5ZudxE+RN49SCfF49Qd48PhuvJnNUW2zbS/XooVOWPeewMif9yc KOSp3Hk7lFg2PX2yLlw0Lrlfs3/wkRKsJZlQfCcPsxp6rvrlN2sCo3ZH5075pAATzblS qbFVVRoXdUCwytMjydtaWz0lWiZbsTKxkqOPegex52fyajj4IFE8F1IBVvV9HNPqpgO1 9qcw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@lunn.ch header.s=20171124 header.b=n39m5J39; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=lunn.ch Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id m6-20020a17090a7f8600b0025027e0ad3dsi1003401pjl.81.2023.08.01.03.17.59; Tue, 01 Aug 2023 03:18:11 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@lunn.ch header.s=20171124 header.b=n39m5J39; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=lunn.ch Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233765AbjHAJ5N (ORCPT + 99 others); Tue, 1 Aug 2023 05:57:13 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55352 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233775AbjHAJ4s (ORCPT ); Tue, 1 Aug 2023 05:56:48 -0400 Received: from vps0.lunn.ch (vps0.lunn.ch [156.67.10.101]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 799071BD3; Tue, 1 Aug 2023 02:56:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Disposition:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:From:Sender:Reply-To:Subject: Date:Message-ID:To:Cc:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:Content-Disposition:In-Reply-To:References; bh=4mbju1g6RNmlbP/1/oylEMdzcfQdrO1pUJukrXW1CBI=; b=n39m5J39r5h8mIoSEvn5mrzHok etwHc2WZci3TX7mlDVDDDRVqKbzNq8cKrWdEoEWv3ZoMNGC83J3+VIa5CmdJvGBOTUQwuZId1C9Oy BUZSTXFyiWkhpeUzHPRRtRQIr0bOKU9T2Xbct0M9o3oBCYsxEVt8ylgKA0xEZL6PFA3A=; Received: from andrew by vps0.lunn.ch with local (Exim 4.94.2) (envelope-from ) id 1qQm6u-002mlq-Vo; Tue, 01 Aug 2023 11:56:12 +0200 Date: Tue, 1 Aug 2023 11:56:12 +0200 From: Andrew Lunn To: Herve Codina Cc: "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Lee Jones , Linus Walleij , Qiang Zhao , Li Yang , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , Shengjiu Wang , Xiubo Li , Fabio Estevam , Nicolin Chen , Christophe Leroy , Randy Dunlap , netdev@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, linux-arm-kernel@lists.infradead.org, alsa-devel@alsa-project.org, Thomas Petazzoni Subject: Re: [PATCH v2 20/28] net: wan: Add framer framework support Message-ID: <84d6431f-bb55-4224-a4a5-45d7036f1e38@lunn.ch> References: <20230726150225.483464-1-herve.codina@bootlin.com> <20230726150225.483464-21-herve.codina@bootlin.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230726150225.483464-21-herve.codina@bootlin.com> X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_BLOCKED, SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > +int framer_pm_runtime_get(struct framer *framer) > +{ > + int ret; > + > + if (!framer) > + return 0; Can framer be a NULL pointer? This sort of test often covers up bugs. So either let it dereference the NULL pointer and opps, or return -EINVAL. Andrew