Received: by 2002:a05:6358:c692:b0:131:369:b2a3 with SMTP id fe18csp5476856rwb; Tue, 1 Aug 2023 03:19:23 -0700 (PDT) X-Google-Smtp-Source: APBJJlFjEyymr0Y/cqJoMcn8CqDujzgqcbNP+66iARgj8nEgjJHOa25Tu2RedLSY9Nl/lrorsor9 X-Received: by 2002:a17:90b:4a8b:b0:260:e256:27c7 with SMTP id lp11-20020a17090b4a8b00b00260e25627c7mr10918295pjb.15.1690885163534; Tue, 01 Aug 2023 03:19:23 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1690885163; cv=none; d=google.com; s=arc-20160816; b=1HTYMNWbMacO61EsYVrhwRDv1vpHSObwK7Xt4bquj6NlwLBuq+xCLDfo5aeuHb2Rnz TnlF02fKO8uXk2oy00k/UKxlEuqOKO4dcIvgI+hqAEnW5XO46hhLfm2doFTlR33+y4rK vF6UYsCMw+lKa5MJIgpnmEUM24uaCcfg/tGuyhans8ZJ7oh17Xxvzu7sTPOOu1vFWVvc R3hfWAAhT7Ukwh5PM7l6uUTELS85bAAzR2zvbtfHFWUZA82T1hTwTALmD2dZUrDJe5mT eW6PYxdBTTJiCysvSAArOUPuCO0lzTdv6YVxZkjmIKNrWUsS21ZV/0HdoJfVMNdyhKAv cVxg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=x9ud0kJIKSz0c5rqx+N73RMdkYZt2ON9qyYVjEU+GW0=; fh=e/N/Y+FzOjx8hoC22WlSu6q+Ijg2y2Ianyph0X0GL08=; b=sW5NhfPFVkbhGQcOI7KKcRGjQRXKja0r1BKEd5ZlddEz/byH1fYY8ZfXCrJKoPM4LA ay8RlnTHCN9cQR9195N1hDcOsmLBFJb2IPWDWt372lEFrEohCrWTWZj/5IzTU/wMSi67 UvbMDVhBjNEeocKBwPj3r7tGJPS4ME0T/j7O83lJTkGhVF8WgOWMpJSfO6fyMFUIL5GB q7I8Agij7BuCLsM1yIAvewSdkdijCsK3dYiaubEKKW54NxsQnYwsSFHS4ZNokHcQ+7il U0s5V+gYfRyqJGa/n6b85Uu/MF37cSVY98JhHe53uQKzYwUUHkw7LAwrMkPAgXbkjNLe 2rKw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=srFyPeIp; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id t12-20020a17090abc4c00b00262d819d895si10501507pjv.86.2023.08.01.03.19.11; Tue, 01 Aug 2023 03:19:23 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=srFyPeIp; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232244AbjHAKGW (ORCPT + 99 others); Tue, 1 Aug 2023 06:06:22 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60964 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232120AbjHAKGN (ORCPT ); Tue, 1 Aug 2023 06:06:13 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C2F9DBE for ; Tue, 1 Aug 2023 03:06:12 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 4ABE961505 for ; Tue, 1 Aug 2023 10:06:12 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id D1D42C433C8; Tue, 1 Aug 2023 10:06:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1690884371; bh=q4WMkjTaZT940k8v/3UokpHQEL5OOBvQGiMemA8FEks=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=srFyPeIpWbFw81W51LGBRhTrfwfFVdrDW4ErDSObjj1u3MwvKP/aRucJQKqz9i/3z EoxUyyHIPf8rfbkDlZetklatXWufSIKR2VfnmJrBA7ZZV6SA57oi0hPeuMjzq6+T3S LCsM0HqxqCnWW04EtzEULH+xuc3W6LNP6T79g+Ak7UStuvxlP/VdCso5PUu9xoFA/V +4R/h1B0+o+LGv5l8gIZw1O5Xu58IIpVTJrHWcJVG6iZHPNtO/z2+TNtJc7PTutVQ5 o/o1fQSQTATnf+82xNWNU9oICKBHVyIOc6JkL1lJhKxuN0GVrpJRa1TZ+tBRRQaBNv YLsWn7tNktHag== Date: Tue, 1 Aug 2023 12:06:07 +0200 From: Simon Horman To: Yang Li Cc: madalin.bucur@nxp.com, davem@davemloft.net, kuba@kernel.org, edumazet@google.com, sean.anderson@seco.com, pabeni@redhat.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Abaci Robot Subject: Re: [PATCH net-next] net: Remove duplicated include in mac.c Message-ID: References: <20230801005041.74111-1-yang.lee@linux.alibaba.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230801005041.74111-1-yang.lee@linux.alibaba.com> X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF, RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Aug 01, 2023 at 08:50:41AM +0800, Yang Li wrote: > ./drivers/net/ethernet/freescale/fman/mac.c: linux/of_platform.h is included more than once. > > Reported-by: Abaci Robot > Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=6039 > Signed-off-by: Yang Li Looking at git history, I think that a slightly better prefix would be 'net: fman: '. Subject: [PATCH net-next] net: fman: ... But other than that, this looks good to me. Reviewed-by: Simon Horman