Received: by 2002:a05:6358:c692:b0:131:369:b2a3 with SMTP id fe18csp5532668rwb; Tue, 1 Aug 2023 04:19:46 -0700 (PDT) X-Google-Smtp-Source: APBJJlEpFVffyeRY5u3XD8yWaRucFrnR26TpbtyzVz228Rw7cBZlHbZvIKrgdgXt6QlH85FUXYGk X-Received: by 2002:a05:6a00:240e:b0:667:85e6:4d1 with SMTP id z14-20020a056a00240e00b0066785e604d1mr16120197pfh.33.1690888786083; Tue, 01 Aug 2023 04:19:46 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1690888786; cv=none; d=google.com; s=arc-20160816; b=IzkZncLKfsQ46+wgEiIA2Gxp33vyjFQ8NM7dK12x/m0UN1seOkX5KVcKUuyMPNpYRE U0BosHX/yzTxy7IhPaO2yTo5FWyHG3SmrK8z+1U/P0fLdBeFHwMjSB1EPuAVXVHQ1Pc4 bod3v3IHsAW+eI2D1BfADwXOJtW/3jl37vCaVoi6SRfDJOQiYheamNsO6fSIU9x0apg6 VbdOfqr0QlPtO5ZJ+QGnFHXvAKICsw5xL/eCiE33z1m075IQcwTnCmVz47lvh5P0ZU2Q zjLLJtchyINHexuKWyNapn+fbuzgF4tGJV6Hzhpa8fWbe+LJwdmx0YunGyozwjB8UyUV xx/Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=8CQkOodeAX2v+3iqUQV0g8XdgU4PFpg9fwufh1/EOFo=; fh=GNMyAXaASOh8zR0htPc5emVtnzVqkDVpYnpcN/jqZFM=; b=PG2ZS2f4q4tmRXqtvv8MaTPLnfUz8QuDZ9YwwsrSHNigdy7+9gt1LchURkXy8bygRL mcrdlZKerCQDqHhw4HmY8xlodkRx5G5wVeIZyQUld/2UNat8ow93M8bHnfjB/eEyjoL3 1OKOBVL0iAvHTHOAqP18Sv2eRuDE/dOfqwas0updZu3LrjNT/0C7hzd2G2KVhsdarVy7 Zm/uaSs3Hvex4O1HFskz6mzlAx72Go5Xd1W+Jaq6CWJ1RAzrlCtS8d2Jm1VIoCeQ4YjU SXzY+k7NGfzYyBez/oNyQXn84xdL1XeBm2xNQ3aqfCnwbjFo//GuC1X9XdLcypW8QZxU seQA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@tq-group.com header.s=key1 header.b=OZptjQ+t; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=tq-group.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id fi35-20020a056a0039a300b00686e7b259fcsi9153670pfb.184.2023.08.01.04.19.34; Tue, 01 Aug 2023 04:19:46 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@tq-group.com header.s=key1 header.b=OZptjQ+t; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=tq-group.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232075AbjHAKga (ORCPT + 99 others); Tue, 1 Aug 2023 06:36:30 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52446 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230312AbjHAKg2 (ORCPT ); Tue, 1 Aug 2023 06:36:28 -0400 Received: from mx1.tq-group.com (mx1.tq-group.com [93.104.207.81]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BAB2FA1; Tue, 1 Aug 2023 03:36:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tq-group.com; i=@tq-group.com; q=dns/txt; s=key1; t=1690886187; x=1722422187; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=8CQkOodeAX2v+3iqUQV0g8XdgU4PFpg9fwufh1/EOFo=; b=OZptjQ+t8XbduEcEIRtci9QdmTj4v3+30Nscp6kh3oKKKtGEAMo4/Pbf JfwyJjdDD5rXIq4YoxpYf8XeB7dLjJUEwZVV1i3iOuR7ZVfimNYouIpBz PYgL91WJ5uGs8l2Ea7pc3xfRlVtDB1mhkdQJv0qhqAvKRBk1b+bEymbMR CRpFHrSGiIWMD/rXr2bXE+itYKouoZyme7GExPaL+lqdplKHRFqAnY9kt k0kdOdVyPSCv6l74ooa985o1g/lKjAg/wP5N09coOD42+bFxqrB+geAVD HftOvfpyD6Nboyq9RSgmtIlOG5d40THCZy6/bO2VeXPjG/xgCxvhv/li2 Q==; X-IronPort-AV: E=Sophos;i="6.01,246,1684792800"; d="scan'208";a="32226638" Received: from vtuxmail01.tq-net.de ([10.115.0.20]) by mx1.tq-group.com with ESMTP; 01 Aug 2023 12:36:24 +0200 Received: from localhost.localdomain (SCHIFFERM-M2.tq-net.de [10.121.49.20]) by vtuxmail01.tq-net.de (Postfix) with ESMTPA id A02B3280075; Tue, 1 Aug 2023 12:36:24 +0200 (CEST) From: Matthias Schiffer To: Santosh Shilimkar , Michael Turquette , Stephen Boyd Cc: Jai Luthra , linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org, linux@ew.tq-group.com, Matthias Schiffer Subject: [PATCH 0/3] clk: keystone: syscon-clk: fixes for audio refclk Date: Tue, 1 Aug 2023 12:36:06 +0200 Message-Id: X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_EF,RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_PASS, T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Currently the driver uses of_clk_hw_onecell_get() for all clocks it manages, but this is incorrect for the audio refclk, which has 0 rather than 1 clock cell according to its binding documentation [1]; attempting to look up the clock when referenced like this in the Device Tree leads to errors, as uninitialized memory is passed to of_clk_hw_onecell_get() as the index. The actual fix is in patch 3; patches 1 and 2 are preparation and related cleanup. I've added a Fixes: tag to all 3 patches, as they need to be backported together. Matthias Schiffer (3): clk: keystone: syscon-clk: use struct instead of array for match data clk: keystone: syscon-clk: specify whether a parent is required in match data clk: keystone: syscon-clk: use of_clk_hw_simple_get() for audio refclk [1] https://www.kernel.org/doc/Documentation/devicetree/bindings/clock/ti,am62-audio-refclk.yaml drivers/clk/keystone/syscon-clk.c | 73 ++++++++++++++++++++----------- 1 file changed, 48 insertions(+), 25 deletions(-) -- TQ-Systems GmbH | Mühlstraße 2, Gut Delling | 82229 Seefeld, Germany Amtsgericht München, HRB 105018 Geschäftsführer: Detlef Schneider, Rüdiger Stahl, Stefan Schneider https://www.tq-group.com/