Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <eb2b978d-cebb-b865-150d-8291ab5ab134@linaro.org>
Date:   Tue, 1 Aug 2023 11:37:38 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.12.0
From:   Neil Armstrong <neil.armstrong@linaro.org>
Reply-To: neil.armstrong@linaro.org
Subject: Re: [PATCH] drm/bridge: it6505: Check power state with
 it6505->powered in IRQ handler
Content-Language: en-US
To:     Pin-yen Lin <treapking@chromium.org>,
        Andrzej Hajda <andrzej.hajda@intel.com>,
        Robert Foss <rfoss@kernel.org>,
        Laurent Pinchart <Laurent.pinchart@ideasonboard.com>,
        Jonas Karlman <jonas@kwiboo.se>,
        Jernej Skrabec <jernej.skrabec@gmail.com>,
        David Airlie <airlied@gmail.com>,
        Daniel Vetter <daniel@ffwll.ch>
Cc:     dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org
References: <20230727100131.2338127-1-treapking@chromium.org>
Organization: Linaro Developer Services
In-Reply-To: <20230727100131.2338127-1-treapking@chromium.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 27/07/2023 12:01, Pin-yen Lin wrote:
> On system resume, the driver might call it6505_poweron directly if the
> runtime PM hasn't been enabled. In such case, pm_runtime_get_if_in_use
> will always return 0 because dev->power.runtime_status stays at
> RPM_SUSPENDED, and the IRQ will never be handled.
> 
> Use it6505->powered from the driver struct fixes this because it always
> gets updated when it6505_poweron is called.
> 
> Fixes: 5eb9a4314053 ("drm/bridge: it6505: Guard bridge power in IRQ handler")
> Signed-off-by: Pin-yen Lin <treapking@chromium.org>
> 
> ---
> 
>   drivers/gpu/drm/bridge/ite-it6505.c | 4 +++-
>   1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/bridge/ite-it6505.c b/drivers/gpu/drm/bridge/ite-it6505.c
> index 6c2fcd8b8780..2f300f5ca051 100644
> --- a/drivers/gpu/drm/bridge/ite-it6505.c
> +++ b/drivers/gpu/drm/bridge/ite-it6505.c
> @@ -2517,9 +2517,11 @@ static irqreturn_t it6505_int_threaded_handler(int unused, void *data)
>   	};
>   	int int_status[3], i;
>   
> -	if (it6505->enable_drv_hold || pm_runtime_get_if_in_use(dev) <= 0)
> +	if (it6505->enable_drv_hold || !it6505->powered)
>   		return IRQ_HANDLED;
>   
> +	pm_runtime_get_sync(dev);
> +
>   	int_status[0] = it6505_read(it6505, INT_STATUS_01);
>   	int_status[1] = it6505_read(it6505, INT_STATUS_02);
>   	int_status[2] = it6505_read(it6505, INT_STATUS_03);

Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org>