Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <b88e5ced-f7f4-5fc7-b7bb-df0201697444@intel.com>
Date:   Tue, 1 Aug 2023 14:18:43 +0300
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.13.0
Subject: Re: [PATCH v4 04/29] drm/i915/gvt: Don't try to unpin an empty page
 range
Content-Language: en-US
To:     Sean Christopherson <seanjc@google.com>,
        Paolo Bonzini <pbonzini@redhat.com>,
        Zhenyu Wang <zhenyuw@linux.intel.com>
CC:     <kvm@vger.kernel.org>, <intel-gvt-dev@lists.freedesktop.org>,
        <intel-gfx@lists.freedesktop.org>, <linux-kernel@vger.kernel.org>,
        Yan Zhao <yan.y.zhao@intel.com>,
        Yongwei Ma <yongwei.ma@intel.com>,
        Ben Gardon <bgardon@google.com>
References: <20230729013535.1070024-1-seanjc@google.com>
 <20230729013535.1070024-5-seanjc@google.com>
From:   "Wang, Zhi A" <zhi.a.wang@intel.com>
In-Reply-To: <20230729013535.1070024-5-seanjc@google.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?T2tjc2NacDlZWk1PNVhLYk9QVlo4c3ljNmoxWDRNSjNORnZJMEZndVpheXIw?=
 =?utf-8?B?akYwUU85MnYyaXVtVm5WSHBuQ1Bua2NTeEMrc0pkNHZJSlVEcHZKczFkbWtB?=
 =?utf-8?B?NjRPNXhsakQ5RGRLSEdzMTdRZENGOHRMeFNZZlRwWmJodStuRUhXV3U5U3Nv?=
 =?utf-8?B?MVdXMWRJcERmT1J3T2RydWdYc3hmYXFkcEZqZjVjbzVWNFNBcXVzcy9zd2JN?=
 =?utf-8?B?THg4UHhsU2pidHVEMm51YkhoS2dQbHl3NU5LanltM3AyMmJQNWt0V2pjU2Ns?=
 =?utf-8?B?ODZsUk1VazVMWkplU0FHWG1pWEFCbmIvME95bGJ0K0dwdVh6a0U2anpZdy84?=
 =?utf-8?B?L05aYllEczJEZkRNM2V2djZtRVphZHpUeStGeFhRamV0TWp3cng0L1pLQlBr?=
 =?utf-8?B?T2VidHJaNFlObGhXOWVlZVUrTDk4dHB4Vm1KTS9QZy9ramFHdDlpcGpGMklB?=
 =?utf-8?B?NWQ1QnorcHkvNzVmYnNqaHZEdG5ZMFp1N3FKczR3V3k0cFlVSXFNWTNVSjBp?=
 =?utf-8?B?WlhoYzV1LzEza09mWXFtR2lsK0YzNDR6aU1xeHY3U29pSUJuVW92Z1lvdmd4?=
 =?utf-8?B?UTl5SjJ6YWlnWmZOeFBmRnpFSlNzK0pKN1d4b1F1RStMUFlIVndmMlpBb0g5?=
 =?utf-8?B?Ukx1azdSWkEyVXZmdGxYc0tFa3ZkMWdpY1BrNklxN0FNVVBnbU1rL09SajFj?=
 =?utf-8?B?d2ZwYXZQSGoxUEY3MmEyNWtuQm1aUytKbGVCdVdkWi8zd0tSMFoyL1RqZ0N4?=
 =?utf-8?B?U1ZaQU9EUWtQNWM1ZFdRZENoQWhGbnJ2YjJYK2tpeUVhdTY2M2FhSmMrSk1F?=
 =?utf-8?B?N0tZL29RNEJKQjI2aC9Od09Ock5henhUaWdJakFWaWNmR0s2bUxjRXJ3aC93?=
 =?utf-8?B?S2ZIVXA3R3lYcFJ0dDZ3QW11UVV6cjQ2a2Zsd29FQXEyY01oWU9qVXc1Skxy?=
 =?utf-8?B?RHcxV240b203OS9XalFySDFmNER2Z2hSS04wMFgzTTFONEY5bWhyRGhQYnhK?=
 =?utf-8?B?TlBwZ0pLd1BBUjNmU2ZzM3FCZGMyOFQwYVRHSjBQVTdaRVpqRGNoZHJsTnpz?=
 =?utf-8?B?YlJpQkpYbTFQWlZLWkttSlVIemdhdWt3VGlzVFQwZFA5Ky9pY1E2dGt6eEtk?=
 =?utf-8?B?T1NRNmN5cE1jNjc2ZUhRTUZCSENzSWRLcTcxYkRCU0Q2K3dTSWk3V0szRGZi?=
 =?utf-8?B?NDBJdkNyd1ZaZmZVTURlWVIzRDAzVnZtMWJ4V1B2bk5FeDhiUWpSZjFVd0wy?=
 =?utf-8?B?cFdXRE15Z1FCMVdENU1SckJZa1dISXYxN0lybUx0YkY3Rk1oSFhmb2Y2YnZn?=
 =?utf-8?B?NVQ1cTBYRHgrc2t4bURpZUM0anUraVZ2NWREczhhb0lPTlozMjcvZVgxVHVD?=
 =?utf-8?B?aDZpMDlFbW9MVGIrcmthYklKSm9XeU9GMTRaRW9jZkQrZUxkQmY2cWR5dzhS?=
 =?utf-8?B?dUNjQ0dicGhlNUp5YnI1TEdMdnBHcC9QNm1ydHM2NGZPNUR2VEJjUHh0dVVC?=
 =?utf-8?B?eHFXYmg1b0NGdHhyaTEzME1FRS9tVmNwaDZaNXlpNktFMG9sMWt6RHBSWjFi?=
 =?utf-8?B?N2tWVXU0ZTVSUG80V1dPbmQ4OUIramtjSDJhMEhkZ1RsQkMySFNUYk9qVU0y?=
 =?utf-8?B?cGp0ZWRDbkVCNklBNjRtVmtSSDFvY1RiK1lMRzJTaU1CZXFPMk85ZVFHdjNw?=
 =?utf-8?B?aEtWaWZKOGw4ZzBiRDcxSVE0UmRUNlBqZFFzUksvZDJaR2NhVCtjNGEvMHAx?=
 =?utf-8?B?UmMrVVZMd3ljK1BER3kwdGFOTFBBZDRLZ3o2bFlRN0FUYnlVTkNoZzBxVXVG?=
 =?utf-8?B?YlExVjdNeTNWZmdJZHpkS3dZUmJIc0lYY3JyUDE5NUV0dmt6UXAwVm4yYk1i?=
 =?utf-8?B?VmlzdlVsTGFidElHNnZRWi83U1IrY2R3d1FieWJGTHpYb2VuQnZSeXY4cU9q?=
 =?utf-8?B?SHVRY0hQV25ERjhVU3dZWndVajJ6aHFIQUh4WXdLOVJMc2JGVUh3dXBjaXNL?=
 =?utf-8?B?cGpyTjRhQW53NFRtbU53Vk50S3dFczdsZ1BBTy9aK2k3Wnd6TlZSdFVSVCtn?=
 =?utf-8?B?aDdBYlI5ckNjbDhRdVd2dU1EL0NLNlhvYVRCRTdBNnVtalB1RUxaZTh1Zks1?=
 =?utf-8?Q?5vDaYY5MfLk1nnyWNFNFYxTmo?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 15d2ca82-3334-47af-3eef-08db92811488
X-MS-Exchange-CrossTenant-AuthSource: DM4PR11MB5549.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Aug 2023 11:18:49.8725
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: yzHvTatribODZbUYaz4qNDzgDeKzSvyqt9TqEoDMS0dbqAZ92oowzFd6PbyAyOycPXkmRDx+jbsccYCPEYEXpQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR11MB6495
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.5 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,
        RCVD_IN_DNSWL_MED,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,
        T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no
        version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 7/29/2023 4:35 AM, Sean Christopherson wrote:
> From: Yan Zhao <yan.y.zhao@intel.com>
> 
> Attempt to unpin pages in the error path of gvt_pin_guest_page() if and
> only if at least one page was successfully pinned.  Unpinning doesn't
> cause functional problems, but vfio_device_container_unpin_pages()
> rightfully warns about being asked to unpin zero pages.
> 
> Signed-off-by: Yan Zhao <yan.y.zhao@intel.com>
> [sean: write changelog]
> Signed-off-by: Sean Christopherson <seanjc@google.com>
> ---
>   drivers/gpu/drm/i915/gvt/kvmgt.c | 3 ++-
>   1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/i915/gvt/kvmgt.c b/drivers/gpu/drm/i915/gvt/kvmgt.c
> index 429f0f993a13..0366a699baf5 100644
> --- a/drivers/gpu/drm/i915/gvt/kvmgt.c
> +++ b/drivers/gpu/drm/i915/gvt/kvmgt.c
> @@ -172,7 +172,8 @@ static int gvt_pin_guest_page(struct intel_vgpu *vgpu, unsigned long gfn,
>   	*page = base_page;
>   	return 0;
>   err:
> -	gvt_unpin_guest_page(vgpu, gfn, npage * PAGE_SIZE);
> +	if (npage)
> +		gvt_unpin_guest_page(vgpu, gfn, npage * PAGE_SIZE);
>   	return ret;
>   }
>
Reviewed-by: Zhi Wang <zhi.a.wang@intel.com>