Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <b79630a4-0473-89eb-44da-28d87b6539ef@op.pl>
Date:   Tue, 1 Aug 2023 13:36:20 +0200
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
To:     mario.limonciello@amd.com
Cc:     James.Bottomley@hansenpartnership.com, Jason@zx2c4.com,
        daniil.stas@posteo.net, jarkko@kernel.org,
        linux-integrity@vger.kernel.org, linux-kernel@vger.kernel.org,
        linux@dominikbrodowski.net, regressions@leemhuis.info,
        stable@vger.kernel.org, torvalds@linux-foundation.org
References: <61b363bc-286a-535c-27da-0f52673768ad@amd.com>
Subject: Re: [PATCH 1/1] tpm: disable hwrng for fTPM on some AMD designs
Content-Language: en-US
From:   Mateusz Schyboll <dragonn@op.pl>
In-Reply-To: <61b363bc-286a-535c-27da-0f52673768ad@amd.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

I was following the issue under or discord channel ROG for Linux and 
helping out some other users with it by shipping a kernel for Arch with 
disabled CONFIG_HW_RANDOM_TPM as the default recommend kernel for Arch 
for ROG laptops (as my device isn't affect by it because it is Ryzen 
4800HS).

I know it was discussed here 
https://bugzilla.kernel.org/show_bug.cgi?id=217212#c16 against allowing 
the user to disable fTPM to be used as a random source via a boot time 
parameter but I still I disagree with it.

Linux does have a parameter `random.trust_cpu` to control the random 
source from CPU, why they can not be a parameter like 
`random.trust_ftpm` (or `random.trust_tpm`)?

It might be my limited knowledge of this topic but to me it feels like 
if they is a trust_cpu then Linux should have trust_ftpm too.

Mateusz