Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 1 Aug 2023 12:01:09 +0200
From:   Joel Granados <joel.granados@gmail.com>
To:     Luis Chamberlain <mcgrof@kernel.org>
Cc:     Catalin Marinas <catalin.marinas@arm.com>,
        Iurii Zaikin <yzaikin@google.com>,
        Jozsef Kadlecsik <kadlec@netfilter.org>,
        Sven Schnelle <svens@linux.ibm.com>,
        Marcelo Ricardo Leitner <marcelo.leitner@gmail.com>,
        Steffen Klassert <steffen.klassert@secunet.com>,
        Kees Cook <keescook@chromium.org>,
        "D. Wythe" <alibuda@linux.alibaba.com>, mptcp@lists.linux.dev,
        Jakub Kicinski <kuba@kernel.org>,
        Vasily Gorbik <gor@linux.ibm.com>,
        Paolo Abeni <pabeni@redhat.com>, coreteam@netfilter.org,
        Jan Karcher <jaka@linux.ibm.com>,
        Alexander Aring <alex.aring@gmail.com>,
        Will Deacon <will@kernel.org>,
        Stefan Schmidt <stefan@datenfreihafen.org>,
        Matthieu Baerts <matthieu.baerts@tessares.net>,
        bridge@lists.linux-foundation.org,
        linux-arm-kernel@lists.infradead.org,
        Joerg Reuter <jreuter@yaina.de>, Julian Anastasov <ja@ssi.bg>,
        David Ahern <dsahern@kernel.org>,
        netfilter-devel@vger.kernel.org, Wen Gu <guwen@linux.alibaba.com>,
        linux-kernel@vger.kernel.org,
        Santosh Shilimkar <santosh.shilimkar@oracle.com>,
        linux-wpan@vger.kernel.org, lvs-devel@vger.kernel.org,
        Karsten Graul <kgraul@linux.ibm.com>,
        Miquel Raynal <miquel.raynal@bootlin.com>,
        Herbert Xu <herbert@gondor.apana.org.au>,
        linux-sctp@vger.kernel.org, Tony Lu <tonylu@linux.alibaba.com>,
        Pablo Neira Ayuso <pablo@netfilter.org>,
        Ralf Baechle <ralf@linux-mips.org>,
        Florian Westphal <fw@strlen.de>, willy@infradead.org,
        Heiko Carstens <hca@linux.ibm.com>,
        "David S. Miller" <davem@davemloft.net>,
        linux-rdma@vger.kernel.org, Roopa Prabhu <roopa@nvidia.com>,
        Alexander Gordeev <agordeev@linux.ibm.com>,
        Simon Horman <horms@verge.net.au>,
        Mat Martineau <martineau@kernel.org>, josh@joshtriplett.org,
        Christian Borntraeger <borntraeger@linux.ibm.com>,
        Eric Dumazet <edumazet@google.com>, linux-hams@vger.kernel.org,
        Wenjia Zhang <wenjia@linux.ibm.com>,
        linux-fsdevel@vger.kernel.org, linux-s390@vger.kernel.org,
        Xin Long <lucien.xin@gmail.com>,
        Nikolay Aleksandrov <razor@blackwall.org>,
        netdev@vger.kernel.org, rds-devel@oss.oracle.com
Subject: Re: [PATCH v2 00/14] sysctl: Add a size argument to register
 functions in sysctl
Message-ID: <20230801100109.ospf2gwsdewhhwzn@localhost>
References: <20230731071728.3493794-1-j.granados@samsung.com>
 <CGME20230731205134eucas1p1403a137418fcdaaaf78890de88d4a958@eucas1p1.samsung.com>
 <ZMgeoDT0t3NeALM0@bombadil.infradead.org>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="g6vdqxyc5hdpujuz"
Content-Disposition: inline
In-Reply-To: <ZMgeoDT0t3NeALM0@bombadil.infradead.org>
Precedence: bulk


--g6vdqxyc5hdpujuz
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Mon, Jul 31, 2023 at 01:50:40PM -0700, Luis Chamberlain wrote:
> On Mon, Jul 31, 2023 at 09:17:14AM +0200, Joel Granados wrote:
> > Why?
>=20
> It would be easier to read if the what went before the why.
haha. I totally misunderstood you in
lore.kernel.org/all/ZMFizKFkVxUFtSqa@bombadil.infradead.org I thought
you meant to put the why first. I'll switch it back to having the what
first for V3

>=20
> > This is a preparation patch set that will make it easier for us to apply
> > subsequent patches that will remove the sentinel element (last empty el=
ement)
> > in the ctl_table arrays.
> >=20
> > In itself, it does not remove any sentinels but it is needed to bring a=
ll the
> > advantages of the removal to fruition which is to help reduce the overa=
ll build
> > time size of the kernel and run time memory bloat by about ~64 bytes per
> > sentinel.
>=20
> s/sentinel/declared ctl array
>=20
> Because the you're suggesting we want to remove the sentinel but we
> want to help the patch reviewer know that a sentil is required per
> declared ctl array.
Ack

>=20
> You can also mention here briefly that this helps ensure that future move=
s of
> sysctl arrays out from kernel/sysctl.c to their own subsystem won't
> penalize in enlarging the kernel build size or run time memory consumptio=
n.
I worked it in

Thx for the review
>=20
> Thanks for spinning this up again!
>=20
>   Luis

--=20

Joel Granados

--g6vdqxyc5hdpujuz
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQGzBAABCgAdFiEErkcJVyXmMSXOyyeQupfNUreWQU8FAmTI1+QACgkQupfNUreW
QU/tvQv8DSOiRBrGHskMVKuasQMrQO4cj/zOagQExBMcJnGj7M+jr4pvCvBo1Rce
fRZBBVfKDjeV4svmqKus54sNM27JPAJALJlnePPgsBqhuOeL6kKLSsCDyDv6bKOS
e0J6ZLE6EAqudCJqsxjGkPNEalpooX1Ip9OQqdPQxyfoSdDZQcKucP/rPx+Q4yzy
lKv9SqcK/1j7q8fMkiucrjwQF2woB16q6iXZmokZTt7vTX0rSfKFJ8isQOgimpll
Xv+hxQaRZEueIIc45dAL7MRYn/zukf8rExbIRNXCtUCsyfJxcdo6V0ubKfMAj/u3
X2J5FIUpf1ua/QX0idONlXIXU1kOWnFapnBPprKBKuBhO6xwSnrQhxgt7aKbbDGl
dBwWRbN59m3q7jrz17McOb+LjfA5ZMcs3K58bfg0PnrugQZA537GFL19es1dAssc
fy06XeNWXeUhvCjgQW53D2twqvhAhY4WU1D4sbV+8xwQihB416Zkc+ReqQs2cS6Y
zhTPrhl+
=F1x8
-----END PGP SIGNATURE-----

--g6vdqxyc5hdpujuz--