Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <a865ff81-9d5e-f937-735c-3c619df42785@intel.com>
Date:   Tue, 1 Aug 2023 14:22:50 +0300
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.13.0
Subject: Re: [PATCH v4 03/29] drm/i915/gvt: Verify hugepages are contiguous in
 physical address space
Content-Language: en-US
To:     Yan Zhao <yan.y.zhao@intel.com>,
        Sean Christopherson <seanjc@google.com>
CC:     Paolo Bonzini <pbonzini@redhat.com>,
        Zhenyu Wang <zhenyuw@linux.intel.com>, <kvm@vger.kernel.org>,
        <intel-gvt-dev@lists.freedesktop.org>,
        <intel-gfx@lists.freedesktop.org>, <linux-kernel@vger.kernel.org>,
        Yongwei Ma <yongwei.ma@intel.com>,
        Ben Gardon <bgardon@google.com>
References: <20230729013535.1070024-1-seanjc@google.com>
 <20230729013535.1070024-4-seanjc@google.com>
 <ZMhkJa2/9/aboPju@yzhao56-desk.sh.intel.com>
From:   "Wang, Zhi A" <zhi.a.wang@intel.com>
In-Reply-To: <ZMhkJa2/9/aboPju@yzhao56-desk.sh.intel.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?c3laUmNQSFg1bGJLaTZjN3lveUFaRkV5b0Vpa1JVbXpWcHV2QW5Md3R5eVF6?=
 =?utf-8?B?QmFoTGoxSDNkdC9nRVRWVnM5UEZyd2cwZXFtSy8vaDZPWTg5UHh1aGZ6WWdU?=
 =?utf-8?B?Zks2aHNlMGFZWG9xcnUwSFFnSnZNTUlKYkYxY0YzRDZoMGdBMzUzVHVTVnhV?=
 =?utf-8?B?cGduWThBclZYN0RORUJqZm5oWHJVSjRpeWRvbE5XdXoxOWRBR3V4OXR1NFhk?=
 =?utf-8?B?Um00a210Z1g0cFlhL0lWN013QXRmN0F6c3Y1am44RFlGSE9kbzY2Qks5SHMz?=
 =?utf-8?B?WlVpdzhKNHpSeG04Y1Azbjd6M1N0NzlrVG0xdDJyKy9pdTVGWFNpaURtc1do?=
 =?utf-8?B?YW85WjdybHJiRHM4TEtwYjV0ZUdpTThtU3NHaHNiMlgvcyt2UG1LdWlZWTU1?=
 =?utf-8?B?L2JYY0ZncnNwY0IrbC8xZllWL3BhSnRCTWt2ZjAydHIvQnh4MW1SWmZJa3FW?=
 =?utf-8?B?cUZHdVN0VWJGV0ZETldqOHpxZkhjUXhtdkVkaWw3d1piQlBXN2VOakdqN0dh?=
 =?utf-8?B?S0RuTEJFa24wdzIySzVlVXd4emhnKy9XWlNEZ3RhRkFZdXN0ZEp6UjBzOGpp?=
 =?utf-8?B?bGwycnhEVjMveEx0ZVdvYmFKNng2NkQrWHdPUUVCd0xvUVU5OVhjaTZrNGUy?=
 =?utf-8?B?Q1N6aWZkMEhUcUQxVUp3Y3Zid3lYZU54dG9kd25hOGR3ZUVZRGQ1bXVzb3VO?=
 =?utf-8?B?bWhnazFvMjFESnYrR0tiVUNjTWRGUHlUdHpNeEN2ZzVBTE1RVEV4cVh4Qkxs?=
 =?utf-8?B?Si81TktiZDl5aDlwMEUvVzREU29ndHhFNFFaSFRDdHRPblJjZmpuekxKVWN3?=
 =?utf-8?B?MmpHN21CTU9GKzdYRU90UGtPTEk3QTZyQkZPNC9rUGlQY1lpdmxYbnZJeDVZ?=
 =?utf-8?B?bFdjb3hPMC9qV2Z4b3dZVWh4cCt6MzlsZHJhVnAvMy90SWxzcEo5NzkrTW5L?=
 =?utf-8?B?OW5sK2JxKzVmT0FZU0ZDcVAyUzBiLzh5a0YzZU9yMWNhWlk5d1ZjWWVsOE1E?=
 =?utf-8?B?OTJJbHpabWVrczhmUzlMNWtHUHRneExMZitBTTh5T08rVTlqeHdoS3hRWVdC?=
 =?utf-8?B?OS9jenVRRS9BbTRKWWRIRzg3UFk1d3FxdXpVM2tlS0xvS3RvODN2YTZEZ1dm?=
 =?utf-8?B?blBsUmY3SEFjYURRbE00eUdpUXhrSDVXdEdKaHBwejFGam5vSTBTNWorNUUx?=
 =?utf-8?B?Vm1IdUZQWWxhdTRGQi91c0xOQ2M4ak5lSVRZVGVEdjlQMzJIUnFDb1dQcmkx?=
 =?utf-8?B?a3hrNUlsOXhzVmV3QUlUcFJ1dFVZVExMaTMwWlVGcWVSdUVtQlI0azczdVB5?=
 =?utf-8?B?UU1vQmxPUXN2L3JsNXU2aXFrbVM1ZDArWGw3Qi9xbWVIQnl6ZDlRQ1Q3QUtV?=
 =?utf-8?B?d3BQRytDalZsQjNic3FuZ2VEb2JRWjNMd0gzSThVK05ZR2R5M29uMkRSNXpG?=
 =?utf-8?B?VXhya05aVHhyN3pTMXBEcGR0SHgyNXFmRzA0dnphR2lHNU5KNDdsV1hEWmk4?=
 =?utf-8?B?dXFZMnc3dHh5eWVndTE2WXJTelBUV3BNSFNuVm53QmNlUDQrenVWbjl2dU9j?=
 =?utf-8?B?bVlscW5LcHdKOWVFM0hnakU4cVR6SURYMCtDY2IrYXYxVDRhVG4rK2NGdE1s?=
 =?utf-8?B?QnVLY3Yyc0FSTDMwUFpKeXlxaHRXOXZuZk8rc2VpMkdRVzlPRE1IeFdrRGI0?=
 =?utf-8?B?aHA5L0VvbGRFZEtTalV2ZEcwWFpwN2ZSTlk5QjFBWkRuWkU5MDhUZ0FYRXJq?=
 =?utf-8?B?aXg0MWxIcFVudzBpZTJYOXErNGRVQjBWN0RudzcwbUVLbmlOUTVURGhubFo1?=
 =?utf-8?B?RnFYTTdreHpwcnZNVE91NzFhUHBWZERGNjZ1R3hhdkdXOG0rSTlRRDJwS1U4?=
 =?utf-8?B?RUFRRUUwY3gwVnA3Mlk4VW1oUFE5U0ZEd1ZNdis4NjhkUmFIc09mNmxZM0xv?=
 =?utf-8?B?Q0hISjV2dmVWVUdNWjl1WGJiYmJyd1pSNEJ2TEZtbjB1Ull1MVovYkhRZXpO?=
 =?utf-8?B?cXAzRzJkRzQxK2o5dElRZnFCaGVBS1B1M01vRVpxWURXdVhRcjBFMlVVMFlC?=
 =?utf-8?B?SzF0VUFPbWN5Tm4zc3VGOVZ1bzBFd3crREVyVDlZSkxHUlY5NHNHZjNpZm92?=
 =?utf-8?Q?gZTm0a3oMPxSyrgOzIrOiu3Nn?=
X-MS-Exchange-CrossTenant-Network-Message-Id: f6ae370a-4f5d-48e2-1bfb-08db9281a74f
X-MS-Exchange-CrossTenant-AuthSource: DM4PR11MB5549.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Aug 2023 11:22:56.0703
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: WUDPBXnVAyxAJ94syuYknvu1Ukinh2fi/LBB/sOgKUHHFzPHGkRO1dcqpdcpc+1HWcBUYsEox0ScSLd5uOc7Tg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH0PR11MB5521
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-2.2 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,
        RCVD_IN_DNSWL_BLOCKED,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,
        SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 8/1/2023 4:47 AM, Yan Zhao wrote:
> Reviewed-by: Yan Zhao <yan.y.zhao@intel.com>
>
> On Fri, Jul 28, 2023 at 06:35:09PM -0700, Sean Christopherson wrote:
>> When shadowing a GTT entry with a 2M page, verify that the pfns are
>> contiguous, not just that the struct page pointers are contiguous.  The
>> memory map is virtual contiguous if "CONFIG_FLATMEM=y ||
>> CONFIG_SPARSEMEM_VMEMMAP=y", but not for "CONFIG_SPARSEMEM=y &&
>> CONFIG_SPARSEMEM_VMEMMAP=n", so theoretically KVMGT could encounter struct
>> pages that are virtually contiguous, but not physically contiguous.
>>
>> In practice, this flaw is likely a non-issue as it would cause functional
>> problems iff a section isn't 2M aligned _and_ is directly adjacent to
>> another section with discontiguous pfns.
>>
>> Tested-by: Yongwei Ma <yongwei.ma@intel.com>
>> Signed-off-by: Sean Christopherson <seanjc@google.com>
>> ---
>>   drivers/gpu/drm/i915/gvt/kvmgt.c | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/gpu/drm/i915/gvt/kvmgt.c b/drivers/gpu/drm/i915/gvt/kvmgt.c
>> index de675d799c7d..429f0f993a13 100644
>> --- a/drivers/gpu/drm/i915/gvt/kvmgt.c
>> +++ b/drivers/gpu/drm/i915/gvt/kvmgt.c
>> @@ -161,7 +161,7 @@ static int gvt_pin_guest_page(struct intel_vgpu *vgpu, unsigned long gfn,
>>   
>>   		if (npage == 0)
>>   			base_page = cur_page;
>> -		else if (base_page + npage != cur_page) {
>> +		else if (page_to_pfn(base_page) + npage != page_to_pfn(cur_page)) {
>>   			gvt_vgpu_err("The pages are not continuous\n");
>>   			ret = -EINVAL;
>>   			npage++;
>> -- 
>> 2.41.0.487.g6d72f3e995-goog
>>
Reviewed-by: Zhi Wang <zhi.a.wang@intel.com>