Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <4bce1e71-5d9b-34d2-cf7d-6feffe131f09@intel.com>
Date:   Tue, 1 Aug 2023 14:28:55 +0300
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.13.0
Subject: Re: [PATCH v4 09/29] drm/i915/gvt: Use an "unsigned long" to iterate
 over memslot gfns
Content-Language: en-US
To:     Sean Christopherson <seanjc@google.com>,
        Paolo Bonzini <pbonzini@redhat.com>,
        Zhenyu Wang <zhenyuw@linux.intel.com>
CC:     <kvm@vger.kernel.org>, <intel-gvt-dev@lists.freedesktop.org>,
        <intel-gfx@lists.freedesktop.org>, <linux-kernel@vger.kernel.org>,
        Yan Zhao <yan.y.zhao@intel.com>,
        Yongwei Ma <yongwei.ma@intel.com>,
        Ben Gardon <bgardon@google.com>
References: <20230729013535.1070024-1-seanjc@google.com>
 <20230729013535.1070024-10-seanjc@google.com>
From:   "Wang, Zhi A" <zhi.a.wang@intel.com>
In-Reply-To: <20230729013535.1070024-10-seanjc@google.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?bVJpRlAzUzAzdlo2aURzWmoyZThuREtlclViK2JYWXlUV05pSm5naGEwci81?=
 =?utf-8?B?MUNyL1NsbEVaUzlTRjd3NXlvNUZKa3RlNUNERzBFd1pFS0RtYnVlUXJld01j?=
 =?utf-8?B?THpDTGlraE92TU9OKzNSbUsxL1hNYnAzdk4vSFVTcDRzbkJrd1FrYWVWNnh4?=
 =?utf-8?B?NHhsVzJZdXk5cVBldnlWcGozZS9mdTJ3eWNVdTYxaStPNUdWemdsTEc0eVRN?=
 =?utf-8?B?UzRHTkp4ZlRKREVMeUhDWTJwZWZTT0s5ckhNMENENkplMWRjQTRwTTFVSklV?=
 =?utf-8?B?N2wxZkRBM0pwZ0s4TXBUVjFaOHVFTFFTdTdOWTJFZ0lldURUeU9uOUdKYm9E?=
 =?utf-8?B?S0ovVXFTdE5NR21YRm0wNGRER0kwNlN1Y21WZ3IwVVNnTUJVVGF6d2cvY2xP?=
 =?utf-8?B?WUg0Nm96MGF6SE5qc0wxMmxXQmFLZTJobWhoR3BUaENvRm9vYkhHTEZmTzdQ?=
 =?utf-8?B?Misyci9kZTRwcUE1VE93YU1tbFJnSUNMU2lKZ1ErV0w3SGRoVzVLUnREdmlo?=
 =?utf-8?B?YlpqTnZwMDNCcS9tcVZlem44bGdJdFRyV09Nang2d1JqTkZreElQZnI0a0pa?=
 =?utf-8?B?UTJpWUU4S1ZldGhodDkrdnRqMFowRzl3SDhEblNEQS9KZStDWXh5OUhoRTk1?=
 =?utf-8?B?d21sNkNJZ24xVUJnUEROUjZKdVU0YnFhRkxmZlFiMy9ZeUpsT1VGSXhEdG1j?=
 =?utf-8?B?WUxOaUVzU3hYU1NrYzgyeUQxencrTTBkMU96ZUNXMUtHakNCdUxnb3pUNFls?=
 =?utf-8?B?Q0pLbnpCMXdxVlZKRi9iUmd1dUlyTitWUWJBUU9TVWswaURqR09EeFBoQm9U?=
 =?utf-8?B?RHhzUCtyeEN5RzdFVmUyM3FYV09QdVM3cGFNRTE2S0FkOW9CZTVoeVdsci84?=
 =?utf-8?B?d2VydVNSZHVkSHhSSGZzOHpkbStIM3Y3QTMwcUF5NEp4Q3F1Z3dQemcrSjNB?=
 =?utf-8?B?ZVVVeWh2MDZlRlNjYm5PcVk5SGkwSUhsWHZ5K0tieUloNDQrY01mR0JDS3lE?=
 =?utf-8?B?OUd3b1NldXoxbCtLUDZ0b1FwSWFnSDRsbGNuUTdWeXpvN1kycDlvSEJJSkYr?=
 =?utf-8?B?RnEvblF6d3JrVWVNQWlocjNLR0ZwSWFybzJaZUY5dVA5U3NEYVpyOUFRRkk3?=
 =?utf-8?B?Tmpkd1RRU1dmc3loY0Q3aUk2NE1aeVFJay9DbXJwYStiQ29wZmtIOENBR2pO?=
 =?utf-8?B?Qk1sSVFZcXMyK1F5cjBoQ3cvOFY0ejFQWmtzTm8xMW14OUNULzA1RnlIMzdN?=
 =?utf-8?B?cHcrL3Fwa3dHdTJqSFdRRWc4N05Yc2M2bWYwRkhNY21LeXVVNjJpN0k2cnRQ?=
 =?utf-8?B?KzBpaTdWZWVNVHMwZjZMRExtMFI3QzlWYlBSU0Y5UXdTNWUvUjJHQnplek8x?=
 =?utf-8?B?UHZrd1Y4ZEN2Y0J1b0V3cndhcDJzb1dITmVRQ0ZYcjlEQU83b2hrTmdTTVNa?=
 =?utf-8?B?bFN6eitUT2pDdGIzc3pYUlFWMGRJb1lxUHAzVW5aRUFyaWE2RXk4eS91VkNV?=
 =?utf-8?B?bzRIREFBN1hVcjM4akloTldMcjRSOWg5YTUvazNiVGdjVml4MnN2T0xKVFl3?=
 =?utf-8?B?RHRLV3hyUEhzaEhGMjQ1OEpOY2JKZWV3anhjVU1tWGlSYTh5STNtMmF3NjVw?=
 =?utf-8?B?QitpTnJOVkpqb2lKVVY3NkhUeXpwcXR5QkFrdDA3em13N2VkeVdLTDFUUjVR?=
 =?utf-8?B?YlQxbVBNVmIwZjZXWS9vcjZQRGF3cytZWTZ0UElFYUJiSXNxMEE5cEhEdGFR?=
 =?utf-8?B?N2YzRkxrUUJuNUNZK2dBc251TXY3aFlZNmpNVUFwQlAxaFdsakxhUnFKQW1i?=
 =?utf-8?B?N1A5ZkEydEdKaWl4dXVlTEZMaXBmeEhlTEw2QTY5dVVRSC92TDl4OWxZYk5Q?=
 =?utf-8?B?c3phQXZDK1BIUWJuOHFnV2h4T2xMbzNHeVppOVBzekRhM1BHdDBaZEQrdzBr?=
 =?utf-8?B?dVZad0RhVCt6MjNPWm56OTIyWVgzaEFSVkh1dXgzL0tTbU5vQk8zRjJHd0NC?=
 =?utf-8?B?bXRTaDZxcGxoTkNDTlVMYnBqRnhNcHdST0F0TXNiMjRtV0QyOHVEazZkRXg1?=
 =?utf-8?B?aWpNcm92QlAzcVlpU1FweExBUjVYSkJBbGlvZ2VpdzhObURuYkJqeCtBdlZ0?=
 =?utf-8?Q?BKbnBjRKOqFoBRN6wD3Frtt/A?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 5c9e4fe6-9c36-4baf-5001-08db928280c7
X-MS-Exchange-CrossTenant-AuthSource: DM4PR11MB5549.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Aug 2023 11:29:00.9370
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: ooq01j5AlIKcBuhfbhjvrn2ibmAWw+96OcC115hF4uTNe/m/4D03n9zq3rA2/LMOi20/7U2ZndUkCRuD7/njQQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR11MB6695
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-2.2 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,
        RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE,
        URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 7/29/2023 4:35 AM, Sean Christopherson wrote:
> Use an "unsigned long" instead of an "int" when iterating over the gfns
> in a memslot.  The number of pages in the memslot is tracked as an
> "unsigned long", e.g. KVMGT could theoretically break if a KVM memslot
> larger than 16TiB were deleted (2^32 * 4KiB).
>
> Reviewed-by: Yan Zhao <yan.y.zhao@intel.com>
> Tested-by: Yongwei Ma <yongwei.ma@intel.com>
> Signed-off-by: Sean Christopherson <seanjc@google.com>
> ---
>   drivers/gpu/drm/i915/gvt/kvmgt.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/gvt/kvmgt.c b/drivers/gpu/drm/i915/gvt/kvmgt.c
> index 97c6d3c53710..6f52886c4051 100644
> --- a/drivers/gpu/drm/i915/gvt/kvmgt.c
> +++ b/drivers/gpu/drm/i915/gvt/kvmgt.c
> @@ -1620,7 +1620,7 @@ static void kvmgt_page_track_flush_slot(struct kvm *kvm,
>   		struct kvm_memory_slot *slot,
>   		struct kvm_page_track_notifier_node *node)
>   {
> -	int i;
> +	unsigned long i;
>   	gfn_t gfn;
>   	struct intel_vgpu *info =
>   		container_of(node, struct intel_vgpu, track_node);

Reviewed-by: Zhi Wang <zhi.a.wang@intel.com>