Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <06334808-be59-4949-fac5-022988639adf@intel.com>
Date:   Tue, 1 Aug 2023 14:35:18 +0300
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.13.0
Subject: Re: [PATCH v4 15/29] KVM: drm/i915/gvt: Drop @vcpu from KVM's
 ->track_write() hook
Content-Language: en-US
To:     Sean Christopherson <seanjc@google.com>,
        Paolo Bonzini <pbonzini@redhat.com>,
        Zhenyu Wang <zhenyuw@linux.intel.com>
CC:     Yan Zhao <yan.y.zhao@intel.com>, <kvm@vger.kernel.org>,
        <intel-gfx@lists.freedesktop.org>, <linux-kernel@vger.kernel.org>,
        Yongwei Ma <yongwei.ma@intel.com>,
        Ben Gardon <bgardon@google.com>,
        <intel-gvt-dev@lists.freedesktop.org>
References: <20230729013535.1070024-1-seanjc@google.com>
 <20230729013535.1070024-16-seanjc@google.com>
From:   "Wang, Zhi A" <zhi.a.wang@intel.com>
In-Reply-To: <20230729013535.1070024-16-seanjc@google.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?SHJpOE56Q0dITWpsWitUZnZ1R2dHMjRqWFhkU3JjUFgzQUJ5VkdiTXZUZlVa?=
 =?utf-8?B?bFpicHl6TGRrSUdaZkZIZFJXWHQyOFRYMFhRQkZEckdHOXFZdkpFWGtpdTVO?=
 =?utf-8?B?UUxCSW5qVTY3b1pWMEV1Sjd3UDBBaFErVEIzWkhHTnhxS1RHdWk2K2pkWGU1?=
 =?utf-8?B?a2c5NFBRVG1IdmdtUHJ3Wk1BYjJRNnEwV2hCOHhoVi9rZWMzQlBQd0F5MWlM?=
 =?utf-8?B?cWY2ZXVGYUVkVURZQkRhRWpUczBVTWtDeXZJVGlOeHJIUWhOWXNUbTMyN2RT?=
 =?utf-8?B?MVhlVkYzdUVuWEsrd2VwR2pXRUFLTWlJTU9pOXdMK3llQUZ5QXptak1sQTF4?=
 =?utf-8?B?emI5ZE5Pb2FVa3NHV0s1a0NzdHYzaVd5TXkzSUs3c2U2K2FaejExRDVUQVlW?=
 =?utf-8?B?aXZrbXA4cjBkcFBzUlhBcDQyTUlXYjYyOEE3VENsNXZ4TXYxMHZsLzA1VkZO?=
 =?utf-8?B?VlJKZTh1cEtjdkozOWVnNVEzOTNPaGVxL0VQdUhDZStTVGUwNE1memw3N1Aw?=
 =?utf-8?B?UTR4cW1meExZeVg0UEVSMmJMMHkrTEhwNzhleG1jZWp0OVBjUG14MS9wKzNI?=
 =?utf-8?B?eHFWTDdXVGdnTWgwaWZyUU5HckdadzlWaHc5TXRQbkdTT1V3SGZURFRJVy8w?=
 =?utf-8?B?MVpsYkxlak5NRGY4aHQrdmZxTldQRzlIR3QvbnU5eForYXJmeVJTVGZka2pw?=
 =?utf-8?B?VERkeFk5RDgvV2RyUkR2d2l0QXVxNERnL0tuK2t4a1JYV2VQQ3VJY3Ftc2l4?=
 =?utf-8?B?WjRaNDZIS0pqaWVwMDBNeXduUVhMMjBsbFJCMGdyK1M0emFFNC9hOGlSRGlp?=
 =?utf-8?B?Sy9SVzVnSFNmd1VlaGZBTVhKdTlibXhKVVFxNmF0SE5TQUliRVdQVDdjaDd4?=
 =?utf-8?B?NzR4Uzk5YS9vdklVdzNYcXhzTUxCTXkzMnRrRmhSV2w0TXpQTmRPelZPMzFC?=
 =?utf-8?B?UWVOZTh5amhKQTdEVDhQcFpIUmRPMGEzU1lIZjZzYXF2dkNMdWxGRzhsaVB1?=
 =?utf-8?B?ZlY3OFlTZWRCbEVFZEczL2NlT2JnMXo3NnVRRUN0bDZyRGZvRDNXQVhwQXY1?=
 =?utf-8?B?RjVSQWxZZ3hNZkVFUE0xN3l0ZVpMN0U3VzNSdFdyekRiT3dNVEJTTWxxZW5p?=
 =?utf-8?B?M3l5RGdRV3FvOWZsSVEwVHhvUFNhMHFLdnlZWW5SN3RieE5ONG45UldMZW9N?=
 =?utf-8?B?UnNkbXlGODg4L1pLczgrTmc0VTVaL1l2NU5FTjdCS0gzdDlOcUV6QzJnNGZX?=
 =?utf-8?B?d0lON2VEMDZWUU1xZGpzS0tyeHdoWGltb2F3ckk2NElldGpIRUgzUUZLKzJn?=
 =?utf-8?B?SG5aVHZ0MEEzd0xaRytUamF0MDYyV05hL2Voc1A2SW0waHA0TEx2ZCtzYWFZ?=
 =?utf-8?B?dHY1eWN6UWREQU5scnZPakhxRjNvVDdlMVlCUmRWc3Y1TE14d2c4cUZKUVdV?=
 =?utf-8?B?S1FvQ2F0ZzNQQzdhWUl6cUozYWIzeThDUjgvZDRnM1dlM3BRUmRHTTRqd0Rw?=
 =?utf-8?B?RzRXVFRZdllCVEVYajZraEFpa2NCc3dBVWllV25QbHM2ZGV2VlR2MHlaeGk4?=
 =?utf-8?B?WjJXWC9iYUNSTGtBZU9RZWdlR0RnNm8rNWpzVm16QWQ5cUttVHNjNDRtSkRO?=
 =?utf-8?B?V2VLT1VHOUdSR1pMUFVGZzMwZGoxZHlHYzU5T2hNUGR0RVlzVDJ3aUxwbTJm?=
 =?utf-8?B?QlI3K0xnWFlXVUdrdUZXT1kvQUFCMnFPTU9ueTREMFhPSTcrV0NNck1qL3V3?=
 =?utf-8?B?aHgyc1hUc2JNaHFzSU02ZjhiR1hmWUtSU3BVM3V2STZ4R0pXV2w1RWxsZVlm?=
 =?utf-8?B?TXd3MzkvR0lzUjRuUzZock5XbEQ3TFdhNVFVcDE3NlFhcVlMbkJIQjNJZ0tn?=
 =?utf-8?B?RWE5WTVRV2V0dTFuaFhpcC9VNlpuQnhKOXJHMEIxWlpMUUVyS2ZhbTIzRnBk?=
 =?utf-8?B?Vnc0STJQUXp2Y3lSTDFjUkZKV0J2cGliUDFKL3VjSDVYYjV6dFdhU0h1ajhV?=
 =?utf-8?B?UWI2aTVIMkwycDA4SjRCK3g1bmxRbzN2QW5LVTZPRlVFRjhGZVIveFgyb2Vn?=
 =?utf-8?B?WUxlVmlwd09FRHRtTU8rQStkL09uUTJ5UytkaEVwQ1djK1BkaEp4RFBlQzN2?=
 =?utf-8?Q?hBuRjvePd7b37Hd9jVCjBZqsX?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 4e169212-dfd2-4b80-853c-08db928365d2
X-MS-Exchange-CrossTenant-AuthSource: DM4PR11MB5549.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Aug 2023 11:35:25.6028
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: I4fQ6/5KH6yeIoqF/fLyOZjlV85g08UGXYqpjUqLjaro64Zb0/Xeje0SiFqXE9NRElCkczKcbBI7ldJfKf126g==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR11MB6695
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.5 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,
        RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE,
        URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 7/29/2023 4:35 AM, Sean Christopherson wrote:
> Drop @vcpu from KVM's ->track_write() hook provided for external users of
> the page-track APIs now that KVM itself doesn't use the page-track
> mechanism.
> 
> Reviewed-by: Yan Zhao <yan.y.zhao@intel.com>
> Tested-by: Yongwei Ma <yongwei.ma@intel.com>
> Signed-off-by: Sean Christopherson <seanjc@google.com>
> ---
>   arch/x86/include/asm/kvm_page_track.h |  5 ++---
>   arch/x86/kvm/mmu/page_track.c         |  2 +-
>   drivers/gpu/drm/i915/gvt/kvmgt.c      | 10 ++++------
>   3 files changed, 7 insertions(+), 10 deletions(-)
> 
> diff --git a/arch/x86/include/asm/kvm_page_track.h b/arch/x86/include/asm/kvm_page_track.h
> index eb186bc57f6a..8c4d216e3b2b 100644
> --- a/arch/x86/include/asm/kvm_page_track.h
> +++ b/arch/x86/include/asm/kvm_page_track.h
> @@ -26,14 +26,13 @@ struct kvm_page_track_notifier_node {
>   	 * It is called when guest is writing the write-tracked page
>   	 * and write emulation is finished at that time.
>   	 *
> -	 * @vcpu: the vcpu where the write access happened.
>   	 * @gpa: the physical address written by guest.
>   	 * @new: the data was written to the address.
>   	 * @bytes: the written length.
>   	 * @node: this node
>   	 */
> -	void (*track_write)(struct kvm_vcpu *vcpu, gpa_t gpa, const u8 *new,
> -			    int bytes, struct kvm_page_track_notifier_node *node);
> +	void (*track_write)(gpa_t gpa, const u8 *new, int bytes,
> +			    struct kvm_page_track_notifier_node *node);
>   	/*
>   	 * It is called when memory slot is being moved or removed
>   	 * users can drop write-protection for the pages in that memory slot
> diff --git a/arch/x86/kvm/mmu/page_track.c b/arch/x86/kvm/mmu/page_track.c
> index 23088c90d2fd..891e5cc52b45 100644
> --- a/arch/x86/kvm/mmu/page_track.c
> +++ b/arch/x86/kvm/mmu/page_track.c
> @@ -272,7 +272,7 @@ void kvm_page_track_write(struct kvm_vcpu *vcpu, gpa_t gpa, const u8 *new,
>   	hlist_for_each_entry_srcu(n, &head->track_notifier_list, node,
>   				srcu_read_lock_held(&head->track_srcu))
>   		if (n->track_write)
> -			n->track_write(vcpu, gpa, new, bytes, n);
> +			n->track_write(gpa, new, bytes, n);
>   	srcu_read_unlock(&head->track_srcu, idx);
>   
>   	kvm_mmu_track_write(vcpu, gpa, new, bytes);
> diff --git a/drivers/gpu/drm/i915/gvt/kvmgt.c b/drivers/gpu/drm/i915/gvt/kvmgt.c
> index 034be0655daa..e9276500435d 100644
> --- a/drivers/gpu/drm/i915/gvt/kvmgt.c
> +++ b/drivers/gpu/drm/i915/gvt/kvmgt.c
> @@ -106,9 +106,8 @@ struct gvt_dma {
>   #define vfio_dev_to_vgpu(vfio_dev) \
>   	container_of((vfio_dev), struct intel_vgpu, vfio_device)
>   
> -static void kvmgt_page_track_write(struct kvm_vcpu *vcpu, gpa_t gpa,
> -		const u8 *val, int len,
> -		struct kvm_page_track_notifier_node *node);
> +static void kvmgt_page_track_write(gpa_t gpa, const u8 *val, int len,
> +				   struct kvm_page_track_notifier_node *node);
>   static void kvmgt_page_track_flush_slot(struct kvm *kvm,
>   		struct kvm_memory_slot *slot,
>   		struct kvm_page_track_notifier_node *node);
> @@ -1603,9 +1602,8 @@ int intel_gvt_page_track_remove(struct intel_vgpu *info, u64 gfn)
>   	return 0;
>   }
>   
> -static void kvmgt_page_track_write(struct kvm_vcpu *vcpu, gpa_t gpa,
> -		const u8 *val, int len,
> -		struct kvm_page_track_notifier_node *node)
> +static void kvmgt_page_track_write(gpa_t gpa, const u8 *val, int len,
> +				   struct kvm_page_track_notifier_node *node)
>   {
>   	struct intel_vgpu *info =
>   		container_of(node, struct intel_vgpu, track_node);
Reviewed-by: Zhi Wang <zhi.a.wang@intel.com>