Received: by 2002:a05:6358:c692:b0:131:369:b2a3 with SMTP id fe18csp5642926rwb; Tue, 1 Aug 2023 06:04:03 -0700 (PDT) X-Google-Smtp-Source: APBJJlHHuhz3ueqSPBCy/HKxj7WwRtoozC3TDyTw5hZcW3PWs9M1sY4tgETNTOp8GCTndEiCIELE X-Received: by 2002:a17:902:e88f:b0:1b8:b433:7fa with SMTP id w15-20020a170902e88f00b001b8b43307famr13003596plg.13.1690895043030; Tue, 01 Aug 2023 06:04:03 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1690895043; cv=none; d=google.com; s=arc-20160816; b=0JyAiCLqVbLLw8/OQQybfQo7Xv7nPcPFVIO7AzrbnOWvsOkX+X97P2h0AhOCJiXw9Q kz0R6dP5OEZ8Yw4albzfoqe7LcdwS5wUf1mvlFr2OEtpKuqiAQ2HjXHKwU2YUJ/f+ylQ EMOp0tZgjU8I3qa3vH5xmcUwsnV24N5t9YpmGqHcjU//30tGIzjaYbrSej3E2im+UOzi Hy1lGrG3xaIOG4EnPa8p6qiqD3Afk6OTDDXdqnSQkPjASBqUvTY0rnOUj8rDO/tQ4L3t B7bxV/VL+1R5BjcUuAB4stayJSZHrinlhiojMh3pDilF/j51E3G82Bvo5xZYWGCeuYyf jTIQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=O5BpbWyfcEEuwF+JAY8ZIieV4+oN3raF7W0DkD+op+0=; fh=NWgjOeks6xZK8jd63OjHsmMt0UPFs7GFtQvQtO7GxpI=; b=e/R7wHrFyqJ5LZwmWh9hSMLnGEOi/7DWH5EKfeqjac8qQ/jpO5mdHxhMTLwGlRJmaS 7FZIIM8OCZQBFWYRDhaHnEFENkhW+p/jbmdUUfbyeTZMdTlGO2vi6dl3SGeh/SWnb54D gXj+1XouRKnDIJXIp128Ur5NZbxaZPNpNsVDs3+k1/hwjfoNSwYsNbayimWH0Oj/j8wD CzEBLa7o0+LOXQ51gAgW9ojZxB2uGB26CEEqV0qIv8yTrTjwXe8EF7ntoRgMD9seoRJN Ze6anZ3Wq/ViowltoW0DoNqzaK1OIVwnuo1utFBmsYK5Djrdrs21TAl2T9RjKc0YlDa9 EFag== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail (test mode) header.i=@armlinux.org.uk header.s=pandora-2019 header.b=Yf335vIU; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=armlinux.org.uk Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id x10-20020a17090300ca00b001bb12510890si8734717plc.642.2023.08.01.06.03.48; Tue, 01 Aug 2023 06:04:03 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=fail (test mode) header.i=@armlinux.org.uk header.s=pandora-2019 header.b=Yf335vIU; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=armlinux.org.uk Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232279AbjHAMb5 (ORCPT + 99 others); Tue, 1 Aug 2023 08:31:57 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39716 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231732AbjHAMb4 (ORCPT ); Tue, 1 Aug 2023 08:31:56 -0400 Received: from pandora.armlinux.org.uk (unknown [IPv6:2001:4d48:ad52:32c8:5054:ff:fe00:142]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F1E051FC6; Tue, 1 Aug 2023 05:31:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=O5BpbWyfcEEuwF+JAY8ZIieV4+oN3raF7W0DkD+op+0=; b=Yf335vIUTDg0kFiXcYLf0LDUwV j2hLT+EGGETDCWjACzUUvktloFPJ0zsbciVjHsPIOjYlWuEvfLEouaUvvoQP+OQ0fVmyT5w4KGzq8 RM/H21+9gDq7/1VH53ZVJhe+uiBxT8Oh9XeKYDYo4/f79r63TgvouXZqvlxIJ0GqRW6WmHAUU1oUs 9k1Up5jOYud3NGwqUGTLpgc3mYs8UOqa7m6qi8QkmU0ZGNs/P37Q04papAO2qgDaC9tLPmOyTstxR 5SElIkb/nte+vuNQvPg+2nNIrV40SWEkR2GWideULbchY13MQUYfPLGQv/gtdyFPmDljv8TCwUvZD lXLZgClw==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:41504) by pandora.armlinux.org.uk with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1qQoXR-00044N-1s; Tue, 01 Aug 2023 13:31:45 +0100 Received: from linux by shell.armlinux.org.uk with local (Exim 4.94.2) (envelope-from ) id 1qQoXR-0000gq-KG; Tue, 01 Aug 2023 13:31:45 +0100 Date: Tue, 1 Aug 2023 13:31:45 +0100 From: "Russell King (Oracle)" To: Matti Vaittinen Cc: Matti Vaittinen , Marcin Wojtas , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v8 8/8] net-next: mvpp2: don't shadow error Message-ID: References: <8c5b976a4ef9ba38fc952e9cf61848baa3e9dfe7.1690890774.git.mazziesaccount@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <8c5b976a4ef9ba38fc952e9cf61848baa3e9dfe7.1690890774.git.mazziesaccount@gmail.com> Sender: Russell King (Oracle) X-Spam-Status: No, score=-1.3 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_BLOCKED,RDNS_NONE, SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Aug 01, 2023 at 03:04:40PM +0300, Matti Vaittinen wrote: > Do not overwrite error from lower layers but return the actual error to > user if obtaining an IRQ fails. > > Suggested-by: Andy Shevchenko > Suggested-by: Jonathan Cameron > Signed-off-by: Matti Vaittinen Since your previous patch is incorrect, this one is too. NAK. -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!