Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20230728090916.1538550-1-ardb@kernel.org> <20230728090916.1538550-15-ardb@kernel.org>
 <20230801120827.GFZMj1uzNMDs2gIi1f@fat_crate.local> <CAMj1kXF+=W_oe7MS87rWdJ_z555iz2A8iR42fJ1mwZ+bgCgjmw@mail.gmail.com>
 <20230801124054.GGZMj9VrrB+4a4NiZs@fat_crate.local>
In-Reply-To: <20230801124054.GGZMj9VrrB+4a4NiZs@fat_crate.local>
From:   Ard Biesheuvel <ardb@kernel.org>
Date:   Tue, 1 Aug 2023 14:46:16 +0200
Message-ID: <CAMj1kXFGN6DAhWk647=jHW5wBMP0y4p9wzPBz3R7h=Gh1v6VEA@mail.gmail.com>
Subject: Re: [PATCH v7 14/22] x86/decompressor: Merge trampoline cleanup with
 switching code
To:     Borislav Petkov <bp@alien8.de>
Cc:     linux-efi@vger.kernel.org, linux-kernel@vger.kernel.org,
        Evgeniy Baskov <baskov@ispras.ru>,
        Andy Lutomirski <luto@kernel.org>,
        Dave Hansen <dave.hansen@linux.intel.com>,
        Ingo Molnar <mingo@redhat.com>,
        Peter Zijlstra <peterz@infradead.org>,
        Thomas Gleixner <tglx@linutronix.de>,
        Alexey Khoroshilov <khoroshilov@ispras.ru>,
        Peter Jones <pjones@redhat.com>,
        Gerd Hoffmann <kraxel@redhat.com>,
        Dave Young <dyoung@redhat.com>,
        Mario Limonciello <mario.limonciello@amd.com>,
        Kees Cook <keescook@chromium.org>,
        Tom Lendacky <thomas.lendacky@amd.com>,
        "Kirill A . Shutemov" <kirill.shutemov@linux.intel.com>,
        Linus Torvalds <torvalds@linux-foundation.org>,
        Joerg Roedel <jroedel@suse.de>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Tue, 1 Aug 2023 at 14:41, Borislav Petkov <bp@alien8.de> wrote:
>
> On Tue, Aug 01, 2023 at 02:11:21PM +0200, Ard Biesheuvel wrote:
> > Removing it breaks the build for !CONFIG_X86_5LEVEL
>
> How come?
>

Because a label cannot be at the end of a block. There needs to be at
least one statement.

> $ grep 5LEVEL .config
> # CONFIG_X86_5LEVEL is not set
>
> and it builds fine here.
>

I guess it depends on the compiler version. GCC 10 gives me this

<source>: In function 'foo':
<source>:4:5: error: label at end of compound statement
    4 |     bar:
      |     ^~~

but GCC 13 seems to be fine with it.

https://godbolt.org/z/KnWbY8vEY