Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <01357346-59f3-5c5a-d456-8e64381fe611@amlogic.com>
Date:   Tue, 1 Aug 2023 20:51:30 +0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.13.0
Subject: Re: [PATCH 2/4] watchdog: Add a new struct for Amlogic-GXBB driver
To:     Dmitry Rokosov <ddrokosov@sberdevices.ru>
Cc:     wim@linux-watchdog.org, linux@roeck-us.net, robh+dt@kernel.org,
        krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org,
        neil.armstrong@linaro.org, khilman@baylibre.com,
        jbrunet@baylibre.com, martin.blumenstingl@googlemail.com,
        linux-watchdog@vger.kernel.org, devicetree@vger.kernel.org,
        linux-arm-kernel@lists.infradead.org,
        linux-amlogic@lists.infradead.org, linux-kernel@vger.kernel.org
References: <20230726112146.1127145-1-huqiang.qin@amlogic.com>
 <20230726112146.1127145-3-huqiang.qin@amlogic.com>
 <20230728071558.xoa3sdku3zkuhtug@CAB-WSD-L081021>
Content-Language: en-US
From:   Huqiang Qin <huqiang.qin@amlogic.com>
In-Reply-To: <20230728071558.xoa3sdku3zkuhtug@CAB-WSD-L081021>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?TFROK2VNS2xhWVJpWms4Slkrdi9TYkxMZXU4dGdiVitPZldGVGNxODAzUWxG?=
 =?utf-8?B?bk5qbm94eXh1VXloaXAwZXFyVnpSdmFiM1VxMjJMbjFZdzB5TSt5Q09BUDU2?=
 =?utf-8?B?NER6TUJtWnIvWXUva3oyK2dCamdCVFdtOS9oU3AvdERsKzFyWk9kbUVEek9P?=
 =?utf-8?B?ckd1SEFXZTlQbUdySEdNSVFGL3ljODVla2MwZldPTjZpdVFjUUwrU08vbWpm?=
 =?utf-8?B?bVdSTkZrdk5DckErR0JobmNEak4zTzRQajkrbU1LdDFnOU8rT1hBcUkyRVJU?=
 =?utf-8?B?ZnZNYUZ3cGFOaDlxMTlXVGVEMHhyaC9BOGdER20wNHhYZDRwODhCWEU4V0Rh?=
 =?utf-8?B?UEd2aytrbFMwK3JaZGZySXE4Yk9TbjBqanIveXZweEIvQ1RJT21jM2NsUlBw?=
 =?utf-8?B?MmNjOXJ3MTlRTDFJd05NMnlVSm1ZQ3hGZi9nQ3dFKytYN291VnBFUWl1aUc4?=
 =?utf-8?B?OE15c0FTdUp3R1JzbllsUGUzTVRlZG9vVGM3eUI0djR6SnUydnZEZDdUZXE5?=
 =?utf-8?B?Nnh6QVFLZzF1THFaS21WSVpqUE8xaTRHRG5zUUZHS3dDVmQxV2tPeUtYbGth?=
 =?utf-8?B?bmovMGxHWE5PSVZSdmdGSDhVWnZxSXNDSTBIV0tuUmVaRW1aMThxMm1jR1lx?=
 =?utf-8?B?bHdSVFJNa2FJckE1TXIrODEwVVJNZUoyWXBsd2ozZlBBTVpPNkpOME53Smoz?=
 =?utf-8?B?K3k1NUsxS1RoVEE0MklIUUpib3VPM3M3MmtnWEV6NmpGOUk5U1NPNFduNW9u?=
 =?utf-8?B?V0h2amk5eSt0NXljSnRVU0prTTF6ZGNKNUsyS3Z3ZTVraElSVkVaT0V0Z1kx?=
 =?utf-8?B?NVZNREJJWXhUUlFmbU00clBnTXFaYVl0bEJrUzlra1l6UHpLU2NsVVNab1hm?=
 =?utf-8?B?QkhMQUh1VkkxTlJCQytMS1dPYitxSTQ3TU1aZmpMMjJSRGdjZjJNZ01FVTZK?=
 =?utf-8?B?MzVyUXpGbFgrcHBzRkFsNWNmdG1kZGFuV3lacWtxV0ZLNVlTMHFBVjAxSmo3?=
 =?utf-8?B?YWxqY0dVVlUrbjQ2L25ENS9UbUVKRXJ3RXVFSFQ2bHl2bkJldytTaUJ1bDJq?=
 =?utf-8?B?ZWdoNUFaR1BXZzJNSWtMWVRCZU5wWFFiaWhZa0E1RlhQb3locm1jWTd3TGhY?=
 =?utf-8?B?eURxOGR4ckVEb1dib2tzWGU5U0hqTEg4MzdiRUpSWUc2ZHl3dW8zVmkxQ0t3?=
 =?utf-8?B?RlVhVEloV0JYR3pUSjc4STBKNi9mTWFQRXMvMFc1UE5rOFZjWlNuZzQwWi9W?=
 =?utf-8?B?MzMzaFpiYWxXcnZtRlJkdUtsajZkdkx1Tm9MazJHRGE1SXRyckg4NGkyZTNX?=
 =?utf-8?B?RW9HY2Z5L25OT09UTjdOSy9tdjdOZXBDeUZCZ3ZZWnU3WXcxYTU2dktJZVBX?=
 =?utf-8?B?eFR5TkNxU2R4L3llckM1TUhacWhGWjVSaCtxZ3Rha3ZZQ0RmaDYzNUI4RENU?=
 =?utf-8?B?a0hwUGhTeW9MTTVISFFlOE4wTFFESWdZbXR5TGJzSjlackVpc0tQYW5KOGlG?=
 =?utf-8?B?N0F0c0xvSTk5dWlnVGl1eWV3Q2ZPaVJ3aTlYY0hsREd3N0NnSUZzVVdBeXlq?=
 =?utf-8?B?TkJnY1c0RGZOM1h5Y2g5Y1dTOTB4d3NmczZBNjdFN3NyT2pqUE9VY0wxSDdR?=
 =?utf-8?B?bWljdGdDR2dLVXhWWXFTOVdvdHN5QVU4bm9JYXQzczF5bmlrbGpIbWFkZVp0?=
 =?utf-8?B?c25NakdwbkVKc2ZESGgvZW5wMWo1UVRTYlh6d0ZDd1FFM29YcEI2eGpibG94?=
 =?utf-8?B?Ym5hMzByMmJCSzR1S3FiZy9BZ2RWb3VPNDhKcUJwQlZnQjFVWnkwK3g5Y0J5?=
 =?utf-8?B?SU9zaVVIcDcySVRHRnl1cFRlejVZVHpvMjgzZlEyWEVJbFNmSmJBVnZxNzlB?=
 =?utf-8?B?eTJHSS9VYzNkOSs0cUJoMHFPUW5LMkJ1ajIrb2VCSDlXNmhTV21LcXZ0ajYx?=
 =?utf-8?B?YXAyUW80TUZFNmRBWks5cUVLRitDSHpiakU4Q1BYTElsbXYvLzNmdUV2RnNX?=
 =?utf-8?B?ZE8zMHM2SXl0b3U4cHUybFQ5ZHFnK0pGZGdFTmFWRCtHVGpqMWZEa0dlUFRD?=
 =?utf-8?B?SWJxTXo3d1RMMkNYY09XNnlBMkZJajBPclJqL3luY25yS1A4VHNONy9yQ2do?=
 =?utf-8?B?UTN3MGFxb1Z6RlVxb1RXN0loblVjRjRkVUdPMkIzTm1Namoyb3BnSk9pL3RN?=
 =?utf-8?B?WVE9PQ==?=
X-OriginatorOrg: amlogic.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 2c5cf5d9-e325-43cc-1e1c-08db928e0a3b
X-MS-Exchange-CrossTenant-AuthSource: KL1PR03MB7221.apcprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Aug 2023 12:51:36.2659
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 0df2add9-25ca-4b3a-acb4-c99ddf0b1114
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: /Dq+sKuOqmgoLNZIboVW3Q212oZavyqGBI4YAR4Ha61+kbZ0VtTlUHzIXNhrI5gR6drwuNHPOvAmkPUO3eMU3w==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SEZPR03MB6491
X-Spam-Status: No, score=-2.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,
        RCVD_IN_DNSWL_BLOCKED,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,
        T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no
        version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Dmitry,

On 2023/7/28 15:15, Dmitry Rokosov wrote:
> [ EXTERNAL EMAIL ]
> 
> Hello Huqiang,
> 
> Thank you for the patch series!
> 
> Please include a cover letter in future patch submissions if possible.
> It will help to better understand the theme of the patch series and
> group all patch sets together in one email thread.

Thank you for your suggestion. In fact, this patch series contains
a cover letter. It may be due to network reasons that it was not
sent to your mailbox correctly :)

...
>>  static int meson_gxbb_wdt_start(struct watchdog_device *wdt_dev)
>>  {
>>       struct meson_gxbb_wdt *data = watchdog_get_drvdata(wdt_dev);
>> @@ -140,8 +143,12 @@ static const struct dev_pm_ops meson_gxbb_wdt_pm_ops = {
>>       SET_SYSTEM_SLEEP_PM_OPS(meson_gxbb_wdt_suspend, meson_gxbb_wdt_resume)
>>  };
>>
>> +static const struct wdt_params gxbb_params = {
>> +     .rst_shift = 21,
> 
> Maybe it's better to declare rst with the BIT() macro already applied,
> and use it in wdt_probe() as is. And name 'rst' without 'shift' is
> looking more brief.

Okay, I will change it in the next version.


Thanks

Best Regards,
Huqiang Qin