Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <34e5cea4-b837-cb1e-15c1-fcbf2dba4f71@intel.com>
Date:   Tue, 1 Aug 2023 14:42:43 +0300
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.13.0
Subject: Re: [PATCH v4 29/29] drm/i915/gvt: Drop final dependencies on KVM
 internal details
Content-Language: en-US
To:     Sean Christopherson <seanjc@google.com>,
        Paolo Bonzini <pbonzini@redhat.com>,
        Zhenyu Wang <zhenyuw@linux.intel.com>
CC:     <kvm@vger.kernel.org>, <intel-gvt-dev@lists.freedesktop.org>,
        <intel-gfx@lists.freedesktop.org>, <linux-kernel@vger.kernel.org>,
        Yan Zhao <yan.y.zhao@intel.com>,
        Yongwei Ma <yongwei.ma@intel.com>,
        Ben Gardon <bgardon@google.com>
References: <20230729013535.1070024-1-seanjc@google.com>
 <20230729013535.1070024-30-seanjc@google.com>
From:   "Wang, Zhi A" <zhi.a.wang@intel.com>
In-Reply-To: <20230729013535.1070024-30-seanjc@google.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?dit5S2IwZHNlY25IRnp6cVJtS3VhcGZtSmZ0OXlGZzArb1p6SW8rdFNNSkNE?=
 =?utf-8?B?SEgxeURGcnZRY0NIbXNweno4M2lseWd5em9taTc4bEFmenFzSElROGxITnVG?=
 =?utf-8?B?TzlvVGVESXdsYUxGVVhGNWpvWk0vVzhCRVdkRDJWcW41VEJEbzF3ZmNEcWMw?=
 =?utf-8?B?TTFTN2tTZVVUQlFDYUk2L3kxVklMVG5MV3lRdkdrT0Flc041d1R1YUZZSXkz?=
 =?utf-8?B?eTlwRDB3MTlkUVlncDhXUHRKUWRMb0hCMHA5YmlseVpwQithanlPa3VDVERQ?=
 =?utf-8?B?eTVyUGNoaHVhVHNOZGE4cjAvYmZSdGxyMGJTNE4yUXRKYWZaMDYzTnYrK05o?=
 =?utf-8?B?bm4yZUROZHA0N3o5Vlcyc3h4UmZhMkRyVmt6cnpyNmh5S1N0TzIvVnBpUTBP?=
 =?utf-8?B?SzZ1dTNVUld0a29uSDROcTRHN1J4L25CVENBOWduUENOT3dsMjZkbCtqSm5X?=
 =?utf-8?B?cnBQdFpaVmFoMkQ5d0ZXSG9nNkJ3VVpZZ2tNR1ZpT0Q1dVg3OERmYVNvN3FX?=
 =?utf-8?B?VEUzT3NNZG1ZRml0LzVxQ05Fa21GWE8rdG9QRk5ad05tOHh6aGg3RlJyc2d1?=
 =?utf-8?B?cTlKVEduZnA0eDdZZ2tSemp0cVZRUW81MnZCaE9mM0QySk50QXAzOWhXcWFt?=
 =?utf-8?B?dEg0UUgvODh3NFFqcmppeTlENE8vNUdDZXpkT0Z1aXRpUjZZcE5NaXVCWERt?=
 =?utf-8?B?MDNYOGpVMzBVenlKTHB2U0JrdDZQRmptSHM3bng4UUxjeHJZNWdXQXBiZ2hI?=
 =?utf-8?B?VXE0ZjhlMERHbkk3ZjNpN1dsWkVpQUswRzJ1WUxKeVA0NWVzL2k5eFQ5UmdB?=
 =?utf-8?B?bjB4ZEgwcjBYSS82Y0NSUWFIeit6N0lmTVlpcHNWbW10OFJSUE5xc0lIZGo1?=
 =?utf-8?B?Y2VDWWxHbUx2NzZiY1kydGdQbFFOclRKemx5RFE1U05jcEREVmlScDRhM2dS?=
 =?utf-8?B?WVFZTDlBakMrblJsalVlVzlaRFlsR1h3OEtYVE04QUllMGczVEJwYnlYVmND?=
 =?utf-8?B?VUNlbmFlZXZwbU5WRTVDK3pFQWFoeG9DeWtKaS9IN1p6THlmb0JJWmpBclQ0?=
 =?utf-8?B?TGh3NXVEUWhyN3pFbzh1WUtocEw2NHhPdFdVUXdVUE5CVnVMbXVVeUVuaEZE?=
 =?utf-8?B?aU1iYnU3UVI3NG5ZaEhPbkxEYTUxaU9rTDFXckdHZU9wVTgxZlByZE9nUGlk?=
 =?utf-8?B?NEF1TFp4RkR4MDg5RHdEbUk5c2ljdkFueW1zeW9laFZZazEzT3lHU2dHcGow?=
 =?utf-8?B?bzZHTVc3Wi9iNXBOWDBFNW9GY3ppaXQ1UnlxRnhIZmpJTldkZVowS1BTRXd4?=
 =?utf-8?B?b01zUjEvVGNEMGxMU2JoanRWSDg3dGNnazlyNHI5cFZsMldpRVA1c3lSeHJX?=
 =?utf-8?B?SlVTKzhwMVhnVTNIRzkwaU1wR1plK000akREUnB6dmFWTldreXJrd2RNdWtB?=
 =?utf-8?B?TlBJMHBtdzdtUmRaaEQ0a2RzYnZyU3ZzdzdQZDNGL3JmWWp1L05QUHVFQ3RU?=
 =?utf-8?B?Wmc2NzNtQlJEazJLY0Vob2N4RzJYS3gwVk5jYlJuZXpMVjZUOVlkcWVtS0U5?=
 =?utf-8?B?dG52QVA3Q0FyTlJzQjNoZ1BQQmdMMldRWkZ4Rmxwc3pSNGN1anpvQTdERnYv?=
 =?utf-8?B?VmhCUmV2YVJWUnB2RVpLTTQwT05TT0syaXR0MEIrcU1OOUxWa2txc1Mrb2Y5?=
 =?utf-8?B?SmdaTkwrbHgzZGF1bTVJOCtDcnpSK2gvV2Q3YmJ2QnNuci9Qc0UwV0xHSEJY?=
 =?utf-8?B?TGlEc3RjZ0p4a2ZtNkI4clpMVGgza0JmWU0xSXlKYVlyeTdvM1FRMThoK0o1?=
 =?utf-8?B?VWR2TFJPRDNVUjkweXZONnpmdi9QZmNWVVM2dzFOWDdhOXRXeTRxREY3OEF5?=
 =?utf-8?B?KzZlNXA2STUxQmh4Sk5SNXhXNmJWVzNHbXJmMlJtVXdsSzFvUlBoUnBzb05t?=
 =?utf-8?B?aWN2Y0NNTm8wcy8rSkVPVnd6dkswdmZVdjBtSmNKSkx2WXdHYVI0MGRTblZ6?=
 =?utf-8?B?aHdHRHVqZDdYVzlQKzhaQmRrbG0yNmFqenkvUXlkZDd4eGVkUlNYcllrUmJ0?=
 =?utf-8?B?TFRZdSs3Y2NKakM1Mk9rRDNsdkNtY25UYUdtVFhtOW01dytodFhNQ0lsbFpV?=
 =?utf-8?Q?C4/jG354zVhQ0NMuuZA97mF04?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 0cb8b262-0e5c-4844-110c-08db92846ea4
X-MS-Exchange-CrossTenant-AuthSource: DM4PR11MB5549.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Aug 2023 11:42:49.5004
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: v6qgYDaRjaVp0n8ZX9YmS1r7UbupdwlLaAHfrFbOXQsS96v+kjjHPy6IkuLsa9dn/VfZ4M6iVuMWwAv1t3QXhQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA0PR11MB7379
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-2.2 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,
        RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE,
        URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 7/29/2023 4:35 AM, Sean Christopherson wrote:
> Open code gpa_to_gfn() in kvmgt_page_track_write() and drop KVMGT's
> dependency on kvm_host.h, i.e. include only kvm_page_track.h.  KVMGT
> assumes "gfn == gpa >> PAGE_SHIFT" all over the place, including a few
> lines below in the same function with the same gpa, i.e. there's no
> reason to use KVM's helper for this one case.
> 
> No functional change intended.
> 
> Reviewed-by: Yan Zhao <yan.y.zhao@intel.com>
> Tested-by: Yongwei Ma <yongwei.ma@intel.com>
> Signed-off-by: Sean Christopherson <seanjc@google.com>
> ---
>   drivers/gpu/drm/i915/gvt/gvt.h   | 3 ++-
>   drivers/gpu/drm/i915/gvt/kvmgt.c | 2 +-
>   2 files changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/gpu/drm/i915/gvt/gvt.h b/drivers/gpu/drm/i915/gvt/gvt.h
> index 2d65800d8e93..53a0a42a50db 100644
> --- a/drivers/gpu/drm/i915/gvt/gvt.h
> +++ b/drivers/gpu/drm/i915/gvt/gvt.h
> @@ -34,10 +34,11 @@
>   #define _GVT_H_
>   
>   #include <uapi/linux/pci_regs.h>
> -#include <linux/kvm_host.h>
>   #include <linux/vfio.h>
>   #include <linux/mdev.h>
>   
> +#include <asm/kvm_page_track.h>
> +
>   #include "i915_drv.h"
>   #include "intel_gvt.h"
>   
> diff --git a/drivers/gpu/drm/i915/gvt/kvmgt.c b/drivers/gpu/drm/i915/gvt/kvmgt.c
> index eb50997dd369..aaed3969f204 100644
> --- a/drivers/gpu/drm/i915/gvt/kvmgt.c
> +++ b/drivers/gpu/drm/i915/gvt/kvmgt.c
> @@ -1585,7 +1585,7 @@ static void kvmgt_page_track_write(gpa_t gpa, const u8 *val, int len,
>   
>   	mutex_lock(&info->vgpu_lock);
>   
> -	if (kvmgt_gfn_is_write_protected(info, gpa_to_gfn(gpa)))
> +	if (kvmgt_gfn_is_write_protected(info, gpa >> PAGE_SHIFT))
>   		intel_vgpu_page_track_handler(info, gpa,
>   						     (void *)val, len);
>   
Reviewed-by: Zhi Wang <zhi.a.wang@intel.com>