Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <54fb226b-a4b6-92e5-92a8-e3e3f68e0d42@intel.com>
Date:   Tue, 1 Aug 2023 14:37:33 +0300
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.13.0
Subject: Re: [PATCH v4 17/29] drm/i915/gvt: Don't bother removing
 write-protection on to-be-deleted slot
Content-Language: en-US
To:     Sean Christopherson <seanjc@google.com>,
        Paolo Bonzini <pbonzini@redhat.com>,
        Zhenyu Wang <zhenyuw@linux.intel.com>
CC:     Yan Zhao <yan.y.zhao@intel.com>, <kvm@vger.kernel.org>,
        <intel-gfx@lists.freedesktop.org>, <linux-kernel@vger.kernel.org>,
        Yongwei Ma <yongwei.ma@intel.com>,
        Ben Gardon <bgardon@google.com>,
        <intel-gvt-dev@lists.freedesktop.org>
References: <20230729013535.1070024-1-seanjc@google.com>
 <20230729013535.1070024-18-seanjc@google.com>
From:   "Wang, Zhi A" <zhi.a.wang@intel.com>
In-Reply-To: <20230729013535.1070024-18-seanjc@google.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Y1lOaWlFam5pRnZ1TlpPYmFRelNQSGlWcnhPWWc5Qk5YSERzdmtCTmhMYTRE?=
 =?utf-8?B?enM0WlU5dWR2dnFVTUVzUkx6dlJCRWg5enFENVdZQXZwZzdUb1E4Z29yRlZE?=
 =?utf-8?B?Y05DNjVVQlVPbmRIeENDZm8xbCttbHV2bmJMTDBzcGMydmZXRmhDZ3d4UVcx?=
 =?utf-8?B?aGYybTdkT1BUWE5hSXNKdE9PRHFKaEZCbTF3ZWRvYUlDNjZiRjJtcDhQcGY4?=
 =?utf-8?B?Q2pPVldpOXBXN1NEc1dOd1hXeFZwZERXTzFvY2dwUVJ2TzgwMk4xRlJuMlBT?=
 =?utf-8?B?OE9ZM0U5RmdQU0pMQWw1Q29QS0huRXRibGF2REEreis1ZnRFd0JxM0dWNDlJ?=
 =?utf-8?B?M2Y2N3ZHUW9td1FKUUVpS3lqUHVXSWIxRHdtdmMzL3d1djNVVHYyMktjRjVm?=
 =?utf-8?B?REJsWGZDYzVmSHA3T200aTZTWGxYcmp2dW9yUUpPRExtY25FcTUwWHVRdFcx?=
 =?utf-8?B?U2JLdGVHOXNuZk9VNjAwT2tGNkM1VFVUMVV3QUtuU3Y5OHRYeGRBUlFOYWFE?=
 =?utf-8?B?Vi9LRGFUL21WYUNOZmtiMVFlTjJId0VmV2lzL1VENm5CSHMxb252RFYwT0g2?=
 =?utf-8?B?S3ZZTHg4eXgvVE5vZlpEejdxZ2IvU2dGTnllT25nWTE1L2dqditLZzliaXkw?=
 =?utf-8?B?L3IvRlBSWmsvUEorVUdEajR4YVo1TVUyVnBMekFSUStaQm9UcGVqWFl3MDF3?=
 =?utf-8?B?N2NjRWY4Q091dS83Wm83QkFybVJCK1EyYnVhRnduS3dtNlJEanlzVlJrKzFW?=
 =?utf-8?B?RTlHOEtCSXdPVFFGQ3cxcnRlbmh4Q3l0UlcrV3k1endabkRMU1dEYWtNWTlT?=
 =?utf-8?B?eHpTUTJyTE1OeDBNcGN1amd4VHJHTzBVb2t0SDNYT1JIZjRWWmZpeEdxdTBO?=
 =?utf-8?B?ODlxbnA5R2d1STdaazNac2YvREpETW0zbTMrb3JsZWpJaW5jWXJKdlpKMWx4?=
 =?utf-8?B?TlZLVTJRQ2p6MDdBWC9hM1ZXTnYxaEN1WWF5NlhIT3VNbEgwa2xyU3VBU3RB?=
 =?utf-8?B?RnRHL0tKMDU3Y0ZCNzVSNFUzY1U2b1BvaTE0TmJpYmNsUGdmZTFqWGlEeS9W?=
 =?utf-8?B?eGFEbTBUQ3ZhSU1MMFVFM2pHdzRNOHBZMEExWEJXVCtEU0hlUmltSHNMV1Ay?=
 =?utf-8?B?c0ZTMW1ncFNuTjl4UmRaRktCcDd2ckRkRnVIR0JrQWdNdmZOYVRQejdnczhS?=
 =?utf-8?B?Ty8zelN4SGJScFFaVDNHTEVMOWdHRGNscjdMUlhRRmRFdlVvVHRYVXgvNDB2?=
 =?utf-8?B?QnZLR2Z4UW40NFR0aVlxQm52Y1NIZ1FVa2dUdjRlN0pKYzc1VEcvQmk1bER6?=
 =?utf-8?B?ZnF3TVk4U0t0WFd0dnFLc3pYaEFoMlpXWHFXWDJJV3h6ZFg1UEt2ZG5zeWVW?=
 =?utf-8?B?VnFyZmdCQnhEMDQ5SG9pU2xUZVhIWmpsS2R3UzdFc2xGTGdrSURIdHhSRmtJ?=
 =?utf-8?B?aHVBZXc5YXphQXRFZksvbkFUa3doanNHd0o5TjkrSG12WUQvL0hWRXl5S09V?=
 =?utf-8?B?eGRFZS9zTGtPbEE3aXBYQ0RLSGozckNFd3ZrTkdNYlEwdHNjcEhKMWhDK242?=
 =?utf-8?B?QXpmSG5vbVBKdGxrMnEweEZUTUdxdXczeEtHR1FrRS9yVVNNQllhK25WQzIr?=
 =?utf-8?B?MzEzejIrZnNDYTUzNzJPVVNpOXhrb1ZiTE9zSW5IbWo0amFVUFhjb0ZudGli?=
 =?utf-8?B?U2NtMjVpeVhtTzVFWXN6MG5ScndFS20yeCtOMmlDZFlCU0cwVFZQUE9SZk5T?=
 =?utf-8?B?SHMrRzE3TzYxUGluMTY2ek5OUEFoUjdmZ1FDRG0xSmJMckJBcTVRUjNSZmln?=
 =?utf-8?B?T3lrQjluaUtENDJmY3ZlQ2hhSmoyVDY1M0cxd1BmcFA0N3UxN2tCd0VXUjFZ?=
 =?utf-8?B?K21aNWxTYzdpVlRZcHRneHJlS1owNjY3RnFlak42L0RJdnFyNEllbW42V0Vv?=
 =?utf-8?B?cGczNWw2dHp5NXZqb1lpRmp4Y2I1aWlGQlQ0UUxuY3l1ZzFGanFNeGV0VlVz?=
 =?utf-8?B?TUlzOHBUM0JCV05DNlNCVjdFeGJnMkh2d2ZsTTdpcTNnSUxiRzBxUWkwWmI3?=
 =?utf-8?B?UUM4YzZzbVhUbTJ5WEJvaWllazJURlZMS2JBV2NuOVNUOUFXYUhLbGZVNWE0?=
 =?utf-8?Q?3ZIQuLfzNeHfDHB8HrO3OYtv5?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 9f6b1871-fa5c-472e-adb7-08db9283b5e6
X-MS-Exchange-CrossTenant-AuthSource: DM4PR11MB5549.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Aug 2023 11:37:39.5498
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 5gRXB8s9pcvetNcMVmO3ymj+xaaqzyNLJM6hwL2T8RraePC92zOkZDVmiRXZlbppufUX+Gd4jexwkYd7wYEkVQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA0PR11MB7379
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-2.2 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,
        RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE,
        URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 7/29/2023 4:35 AM, Sean Christopherson wrote:
> When handling a slot "flush", don't call back into KVM to drop write
> protection for gfns in the slot.  Now that KVM rejects attempts to move
> memory slots while KVMGT is attached, the only time a slot is "flushed"
> is when it's being removed, i.e. the memslot and all its write-tracking
> metadata is about to be deleted.
> 
> Reviewed-by: Yan Zhao <yan.y.zhao@intel.com>
> Tested-by: Yongwei Ma <yongwei.ma@intel.com>
> Signed-off-by: Sean Christopherson <seanjc@google.com>
> ---
>   drivers/gpu/drm/i915/gvt/kvmgt.c | 8 +-------
>   1 file changed, 1 insertion(+), 7 deletions(-)
> 
> diff --git a/drivers/gpu/drm/i915/gvt/kvmgt.c b/drivers/gpu/drm/i915/gvt/kvmgt.c
> index e9276500435d..3ea3cb9eb599 100644
> --- a/drivers/gpu/drm/i915/gvt/kvmgt.c
> +++ b/drivers/gpu/drm/i915/gvt/kvmgt.c
> @@ -1630,14 +1630,8 @@ static void kvmgt_page_track_flush_slot(struct kvm *kvm,
>   
>   	for (i = 0; i < slot->npages; i++) {
>   		gfn = slot->base_gfn + i;
> -		if (kvmgt_gfn_is_write_protected(info, gfn)) {
> -			write_lock(&kvm->mmu_lock);
> -			kvm_slot_page_track_remove_page(kvm, slot, gfn,
> -						KVM_PAGE_TRACK_WRITE);
> -			write_unlock(&kvm->mmu_lock);
> -
> +		if (kvmgt_gfn_is_write_protected(info, gfn))
>   			kvmgt_protect_table_del(info, gfn);
> -		}
>   	}
>   	mutex_unlock(&info->vgpu_lock);
>   }
Reviewed-by: Zhi Wang <zhi.a.wang@intel.com>