Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <93722831-dc83-8ea3-4af9-33eaefcf81be@quicinc.com>
Date:   Tue, 1 Aug 2023 18:18:46 +0530
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.10.1
Subject: Re: [PATCH] rtc: rtc-pm8xxx: control default alarm wake up capability
Content-Language: en-US
To:     Alexandre Belloni <alexandre.belloni@bootlin.com>
CC:     Alessandro Zummo <a.zummo@towertech.it>,
        <linux-rtc@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
        Venkata Rao Kakani <quic_vkakani@quicinc.com>
References: <20230801114549.26956-1-quic_ajainp@quicinc.com>
 <20230801124056fc665814@mail.local>
From:   Anvesh Jain P <quic_ajainp@quicinc.com>
In-Reply-To: <20230801124056fc665814@mail.local>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

In automotive systems, RTC should not wake up the device when it is 
parked or when it is garage to avoid leakage current. providing a 
control from device tree to avoid RTC wake up based on the use case is 
reason for this patch.

On 8/1/2023 6:10 PM, Alexandre Belloni wrote:
> On 01/08/2023 17:15:49+0530, Anvesh Jain P wrote:
>> Enable & disable rtc alarm wake up capability based on
>> default parameter passed from device tree.
>>
> 
> I see what you are doing but not why this is necessary, NAK.
> 
>> Signed-off-by: Venkata Rao Kakani <quic_vkakani@quicinc.com>
>> Signed-off-by: Anvesh Jain P <quic_ajainp@quicinc.com>
>> ---
>>   drivers/rtc/rtc-pm8xxx.c | 3 +++
>>   1 file changed, 3 insertions(+)
>>
>> diff --git a/drivers/rtc/rtc-pm8xxx.c b/drivers/rtc/rtc-pm8xxx.c
>> index f6b779c12ca7..bed57be602b6 100644
>> --- a/drivers/rtc/rtc-pm8xxx.c
>> +++ b/drivers/rtc/rtc-pm8xxx.c
>> @@ -523,6 +523,9 @@ static int pm8xxx_rtc_probe(struct platform_device *pdev)
>>   	if (rc)
>>   		return rc;
>>   
>> +	if (of_property_read_bool(pdev->dev.of_node, "disable-alarm-wakeup"))
>> +		device_set_wakeup_capable(&pdev->dev, false);
>> +
>>   	rc = dev_pm_set_wake_irq(&pdev->dev, rtc_dd->alarm_irq);
>>   	if (rc)
>>   		return rc;
>>
>> base-commit: 0a8db05b571ad5b8d5c8774a004c0424260a90bd
>> -- 
>> 2.17.1
>>
>